Bug 1561435 - Fix linting errors for mobile/, r=standard8

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D35915

--HG--
extra : source : 2072cc33ae8e2b64a761ece5ab32ce711d547c97
extra : intermediate-source : afb89fcad8e41f4f03ea5d16a7528002820b8305

mobile/android/components/PromptService.js

@@ -498,6 +498,8 @@ InternalPrompt.prototype = {
     }
 
     // (eslint-disable: see bug 1177904)
+    /* eslint-disable no-undef */
+
     let ok = false;
     if (aUser) {
       ok = this.nsIPrompt_promptUsernameAndPassword(
@@ -508,10 +510,11 @@ InternalPrompt.prototype = {
         checkMsg,
         check
       );
-    } // eslint-disable-line no-undef
+    } else {
-    else {
       ok = this.nsIPrompt_promptPassword(aTitle, aText, aPass, checkMsg, check);
-    } // eslint-disable-line no-undef
+    }
+
+    /* eslint-enable no-undef */
 
     if (ok && canSave && check.value) {
       PromptUtils.savePassword(hostname, realm, aUser, aPass);

mobile/android/components/extensions/ext-browserAction.js

@@ -30,18 +30,14 @@ class BrowserAction extends EventEmitter {
 
     this.tabManager = extension.tabManager;
 
-    this.tabContext.on(
+    // eslint-disable-next-line mozilla/balanced-listeners
-      "tab-selected", // eslint-disable-line mozilla/balanced-listeners
+    this.tabContext.on("tab-selected", (evt, tabId) => {
-      (evt, tabId) => {
       this.onTabSelected(tabId);
-      }
+    });
-    );
+    // eslint-disable-next-line mozilla/balanced-listeners
-    this.tabContext.on(
+    this.tabContext.on("tab-closed", (evt, tabId) => {
-      "tab-closed", // eslint-disable-line mozilla/balanced-listeners
-      (evt, tabId) => {
       this.onTabClosed(tabId);
-      }
+    });
-    );
 
     BrowserActions.register(this);
   }

mobile/android/components/extensions/ext-pageAction.js

@@ -65,18 +65,14 @@ class PageAction extends EventEmitter {
 
     this.shouldShow = false;
 
-    this.tabContext.on(
+    // eslint-disable-next-line mozilla/balanced-listeners
-      "tab-selected", // eslint-disable-line mozilla/balanced-listeners
+    this.tabContext.on("tab-selected", (evt, tabId) => {
-      (evt, tabId) => {
       this.onTabSelected(tabId);
-      }
+    });
-    );
+    // eslint-disable-next-line mozilla/balanced-listeners
-    this.tabContext.on(
+    this.tabContext.on("tab-closed", (evt, tabId) => {
-      "tab-closed", // eslint-disable-line mozilla/balanced-listeners
-      (evt, tabId) => {
       this.onTabClosed(tabId);
-      }
+    });
-    );
   }
 
   /**

mobile/android/components/extensions/ext-utils.js

@@ -783,8 +783,8 @@ class WindowManager extends WindowManagerBase {
   }
 }
 
+// eslint-disable-next-line mozilla/balanced-listeners
 extensions.on("startup", (type, extension) => {
-  // eslint-disable-line mozilla/balanced-listeners
   defineLazyGetter(extension, "tabManager", () => new TabManager(extension));
   defineLazyGetter(
     extension,

mobile/android/modules/geckoview/GeckoViewAccessibility.jsm

@@ -30,6 +30,7 @@ class GeckoViewAccessibility extends GeckoViewModule {
   }
 }
 
+// eslint-disable-next-line no-unused-vars
 const { debug, warn } = GeckoViewAccessibility.initLogging(
   "GeckoViewAccessibility"
-); // eslint-disable-line no-unused-vars
+);

mobile/android/modules/geckoview/GeckoViewContentBlocking.jsm

@@ -57,6 +57,7 @@ class GeckoViewContentBlocking extends GeckoViewModule {
   }
 }
 
+// eslint-disable-next-line no-unused-vars
 const { debug, warn } = GeckoViewContentBlocking.initLogging(
   "GeckoViewContentBlocking"
-); // eslint-disable-line no-unused-vars
+);

mobile/android/modules/geckoview/GeckoViewStorageController.jsm

@@ -11,9 +11,10 @@ const { GeckoViewUtils } = ChromeUtils.import(
 );
 const { Services } = ChromeUtils.import("resource://gre/modules/Services.jsm");
 
+// eslint-disable-next-line no-unused-vars
 const { debug, warn } = GeckoViewUtils.initLogging(
   "GeckoViewStorageController"
-); // eslint-disable-line no-unused-vars
+);
 
 // Keep in sync with StorageController.ClearFlags and nsIClearDataService.idl.
 const ClearFlags = [