Bug 1811278 - Add disable next line for all browser/base PART 5 r=mossop

Differential Revision: https://phabricator.services.mozilla.com/D167285

.eslintrc.js

@@ -574,35 +574,6 @@ module.exports = {
         // That are all files that produes warnings in the existing test infrastructure.
         // Since our focus is that new tests won't use http without thinking twice we exempt
         // these test files for now. Bug 1758951
-        "browser/base/content/test/tabs/browser_close_during_beforeunload.js",
-        "browser/base/content/test/tabs/browser_contextmenu_openlink_after_tabnavigated.js",
-        "browser/base/content/test/tabs/browser_e10s_switchbrowser.js",
-        "browser/base/content/test/tabs/browser_lazy_tab_browser_events.js",
-        "browser/base/content/test/tabs/browser_multiselect_tabs_bookmark.js",
-        "browser/base/content/test/tabs/browser_multiselect_tabs_copy_through_drag_and_drop.js",
-        "browser/base/content/test/tabs/browser_multiselect_tabs_duplicate.js",
-        "browser/base/content/test/tabs/browser_multiselect_tabs_move_to_new_window_contextmenu.js",
-        "browser/base/content/test/tabs/browser_multiselect_tabs_open_related.js",
-        "browser/base/content/test/tabs/browser_navigatePinnedTab.js",
-        "browser/base/content/test/tabs/browser_new_file_whitelisted_http_tab.js",
-        "browser/base/content/test/tabs/browser_new_tab_in_privilegedabout_process_pref.js",
-        "browser/base/content/test/tabs/browser_new_tab_insert_position.js",
-        "browser/base/content/test/tabs/browser_opened_file_tab_navigated_to_web.js",
-        "browser/base/content/test/tabs/browser_privilegedmozilla_process_pref.js",
-        "browser/base/content/test/tabs/browser_progress_keyword_search_handling.js",
-        "browser/base/content/test/tabs/browser_replacewithwindow_commands.js",
-        "browser/base/content/test/tabs/browser_undo_close_tabs.js",
-        "browser/base/content/test/webrtc/browser_devices_get_user_media.js",
-        "browser/base/content/test/zoom/browser_background_link_zoom_reset.js",
-        "browser/base/content/test/zoom/browser_background_zoom.js",
-        "browser/base/content/test/zoom/browser_default_zoom_multitab.js",
-        "browser/base/content/test/zoom/browser_default_zoom_multitab_002.js",
-        "browser/base/content/test/zoom/browser_image_zoom_tabswitch.js",
-        "browser/base/content/test/zoom/browser_mousewheel_zoom.js",
-        "browser/base/content/test/zoom/browser_sitespecific_background_pref.js",
-        "browser/base/content/test/zoom/browser_sitespecific_video_zoom.js",
-        "browser/base/content/test/zoom/browser_subframe_textzoom.js",
-        "browser/base/content/test/zoom/browser_tabswitch_zoom_flicker.js",
         "browser/components/aboutlogins/tests/browser/browser_createLogin.js",
         "browser/components/aboutlogins/tests/chrome/test_login_item.html",
         "browser/components/contextualidentity/test/browser/browser_broadcastchannel.js",

browser/base/content/test/tabs/browser_close_during_beforeunload.js

@@ -21,7 +21,9 @@ add_task(async function() {
   let win = await BrowserTestUtils.openNewBrowserWindow();
 
   let browser = win.gBrowser.selectedBrowser;
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   BrowserTestUtils.loadURIString(browser, "http://example.com/");
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   await BrowserTestUtils.browserLoaded(browser, false, "http://example.com/");
 
   await SpecialPowers.spawn(browser, [], () => {

browser/base/content/test/tabs/browser_contextmenu_openlink_after_tabnavigated.js

@@ -1,6 +1,7 @@
 "use strict";
 
 const example_base =
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   "http://example.com/browser/browser/base/content/test/tabs/";
 
 add_task(async function test_contextmenu_openlink_after_tabnavigated() {
@@ -32,6 +33,7 @@ add_task(async function test_contextmenu_openlink_after_tabnavigated() {
 
   let awaitNewTabOpen = BrowserTestUtils.waitForNewTab(
     gBrowser,
+    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     "http://example.com/",
     true
   );
@@ -48,6 +50,7 @@ add_task(async function test_contextmenu_openlink_after_tabnavigated() {
 
   is(
     newTab.linkedBrowser.currentURI.spec,
+    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     "http://example.com/",
     "Got the expected URL loaded in the new tab"
   );

browser/base/content/test/tabs/browser_e10s_switchbrowser.js

@@ -164,6 +164,7 @@ add_task(async function test_navigation() {
     skipAnimation: true,
   });
   let { permanentKey } = gBrowser.selectedBrowser;
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   await waitForLoad("http://example.org/" + DUMMY_PATH);
   is(
     gBrowser.selectedBrowser.isRemoteBrowser,
@@ -178,6 +179,7 @@ add_task(async function test_navigation() {
 
   info("2");
   // Load another page
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   await waitForLoad("http://example.com/" + DUMMY_PATH);
   is(
     gBrowser.selectedBrowser.isRemoteBrowser,
@@ -212,6 +214,7 @@ add_task(async function test_navigation() {
 
   info("4");
   // Load a remote page
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   await waitForLoad("http://example.org/" + DUMMY_PATH);
   is(
     gBrowser.selectedBrowser.isRemoteBrowser,
@@ -310,6 +313,7 @@ add_task(async function test_navigation() {
   info("10");
   // Load a new remote page, this should replace the last history entry
   gExpectedHistory.entries.splice(gExpectedHistory.entries.length - 1, 1);
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   await waitForLoad("http://example.com/" + DUMMY_PATH);
   is(
     gBrowser.selectedBrowser.isRemoteBrowser,
@@ -339,6 +343,7 @@ add_task(async function test_synchronous() {
     skipAnimation: true,
   });
   let { permanentKey } = gBrowser.selectedBrowser;
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   await waitForLoad("http://example.org/" + DUMMY_PATH);
   is(
     gBrowser.selectedBrowser.isRemoteBrowser,
@@ -372,6 +377,7 @@ add_task(async function test_synchronous() {
   info("Loading http://example.org/" + DUMMY_PATH);
   BrowserTestUtils.loadURIString(
     gBrowser.selectedBrowser,
+    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     "http://example.org/" + DUMMY_PATH
   );
   await BrowserTestUtils.browserStopped(gBrowser);
@@ -416,6 +422,7 @@ add_task(async function test_loadflags() {
   info("2");
   // Load a page in the remote process with some custom flags
   await waitForLoadWithFlags(
+    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     "http://example.com/" + DUMMY_PATH,
     Ci.nsIWebNavigation.LOAD_FLAGS_BYPASS_HISTORY
   );
@@ -443,6 +450,7 @@ add_task(async function test_loadflags() {
   info("4");
   // Load another remote page
   await waitForLoadWithFlags(
+    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     "http://example.org/" + DUMMY_PATH,
     Ci.nsIWebNavigation.LOAD_FLAGS_REPLACE_HISTORY
   );
@@ -456,6 +464,7 @@ add_task(async function test_loadflags() {
   info("5");
   // Load another remote page from a different origin
   await waitForLoadWithFlags(
+    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     "http://example.com/" + DUMMY_PATH,
     Ci.nsIWebNavigation.LOAD_FLAGS_REPLACE_HISTORY
   );

browser/base/content/test/tabs/browser_lazy_tab_browser_events.js

@@ -78,8 +78,11 @@ class TabEventTracker {
 
 add_task(async function test_hidden_muted_lazy_tabs_and_swapping() {
   const params = { createLazyBrowser: true };
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   const URL_HIDDEN = "http://example.com/hide";
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   const URL_MUTED = "http://example.com/mute";
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   const URL_NORMAL = "http://example.com/back";
 
   const lazyTab = BrowserTestUtils.addTab(gBrowser, "", params);

browser/base/content/test/tabs/browser_multiselect_tabs_bookmark.js

@@ -3,6 +3,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 async function addTab_example_com() {
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   const tab = BrowserTestUtils.addTab(gBrowser, "http://example.com/", {
     skipAnimation: true,
   });

browser/base/content/test/tabs/browser_multiselect_tabs_copy_through_drag_and_drop.js

@@ -1,7 +1,10 @@
 add_task(async function test() {
   let tab0 = gBrowser.selectedTab;
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   let tab1 = await addTab("http://example.com/1");
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   let tab2 = await addTab("http://example.com/2");
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   let tab3 = await addTab("http://example.com/3");
   let tabs = [tab0, tab1, tab2, tab3];
 

browser/base/content/test/tabs/browser_multiselect_tabs_duplicate.js

@@ -14,8 +14,11 @@ async function openTabMenuFor(tab) {
 
 add_task(async function test() {
   let originalTab = gBrowser.selectedTab;
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   let tab1 = await addTab("http://example.com/1");
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   let tab2 = await addTab("http://example.com/2");
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   let tab3 = await addTab("http://example.com/3");
 
   let menuItemDuplicateTab = document.getElementById("context_duplicateTab");
@@ -42,6 +45,7 @@ add_task(async function test() {
 
   let newTabOpened = BrowserTestUtils.waitForNewTab(
     gBrowser,
+    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     "http://example.com/3",
     true
   );
@@ -94,7 +98,9 @@ add_task(async function test() {
 
   await TestUtils.waitForCondition(() => {
     return (
+      // eslint-disable-next-line @microsoft/sdl/no-insecure-url
       getUrl(gBrowser.visibleTabs[4]) == "http://example.com/1" &&
+      // eslint-disable-next-line @microsoft/sdl/no-insecure-url
       getUrl(gBrowser.visibleTabs[5]) == "http://example.com/3"
     );
   });

browser/base/content/test/tabs/browser_multiselect_tabs_move_to_new_window_contextmenu.js

@@ -51,6 +51,7 @@ add_task(async function testLazyTabs() {
   let numTabs = 4;
   for (let i = 0; i < numTabs; ++i) {
     oldTabs.push(
+      // eslint-disable-next-line @microsoft/sdl/no-insecure-url
       BrowserTestUtils.addTab(gBrowser, `http://example.com/?${i}`, params)
     );
   }
@@ -107,12 +108,14 @@ add_task(async function testLazyTabs() {
 
   is(
     newTabs[0].linkedBrowser.currentURI.spec,
+    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     `http://example.com/?0`,
     `New tab 0 should have the right URL`
   );
   for (let i = 1; i < numTabs; ++i) {
     is(
       SessionStore.getLazyTabValue(newTabs[i], "url"),
+      // eslint-disable-next-line @microsoft/sdl/no-insecure-url
       `http://example.com/?${i}`,
       `New tab ${i} should have the right lazy URL`
     );

browser/base/content/test/tabs/browser_multiselect_tabs_open_related.js

@@ -1,6 +1,9 @@
 add_task(async function test() {
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   let tab1 = await addTab("http://example.com/1");
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   let tab2 = await addTab("http://example.com/2");
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   let tab3 = await addTab("http://example.com/3");
 
   await BrowserTestUtils.switchTab(gBrowser, tab1);

browser/base/content/test/tabs/browser_navigatePinnedTab.js

@@ -37,18 +37,22 @@ add_task(async function() {
   let pageLoadPromise = BrowserTestUtils.browserLoaded(
     appTab.linkedBrowser,
     false,
+    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     "http://example.com/"
   );
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   BrowserTestUtils.loadURIString(appTab.linkedBrowser, "http://example.com/");
   info("Started loading example.com");
   await pageLoadPromise;
   info("Loaded example.com");
   let newTabPromise = BrowserTestUtils.waitForNewTab(
     gBrowser,
+    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     "http://example.org/"
   );
   await SpecialPowers.spawn(browser, [], async function() {
     let link = content.document.createElement("a");
+    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     link.href = "http://example.org/";
     content.document.body.appendChild(link);
     link.click();

browser/base/content/test/tabs/browser_new_file_whitelisted_http_tab.js

@@ -1,6 +1,7 @@
 /* -*- indent-tabs-mode: nil; js-indent-level: 2 -*- */
 /* vim: set ft=javascript ts=2 et sw=2 tw=80: */
 
+// eslint-disable-next-line @microsoft/sdl/no-insecure-url
 const TEST_HTTP = "http://example.org/";
 
 // Test for bug 1378377.

browser/base/content/test/tabs/browser_new_tab_in_privilegedabout_process_pref.js

@@ -15,6 +15,7 @@ const ABOUT_BLANK = "about:blank";
 const ABOUT_HOME = "about:home";
 const ABOUT_NEWTAB = "about:newtab";
 const ABOUT_WELCOME = "about:welcome";
+// eslint-disable-next-line @microsoft/sdl/no-insecure-url
 const TEST_HTTP = "http://example.org/";
 
 add_setup(async function() {

browser/base/content/test/tabs/browser_new_tab_insert_position.js

@@ -83,6 +83,7 @@ const sessData = {
     },
   ],
 };
+// eslint-disable-next-line @microsoft/sdl/no-insecure-url
 const urlbarURL = "http://example.com/#urlbar";
 
 async function doTest(aInsertRelatedAfterCurrent, aInsertAfterCurrent) {
@@ -109,6 +110,7 @@ async function doTest(aInsertRelatedAfterCurrent, aInsertAfterCurrent) {
   // Create a *opener* tab page which has a link to "example.com".
   let pageURL = getRootDirectory(gTestPath).replace(
     "chrome://mochitests/content",
+    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     "http://example.com"
   );
   pageURL = `${pageURL}file_new_tab_page.html`;
@@ -131,6 +133,7 @@ async function doTest(aInsertRelatedAfterCurrent, aInsertAfterCurrent) {
 
   let newTabPromise = BrowserTestUtils.waitForNewTab(
     gBrowser,
+    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     "http://example.com/#linkclick",
     true
   );
@@ -142,6 +145,7 @@ async function doTest(aInsertRelatedAfterCurrent, aInsertAfterCurrent) {
   let openTab = await newTabPromise;
   is(
     openTab.linkedBrowser.currentURI.spec,
+    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     "http://example.com/#linkclick",
     "Middle click should open site to correct url."
   );

browser/base/content/test/tabs/browser_opened_file_tab_navigated_to_web.js

@@ -2,6 +2,7 @@
 /* vim: set ft=javascript ts=2 et sw=2 tw=80: */
 
 const TEST_FILE = "dummy_page.html";
+// eslint-disable-next-line @microsoft/sdl/no-insecure-url
 const WEB_ADDRESS = "http://example.org/";
 
 // Test for bug 1321020.
@@ -40,6 +41,7 @@ add_task(async function() {
   let openedBrowser = openedTab.linkedBrowser;
 
   // Ensure that new file:// tab can be navigated to web content.
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   BrowserTestUtils.loadURIString(openedBrowser, "http://example.org/");
   let href = await BrowserTestUtils.browserLoaded(
     openedBrowser,

browser/base/content/test/tabs/browser_privilegedmozilla_process_pref.js

@@ -14,6 +14,7 @@
 // High and Low Privilege
 const TEST_HIGH1 = "https://example.org/";
 const TEST_HIGH2 = "https://test1.example.org/";
+// eslint-disable-next-line @microsoft/sdl/no-insecure-url
 const TEST_LOW1 = "http://example.org/";
 const TEST_LOW2 = "https://example.com/";
 

browser/base/content/test/tabs/browser_progress_keyword_search_handling.js

@@ -72,6 +72,7 @@ add_task(async function test_unknown_host_without_search() {
     let searchPromise = BrowserTestUtils.browserLoaded(
       browser,
       false,
+      // eslint-disable-next-line @microsoft/sdl/no-insecure-url
       "http://" + kNonExistingHost + "/",
       true /* want an error page */
     );

browser/base/content/test/tabs/browser_replacewithwindow_commands.js

@@ -7,10 +7,12 @@
 add_task(async function() {
   let tab1 = await BrowserTestUtils.openNewForegroundTab(
     gBrowser,
+    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     "http://www.example.com"
   );
   let tab2 = await BrowserTestUtils.openNewForegroundTab(
     gBrowser,
+    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     "http://www.example.com"
   );
 

browser/base/content/test/tabs/browser_undo_close_tabs.js

@@ -95,6 +95,7 @@ add_task(async function withBothGroupsAndTab() {
     "SessionStore should know how many tabs were just closed"
   );
 
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   let tab4 = await addTab("http://example.com/4");
 
   is(

browser/base/content/test/webrtc/browser_devices_get_user_media.js

@@ -902,6 +902,7 @@ var gTests = [
       let browser = gBrowser.selectedBrowser;
       BrowserTestUtils.loadURIString(
         browser,
+        // eslint-disable-next-line @microsoft/sdl/no-insecure-url
         browser.documentURI.spec.replace("https://", "http://")
       );
       await BrowserTestUtils.browserLoaded(browser);

browser/base/content/test/zoom/browser_background_link_zoom_reset.js

@@ -39,6 +39,7 @@ function test() {
   (async function() {
     gTestTab = BrowserTestUtils.addTab(gBrowser);
     await FullZoomHelper.selectTabAndWaitForLocationChange(gTestTab);
+    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     await FullZoomHelper.load(gTestTab, "http://example.org" + TEST_PAGE);
   })().then(testInitialZoom, FullZoomHelper.failAndContinue(finish));
 }

browser/base/content/test/zoom/browser_background_zoom.js

@@ -1,6 +1,8 @@
 var gTestPage =
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   "http://example.org/browser/browser/base/content/test/zoom/zoom_test.html";
 var gTestImage =
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   "http://example.org/browser/browser/base/content/test/general/moz.png";
 var gTab1, gTab2, gTab3;
 var gLevel;

browser/base/content/test/zoom/browser_default_zoom_multitab.js

@@ -4,7 +4,9 @@
 "use strict";
 
 add_task(async function test_multidomain_global_zoom() {
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   const TEST_PAGE_URL_1 = "http://example.com/";
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   const TEST_PAGE_URL_2 = "http://example.org/";
 
   // Prepare the test tabs
@@ -93,7 +95,9 @@ add_task(async function test_multidomain_global_zoom() {
 });
 
 add_task(async function test_site_specific_global_zoom() {
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   const TEST_PAGE_URL_1 = "http://example.net/";
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   const TEST_PAGE_URL_2 = "http://example.net/";
 
   // Prepare the test tabs

browser/base/content/test/zoom/browser_default_zoom_multitab_002.js

@@ -4,7 +4,9 @@
 "use strict";
 
 add_task(async function test_site_specific_global_zoom() {
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   const TEST_PAGE_URL_1 = "http://example.net";
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   const TEST_PAGE_URL_2 = "http://example.net";
 
   // Prepare the test tabs

browser/base/content/test/zoom/browser_image_zoom_tabswitch.js

@@ -6,6 +6,7 @@
 function test() {
   let tab1, tab2;
   const TEST_IMAGE =
+    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     "http://example.org/browser/browser/base/content/test/general/moz.png";
 
   waitForExplicitFinish();

browser/base/content/test/zoom/browser_mousewheel_zoom.js

@@ -4,6 +4,7 @@
 "use strict";
 
 const TEST_PAGE =
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   "http://example.org/browser/browser/base/content/test/zoom/zoom_test.html";
 
 var gTab1, gTab2, gLevel1;

browser/base/content/test/zoom/browser_sitespecific_background_pref.js

@@ -3,6 +3,7 @@ function test() {
 
   (async function() {
     let testPage =
+      // eslint-disable-next-line @microsoft/sdl/no-insecure-url
       "http://example.org/browser/browser/base/content/test/zoom/zoom_test.html";
     let tab1 = BrowserTestUtils.addTab(gBrowser);
     await FullZoomHelper.selectTabAndWaitForLocationChange(tab1);

browser/base/content/test/zoom/browser_sitespecific_video_zoom.js

@@ -4,8 +4,10 @@
 "use strict";
 
 const TEST_PAGE =
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   "http://example.org/browser/browser/base/content/test/zoom/zoom_test.html";
 const TEST_VIDEO =
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   "http://example.org/browser/browser/base/content/test/general/video.ogg";
 
 var gTab1, gTab2, gLevel1;

browser/base/content/test/zoom/browser_subframe_textzoom.js

@@ -11,6 +11,7 @@ function test() {
   waitForExplicitFinish();
 
   const TEST_PAGE_URL = 'data:text/html,<body><iframe src=""></iframe></body>';
+  // eslint-disable-next-line @microsoft/sdl/no-insecure-url
   const TEST_IFRAME_URL = "http://test2.example.org/";
 
   (async function() {

browser/base/content/test/zoom/browser_tabswitch_zoom_flicker.js

@@ -10,6 +10,7 @@ function test() {
   Services.prefs.setBoolPref("browser.zoom.siteSpecific", true);
 
   let uri =
+    // eslint-disable-next-line @microsoft/sdl/no-insecure-url
     "http://example.org/browser/browser/base/content/test/zoom/zoom_test.html";
 
   (async function() {