nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1628415 part 3: Remove XULListboxAccessible::Value. r=MarcoZ

Browse source 
This depends on richlistitem's nsIDOMXULSelectControlItemElement::label implementation, which does the wrong thing in several cases.
We could make this use a11y name computation, but I can't find any other list box implementation that exposes accessible value on the list box itself, so I don't see any reason to keep this.

Differential Revision: https://phabricator.services.mozilla.com/D74372
This commit is contained in:
James Teh 2020-05-08 04:28:11 +00:00
parent b02d77311a
commit 9f69f88101
2 changed files with 0 additions and 22 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

21
accessible/xul/XULListboxAccessible.cpp
View file

@ -97,27 +97,6 @@ uint64_t XULListboxAccessible::NativeState() const {
return states;
}
/**
* Our value is the label of our ( first ) selected child.
*/
void XULListboxAccessible::Value(nsString& aValue) const {
aValue.Truncate();
nsCOMPtr<nsIDOMXULSelectControlElement> select = Elm()->AsXULSelectControl();
if (select) {
RefPtr<dom::Element> element;
select->GetSelectedItem(getter_AddRefs(element));
if (element) {
nsCOMPtr<nsIDOMXULSelectControlItemElement> selectedItem =
element->AsXULSelectControlItem();
if (selectedItem) {
selectedItem->GetLabel(aValue);
}
}
}
}
role XULListboxAccessible::NativeRole() const {
// A richlistbox is used with the new autocomplete URL bar, and has a parent
// popup <panel>.

1
accessible/xul/XULListboxAccessible.h
View file

@ -76,7 +76,6 @@ class XULListboxAccessible : public XULSelectControlAccessible,
virtual Accessible* AsAccessible() override { return this; }
// Accessible
virtual void Value(nsString& aValue) const override;
virtual TableAccessible* AsTable() override { return this; }
virtual a11y::role NativeRole() const override;
virtual uint64_t NativeState() const override;