nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1888892 - Trace all fields in TraceWeakCacheIRStub. r=jonco

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D206481
This commit is contained in:
Jan de Mooij 2024-04-04 13:31:40 +00:00
parent 35f71d4d43
commit a334c67b34
1 changed files with 8 additions and 5 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

13
js/src/jit/CacheIRCompiler.cpp
View file

@ -1364,6 +1364,8 @@ bool jit::TraceWeakCacheIRStub(JSTracer* trc, T* stub,
const CacheIRStubInfo* stubInfo) {
using Type = StubField::Type;
bool isDead = false;
uint32_t field = 0;
size_t offset = 0;
while (true) {
@ -1374,7 +1376,7 @@ bool jit::TraceWeakCacheIRStub(JSTracer* trc, T* stub,
stubInfo->getStubField<T, Type::WeakShape>(stub, offset);
auto r = TraceWeakEdge(trc, &shapeField, "cacheir-weak-shape");
if (r.isDead()) {
return false;
isDead = true;
}
break;
}
@ -1383,7 +1385,7 @@ bool jit::TraceWeakCacheIRStub(JSTracer* trc, T* stub,
stubInfo->getStubField<T, Type::WeakObject>(stub, offset);
auto r = TraceWeakEdge(trc, &objectField, "cacheir-weak-object");
if (r.isDead()) {
return false;
isDead = true;
}
break;
}
@ -1392,7 +1394,7 @@ bool jit::TraceWeakCacheIRStub(JSTracer* trc, T* stub,
stubInfo->getStubField<T, Type::WeakBaseScript>(stub, offset);
auto r = TraceWeakEdge(trc, &scriptField, "cacheir-weak-script");
if (r.isDead()) {
return false;
isDead = true;
}
break;
}
@ -1402,12 +1404,13 @@ bool jit::TraceWeakCacheIRStub(JSTracer* trc, T* stub,
auto r = TraceWeakEdge(trc, &getterSetterField,
"cacheir-weak-getter-setter");
if (r.isDead()) {
return false;
isDead = true;
}
break;
}
case Type::Limit:
return true; // Done.
// Done.
return !isDead;
case Type::RawInt32:
case Type::RawPointer:
case Type::Shape: