nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1790067 - Removed the warning about non-cell relative parts of table. r=emilio

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D157583
This commit is contained in:
Aleksandr Shoronov 2022-09-17 14:37:32 +00:00
parent 7208aa15cb
commit a4b7225fb8
4 changed files with 0 additions and 27 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

1
dom/locales/en-US/chrome/layout/layout_errors.properties
View file

@ -8,7 +8,6 @@ ImageMapCircleNegativeRadius=The “coords” attribute of the <area shape="circ
ImageMapPolyWrongNumberOfCoords=The “coords” attribute of the <area shape="poly"> tag is not in the “x1,y1,x2,y2 …” format. ImageMapPolyWrongNumberOfCoords=The “coords” attribute of the <area shape="poly"> tag is not in the “x1,y1,x2,y2 …” format.
ImageMapPolyOddNumberOfCoords=The “coords” attribute of the <area shape="poly"> tag is missing the last “y” coordinate (the correct format is “x1,y1,x2,y2 …”). ImageMapPolyOddNumberOfCoords=The “coords” attribute of the <area shape="poly"> tag is missing the last “y” coordinate (the correct format is “x1,y1,x2,y2 …”).
TablePartRelPosWarning=Relative positioning of table rows and row groups is now supported. This site may need to be updated because it may depend on this feature having no effect.
ScrollLinkedEffectFound3=This site appears to use a scroll-linked positioning effect. This may not work well with asynchronous panning; see https://firefox-source-docs.mozilla.org/performance/scroll-linked_effects.html for further details and to join the discussion on related tools and features! ScrollLinkedEffectFound3=This site appears to use a scroll-linked positioning effect. This may not work well with asynchronous panning; see https://firefox-source-docs.mozilla.org/performance/scroll-linked_effects.html for further details and to join the discussion on related tools and features!
## LOCALIZATION NOTE(CompositorAnimationWarningContentTooLargeArea): ## LOCALIZATION NOTE(CompositorAnimationWarningContentTooLargeArea):

1
layout/base/nsPresContext.cpp
View file

@ -279,7 +279,6 @@ nsPresContext::nsPresContext(dom::Document* aDocument, nsPresContextType aType)
mCounterStylesDirty(true), mCounterStylesDirty(true),
mFontFeatureValuesDirty(true), mFontFeatureValuesDirty(true),
mIsVisual(false), mIsVisual(false),
mHasWarnedAboutPositionedTableParts(false),
mHasWarnedAboutTooLargeDashedOrDottedRadius(false), mHasWarnedAboutTooLargeDashedOrDottedRadius(false),
mQuirkSheetAdded(false), mQuirkSheetAdded(false),
mHadNonBlankPaint(false), mHadNonBlankPaint(false),

10
layout/base/nsPresContext.h
View file

@ -1068,14 +1068,6 @@ class nsPresContext : public nsISupports, public mozilla::SupportsWeakPtr {
bool IsDeviceSizePageSize(); bool IsDeviceSizePageSize();
bool HasWarnedAboutPositionedTableParts() const {
return mHasWarnedAboutPositionedTableParts;
}
void SetHasWarnedAboutPositionedTableParts() {
mHasWarnedAboutPositionedTableParts = true;
}
bool HasWarnedAboutTooLargeDashedOrDottedRadius() const { bool HasWarnedAboutTooLargeDashedOrDottedRadius() const {
return mHasWarnedAboutTooLargeDashedOrDottedRadius; return mHasWarnedAboutTooLargeDashedOrDottedRadius;
} }
@ -1364,8 +1356,6 @@ class nsPresContext : public nsISupports, public mozilla::SupportsWeakPtr {
unsigned mIsVisual : 1; unsigned mIsVisual : 1;
unsigned mHasWarnedAboutPositionedTableParts : 1;
unsigned mHasWarnedAboutTooLargeDashedOrDottedRadius : 1; unsigned mHasWarnedAboutTooLargeDashedOrDottedRadius : 1;
// Have we added quirk.css to the style set? // Have we added quirk.css to the style set?

15
layout/tables/nsTableFrame.cpp
View file

@ -250,21 +250,6 @@ bool nsTableFrame::PageBreakAfter(nsIFrame* aSourceFrame,
/* static */ /* static */
void nsTableFrame::RegisterPositionedTablePart(nsIFrame* aFrame) { void nsTableFrame::RegisterPositionedTablePart(nsIFrame* aFrame) {
// Supporting relative positioning for table parts other than table cells has
// the potential to break sites that apply 'position: relative' to those
// parts, expecting nothing to happen. We warn at the console to make tracking
// down the issue easy.
if (!aFrame->IsTableCellFrame()) {
nsIContent* content = aFrame->GetContent();
nsPresContext* presContext = aFrame->PresContext();
if (content && !presContext->HasWarnedAboutPositionedTableParts()) {
presContext->SetHasWarnedAboutPositionedTableParts();
nsContentUtils::ReportToConsole(
nsIScriptError::warningFlag, "Layout: Tables"_ns, content->OwnerDoc(),
nsContentUtils::eLAYOUT_PROPERTIES, "TablePartRelPosWarning");
}
}
nsTableFrame* tableFrame = nsTableFrame::GetTableFrame(aFrame); nsTableFrame* tableFrame = nsTableFrame::GetTableFrame(aFrame);
MOZ_ASSERT(tableFrame, "Should have a table frame here"); MOZ_ASSERT(tableFrame, "Should have a table frame here");
tableFrame = static_cast<nsTableFrame*>(tableFrame->FirstContinuation()); tableFrame = static_cast<nsTableFrame*>(tableFrame->FirstContinuation());