nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1831072 - Part 1: Remove counts of realms where string or big int nursery allocation was disabled r=jandem

Browse source 
This data is sent to the profiler but is not used (the key names are not
present in the Firefox profiler repository).

Differential Revision: https://phabricator.services.mozilla.com/D177035
This commit is contained in:
Jon Coppeard 2023-05-04 09:34:40 +00:00
parent a4732f3562
commit a5549365c1
2 changed files with 0 additions and 29 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

21
js/src/gc/Nursery.cpp
View file

@ -862,17 +862,6 @@ void js::Nursery::renderProfileJSON(JSONPrinter& json) const {
stats().allocsSinceMinorGCTenured()); stats().allocsSinceMinorGCTenured());
} }
if (stats().getStat(gcstats::STAT_NURSERY_STRING_REALMS_DISABLED)) {
json.property(
"nursery_string_realms_disabled",
stats().getStat(gcstats::STAT_NURSERY_STRING_REALMS_DISABLED));
}
if (stats().getStat(gcstats::STAT_NURSERY_BIGINT_REALMS_DISABLED)) {
json.property(
"nursery_bigint_realms_disabled",
stats().getStat(gcstats::STAT_NURSERY_BIGINT_REALMS_DISABLED));
}
json.beginObjectProperty("phase_times"); json.beginObjectProperty("phase_times");
#define EXTRACT_NAME(name, text) #name, #define EXTRACT_NAME(name, text) #name,
@ -1555,9 +1544,7 @@ size_t js::Nursery::doPretenuring(JSRuntime* rt, JS::GCReason reason,
mozilla::Maybe<AutoGCSession> session; mozilla::Maybe<AutoGCSession> session;
uint32_t numStringsTenured = 0; uint32_t numStringsTenured = 0;
uint32_t numNurseryStringRealmsDisabled = 0;
uint32_t numBigIntsTenured = 0; uint32_t numBigIntsTenured = 0;
uint32_t numNurseryBigIntRealmsDisabled = 0;
for (ZonesIter zone(gc, SkipAtoms); !zone.done(); zone.next()) { for (ZonesIter zone(gc, SkipAtoms); !zone.done(); zone.next()) {
// For some tests in JetStream2 and Kraken, the tenuredRate is high but the // For some tests in JetStream2 and Kraken, the tenuredRate is high but the
// number of allocated strings is low. So we calculate the tenuredRate only // number of allocated strings is low. So we calculate the tenuredRate only
@ -1590,10 +1577,6 @@ size_t js::Nursery::doPretenuring(JSRuntime* rt, JS::GCReason reason,
jitRealm->discardStubs(); jitRealm->discardStubs();
if (disableNurseryStrings) { if (disableNurseryStrings) {
jitRealm->setStringsCanBeInNursery(false); jitRealm->setStringsCanBeInNursery(false);
numNurseryStringRealmsDisabled++;
}
if (disableNurseryBigInts) {
numNurseryBigIntRealmsDisabled++;
} }
} }
} }
@ -1610,11 +1593,7 @@ size_t js::Nursery::doPretenuring(JSRuntime* rt, JS::GCReason reason,
zone->tenuredBigInts = 0; zone->tenuredBigInts = 0;
} }
session.reset(); // End the minor GC session, if running one. session.reset(); // End the minor GC session, if running one.
stats().setStat(gcstats::STAT_NURSERY_STRING_REALMS_DISABLED,
numNurseryStringRealmsDisabled);
stats().setStat(gcstats::STAT_STRINGS_TENURED, numStringsTenured); stats().setStat(gcstats::STAT_STRINGS_TENURED, numStringsTenured);
stats().setStat(gcstats::STAT_NURSERY_BIGINT_REALMS_DISABLED,
numNurseryBigIntRealmsDisabled);
stats().setStat(gcstats::STAT_BIGINTS_TENURED, numBigIntsTenured); stats().setStat(gcstats::STAT_BIGINTS_TENURED, numBigIntsTenured);
return sitesPretenured; return sitesPretenured;

8
js/src/gc/Statistics.h
View file

@ -67,17 +67,9 @@ enum Stat {
// Number of strings deduplicated. // Number of strings deduplicated.
STAT_STRINGS_DEDUPLICATED, STAT_STRINGS_DEDUPLICATED,
// Number of realms that had nursery strings disabled due to large numbers
// being tenured.
STAT_NURSERY_STRING_REALMS_DISABLED,
// Number of BigInts tenured. // Number of BigInts tenured.
STAT_BIGINTS_TENURED, STAT_BIGINTS_TENURED,
// Number of realms that had nursery BigInts disabled due to large numbers
// being tenured.
STAT_NURSERY_BIGINT_REALMS_DISABLED,
STAT_LIMIT STAT_LIMIT
}; };