nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1751361 - [marionette] Replace assertions for Firefox with Desktop. r=webdriver-reviewers,jdescottes

Browse source 
WebDriver commands that currently assert for Firefox should
actually check for desktop because Thunderbird also supports
all of these.

Differential Revision: https://phabricator.services.mozilla.com/D136574
This commit is contained in:
Henrik Skupin 2022-01-21 16:03:23 +00:00
parent d3c1ec720d
commit a5b7336880
1 changed files with 6 additions and 6 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

12
remote/marionette/driver.js
View file

@ -1063,7 +1063,7 @@ GeckoDriver.prototype.getWindowRect = async function() {
* Not applicable to application. * Not applicable to application.
*/ */
GeckoDriver.prototype.setWindowRect = async function(cmd) { GeckoDriver.prototype.setWindowRect = async function(cmd) {
assert.firefox(); assert.desktop();
assert.open(this.getBrowsingContext({ top: true })); assert.open(this.getBrowsingContext({ top: true }));
await this._handleUserPrompts(); await this._handleUserPrompts();
@ -2078,7 +2078,7 @@ GeckoDriver.prototype.close = async function() {
* Top-level browsing context has been discarded. * Top-level browsing context has been discarded.
*/ */
GeckoDriver.prototype.closeChromeWindow = async function() { GeckoDriver.prototype.closeChromeWindow = async function() {
assert.firefox(); assert.desktop();
assert.open(this.getBrowsingContext({ context: Context.Chrome, top: true })); assert.open(this.getBrowsingContext({ context: Context.Chrome, top: true }));
let nwins = 0; let nwins = 0;
@ -2270,7 +2270,7 @@ GeckoDriver.prototype.setScreenOrientation = function(cmd) {
* Not available for current application. * Not available for current application.
*/ */
GeckoDriver.prototype.minimizeWindow = async function() { GeckoDriver.prototype.minimizeWindow = async function() {
assert.firefox(); assert.desktop();
assert.open(this.getBrowsingContext({ top: true })); assert.open(this.getBrowsingContext({ top: true }));
await this._handleUserPrompts(); await this._handleUserPrompts();
@ -2323,7 +2323,7 @@ GeckoDriver.prototype.minimizeWindow = async function() {
* Not available for current application. * Not available for current application.
*/ */
GeckoDriver.prototype.maximizeWindow = async function() { GeckoDriver.prototype.maximizeWindow = async function() {
assert.firefox(); assert.desktop();
assert.open(this.getBrowsingContext({ top: true })); assert.open(this.getBrowsingContext({ top: true }));
await this._handleUserPrompts(); await this._handleUserPrompts();
@ -2375,7 +2375,7 @@ GeckoDriver.prototype.maximizeWindow = async function() {
* Not available for current application. * Not available for current application.
*/ */
GeckoDriver.prototype.fullscreenWindow = async function() { GeckoDriver.prototype.fullscreenWindow = async function() {
assert.firefox(); assert.desktop();
assert.open(this.getBrowsingContext({ top: true })); assert.open(this.getBrowsingContext({ top: true }));
await this._handleUserPrompts(); await this._handleUserPrompts();
@ -2692,7 +2692,7 @@ GeckoDriver.prototype.installAddon = function(cmd) {
}; };
GeckoDriver.prototype.uninstallAddon = function(cmd) { GeckoDriver.prototype.uninstallAddon = function(cmd) {
assert.firefox(); assert.desktop();
let id = cmd.parameters.id; let id = cmd.parameters.id;
if (typeof id == "undefined" || typeof id != "string") { if (typeof id == "undefined" || typeof id != "string") {