nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1869722 Part 1 - Cleanup after fixing tables as flex items. r=dholbert

Browse source 
Flex containers do not need the `alignCB` tweak for table frames in
`ReflowInput::InitConstraints`, so I remove the comment, and improve it so that
we don't need to call `alignCB->GetParent()` multiple times.

This patch doesn't change behavior.

Differential Revision: https://phabricator.services.mozilla.com/D196257
This commit is contained in:
Ting-Yu Lin 2023-12-13 22:50:36 +00:00
parent d9b0660e84
commit a7df850035
4 changed files with 6 additions and 8 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

9
layout/generic/ReflowInput.cpp
View file

@ -2365,11 +2365,10 @@ void ReflowInput::InitConstraints(
}
nsIFrame* alignCB = mFrame->GetParent();
if (alignCB->IsTableWrapperFrame() && alignCB->GetParent()) {
// XXX grid-specific for now; maybe remove this check after we address
// bug 799725
if (alignCB->GetParent()->IsGridContainerFrame()) {
alignCB = alignCB->GetParent();
if (alignCB->IsTableWrapperFrame()) {
nsIFrame* alignCBParent = alignCB->GetParent();
if (alignCBParent && alignCBParent->IsGridContainerFrame()) {
alignCB = alignCBParent;
}
}
if (alignCB->IsGridContainerFrame()) {

2
layout/reftests/flexbox/flexbox-table-flex-items-1-ref.html
View file

@ -14,7 +14,7 @@
border: 3px solid grey;
height: 73px;
width: 110px;
align-items: start; /* no support for stretch yet: bug 799725 */
align-items: start;
}
table {

2
layout/reftests/flexbox/flexbox-table-flex-items-1.html
View file

@ -16,7 +16,7 @@
border: 3px solid grey;
height: 73px;
width: 110px;
align-items: start; /* no support for stretch yet: bug 799725 */
align-items: start;
}
table {

1
testing/web-platform/tests/css/css-flexbox/flexbox-align-self-horiz-001-table.xhtml
View file

@ -59,7 +59,6 @@
.stretch {
background: pink;
align-self: stretch;
display: block; /* XXXdholbert Hackaround for bug 799725 */
}
.auto {
background: yellow;