nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Backed out 2 changesets (bug 1869092) for causing osx shippable bc failures on browser_sentence_case_strings.js. CLOSED TREE

Browse source 
Backed out changeset 73cc7a634df0 (bug 1869092)
Backed out changeset d3a2a2b120e4 (bug 1869092)
This commit is contained in:
Cosmin Sabou 2023-12-13 02:35:02 +02:00
parent 0d957379ac
commit aa2c9160f7
3 changed files with 0 additions and 28 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

6
browser/components/customizableui/PanelMultiView.sys.mjs
View file

@ -784,12 +784,6 @@ export var PanelMultiView = class extends AssociatedToNode {
let prevPanelView = this.openViews[this.openViews.length - 1];
let nextPanelView = this.openViews[this.openViews.length - 2];
// See bug 1869092. panelviews like the confirmation of Report Broken Site
// have no back buttons, and so should not allow going back.
if (!prevPanelView.node.querySelector(".subviewbutton-back")) {
return;
}
// Like in the showSubView method, do not re-enter navigation while it is
// in progress, and make the view inactive immediately. From this point
// onwards, "await" statements can be used safely.

1
browser/components/customizableui/test/browser_PanelMultiView.js
View file

@ -222,7 +222,6 @@ add_task(async function test_setup() {
gPanelViewLabels[i] = document.createXULElement("label");
gPanelViewLabels[i].setAttribute("value", "PanelView " + i);
gPanelViewLabels[i].classList.add("subviewbutton-back"); // so we can goBack (see bug 1869092)
gPanelViews[i].appendChild(gPanelViewLabels[i]);
}

21
browser/components/reportbrokensite/test/browser/browser_keyboard_navigation.js
View file

@ -9,8 +9,6 @@
add_common_setup();
requestLongerTimeout(2);
function pressKeyAndAwait(event, key, config = {}) {
const win = config.window || window;
if (!event.then) {
@ -254,22 +252,3 @@ add_task(async function testBackButtons() {
}
);
});
add_task(async function testLeftArrowDoesNotGoBackOnSentView() {
ensureReportBrokenSitePreffedOn();
await BrowserTestUtils.withNewTab(
REPORTABLE_PAGE_URL,
async function (browser) {
const rbs = await AppMenu().openReportBrokenSite();
await rbs.clickSend();
EventUtils.synthesizeKey("KEY_ArrowLeft", {}, window);
const focus = await pressKeyAndGetFocus("VK_TAB");
is(
focus.id,
"report-broken-site-popup-okay-button",
"Report sent view is still open"
);
rbs.close();
}
);
});