diff --git a/devtools/client/shared/components/reps/reps/grip-entry.js b/devtools/client/shared/components/reps/reps/grip-entry.js index 37802f4342ed..8b8137eb7ae7 100644 --- a/devtools/client/shared/components/reps/reps/grip-entry.js +++ b/devtools/client/shared/components/reps/reps/grip-entry.js @@ -69,20 +69,9 @@ define(function(require, exports, module) { ); } - function createGripMapEntry(key, value) { - return { - type: "mapEntry", - preview: { - key, - value, - }, - }; - } - // Exports from this module module.exports = { rep: wrapRender(GripEntry), - createGripMapEntry, supportsObject, }; }); diff --git a/devtools/client/shared/components/test/node/components/object-inspector/utils/should-load-item-indexed-properties.test.js b/devtools/client/shared/components/test/node/components/object-inspector/utils/should-load-item-indexed-properties.test.js index feaac9752e8e..0a0e7d069bcf 100644 --- a/devtools/client/shared/components/test/node/components/object-inspector/utils/should-load-item-indexed-properties.test.js +++ b/devtools/client/shared/components/test/node/components/object-inspector/utils/should-load-item-indexed-properties.test.js @@ -14,7 +14,9 @@ const { const { shouldLoadItemIndexedProperties } = Utils.loadProperties; -const GripEntryRep = require("devtools/client/shared/components/reps/reps/grip-entry"); +const { + createGripMapEntry, +} = require("devtools/client/shared/components/test/node/components/reps/test-helpers"); const accessorStubs = require("devtools/client/shared/components/test/node/stubs/reps/accessor"); const gripMapStubs = require("devtools/client/shared/components/test/node/stubs/reps/grip-map"); const gripArrayStubs = require("devtools/client/shared/components/test/node/stubs/reps/grip-array"); @@ -189,7 +191,7 @@ describe("shouldLoadItemIndexedProperties", () => { }); it("returns false for a MapEntry node", () => { - const node = GripEntryRep.createGripMapEntry("key", "value"); + const node = createGripMapEntry("key", "value"); expect(shouldLoadItemIndexedProperties(node)).toBeFalsy(); }); diff --git a/devtools/client/shared/components/test/node/components/object-inspector/utils/should-load-item-non-indexed-properties.test.js b/devtools/client/shared/components/test/node/components/object-inspector/utils/should-load-item-non-indexed-properties.test.js index a52a4942ddea..228c99f1633f 100644 --- a/devtools/client/shared/components/test/node/components/object-inspector/utils/should-load-item-non-indexed-properties.test.js +++ b/devtools/client/shared/components/test/node/components/object-inspector/utils/should-load-item-non-indexed-properties.test.js @@ -14,7 +14,9 @@ const { const { shouldLoadItemNonIndexedProperties } = Utils.loadProperties; -const GripEntryRep = require("devtools/client/shared/components/reps/reps/grip-entry"); +const { + createGripMapEntry, +} = require("devtools/client/shared/components/test/node/components/reps/test-helpers"); const accessorStubs = require("devtools/client/shared/components/test/node/stubs/reps/accessor"); const gripMapStubs = require("devtools/client/shared/components/test/node/stubs/reps/grip-map"); const gripArrayStubs = require("devtools/client/shared/components/test/node/stubs/reps/grip-array"); @@ -152,7 +154,7 @@ describe("shouldLoadItemNonIndexedProperties", () => { }); it("returns false for a MapEntry node", () => { - const node = GripEntryRep.createGripMapEntry("key", "value"); + const node = createGripMapEntry("key", "value"); expect(shouldLoadItemNonIndexedProperties(node)).toBeFalsy(); }); diff --git a/devtools/client/shared/components/test/node/components/object-inspector/utils/should-load-item-prototype.test.js b/devtools/client/shared/components/test/node/components/object-inspector/utils/should-load-item-prototype.test.js index c0a9f9da981f..565d6cf62961 100644 --- a/devtools/client/shared/components/test/node/components/object-inspector/utils/should-load-item-prototype.test.js +++ b/devtools/client/shared/components/test/node/components/object-inspector/utils/should-load-item-prototype.test.js @@ -14,7 +14,9 @@ const { const { shouldLoadItemPrototype } = Utils.loadProperties; -const GripEntryRep = require("devtools/client/shared/components/reps/reps/grip-entry"); +const { + createGripMapEntry, +} = require("devtools/client/shared/components/test/node/components/reps/test-helpers"); const accessorStubs = require("devtools/client/shared/components/test/node/stubs/reps/accessor"); const gripMapStubs = require("devtools/client/shared/components/test/node/stubs/reps/grip-map"); const gripArrayStubs = require("devtools/client/shared/components/test/node/stubs/reps/grip-array"); @@ -148,7 +150,7 @@ describe("shouldLoadItemPrototype", () => { }); it("returns false for a MapEntry node", () => { - const node = GripEntryRep.createGripMapEntry("key", "value"); + const node = createGripMapEntry("key", "value"); expect(shouldLoadItemPrototype(node)).toBeFalsy(); }); diff --git a/devtools/client/shared/components/test/node/components/object-inspector/utils/should-load-item-symbols.test.js b/devtools/client/shared/components/test/node/components/object-inspector/utils/should-load-item-symbols.test.js index e75274389217..e7af56ad0dd5 100644 --- a/devtools/client/shared/components/test/node/components/object-inspector/utils/should-load-item-symbols.test.js +++ b/devtools/client/shared/components/test/node/components/object-inspector/utils/should-load-item-symbols.test.js @@ -14,7 +14,9 @@ const { const { shouldLoadItemSymbols } = Utils.loadProperties; -const GripEntryRep = require("devtools/client/shared/components/reps/reps/grip-entry"); +const { + createGripMapEntry, +} = require("devtools/client/shared/components/test/node/components/reps/test-helpers"); const accessorStubs = require("devtools/client/shared/components/test/node/stubs/reps/accessor"); const gripMapStubs = require("devtools/client/shared/components/test/node/stubs/reps/grip-map"); const gripArrayStubs = require("devtools/client/shared/components/test/node/stubs/reps/grip-array"); @@ -148,7 +150,7 @@ describe("shouldLoadItemSymbols", () => { }); it("returns false for a MapEntry node", () => { - const node = GripEntryRep.createGripMapEntry("key", "value"); + const node = createGripMapEntry("key", "value"); expect(shouldLoadItemSymbols(node)).toBeFalsy(); }); diff --git a/devtools/client/shared/components/test/node/components/reps/grip-entry.test.js b/devtools/client/shared/components/test/node/components/reps/grip-entry.test.js index 7376993466ef..77faaf78f4ad 100644 --- a/devtools/client/shared/components/test/node/components/reps/grip-entry.test.js +++ b/devtools/client/shared/components/test/node/components/reps/grip-entry.test.js @@ -13,11 +13,11 @@ const { } = require("devtools/client/shared/components/reps/reps/rep"); const { GripEntry } = REPS; -const { createGripMapEntry } = GripEntry; const { MODE, } = require("devtools/client/shared/components/reps/reps/constants"); const { + createGripMapEntry, getGripLengthBubbleText, } = require("devtools/client/shared/components/test/node/components/reps/test-helpers"); diff --git a/devtools/client/shared/components/test/node/components/reps/test-helpers.js b/devtools/client/shared/components/test/node/components/reps/test-helpers.js index 693a5e7578fb..3b1c6d1a4aea 100644 --- a/devtools/client/shared/components/test/node/components/reps/test-helpers.js +++ b/devtools/client/shared/components/test/node/components/reps/test-helpers.js @@ -97,7 +97,18 @@ function getMapLengthBubbleText(object, props) { }); } +function createGripMapEntry(key, value) { + return { + type: "mapEntry", + preview: { + key, + value, + }, + }; +} + module.exports = { + createGripMapEntry, expectActorAttribute, getSelectableInInspectorGrips, getGripLengthBubbleText,