nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1865678 - [puppeteer] Always fail Puppeteer job when something is broken. r=webdriver-reviewers,Sasha

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D194569
This commit is contained in:
Henrik Skupin 2023-11-24 21:03:27 +00:00
parent 82bc783c85
commit afe8da2f21
1 changed files with 4 additions and 9 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

13
remote/mach_commands.py
View file

@ -493,7 +493,7 @@ class PuppeteerRunner(MozbuildObject):
] ]
output_handler = MochaOutputHandler(logger, expectations) output_handler = MochaOutputHandler(logger, expectations)
return_code = run_npm( run_npm(
*command, *command,
cwd=self.puppeteer_dir, cwd=self.puppeteer_dir,
env=env, env=env,
@ -501,19 +501,14 @@ class PuppeteerRunner(MozbuildObject):
# Puppeteer unit tests don't always clean-up child processes in case of # Puppeteer unit tests don't always clean-up child processes in case of
# failure, so use an output_timeout as a fallback # failure, so use an output_timeout as a fallback
output_timeout=60, output_timeout=60,
exit_on_fail=False, exit_on_fail=True,
) )
output_handler.after_end() output_handler.after_end()
# Non-zero return codes are non-fatal for now since we have some
# issues with unresolved promises that shouldn't otherwise block
# running the tests
if return_code != 0:
logger.warning("npm exited with code %s" % return_code)
if output_handler.has_unexpected: if output_handler.has_unexpected:
exit(1, "Got unexpected results") logger.error("Got unexpected results")
exit(1)
def create_parser_puppeteer(): def create_parser_puppeteer():