nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1787406 - Part 12: Remove duplicate parameter from NamedLambdaObject::create(). r=jandem

Browse source 
All callers are passing the same value for both parameters.

Depends on D155684

Differential Revision: https://phabricator.services.mozilla.com/D155685
This commit is contained in:
André Bargull 2022-08-26 14:24:12 +00:00
parent 8b32b89094
commit b5b2f20cb7
2 changed files with 3 additions and 5 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

7
js/src/vm/EnvironmentObject.cpp
View file

@ -1026,7 +1026,6 @@ BlockLexicalEnvironmentObject* BlockLexicalEnvironmentObject::recreate(
/* static */ /* static */
NamedLambdaObject* NamedLambdaObject::create(JSContext* cx, NamedLambdaObject* NamedLambdaObject::create(JSContext* cx,
HandleFunction callee, HandleFunction callee,
HandleFunction func,
HandleObject enclosing, HandleObject enclosing,
gc::InitialHeap heap) { gc::InitialHeap heap) {
MOZ_ASSERT(callee->isNamedLambda()); MOZ_ASSERT(callee->isNamedLambda());
@ -1055,14 +1054,14 @@ NamedLambdaObject* NamedLambdaObject::create(JSContext* cx,
return nullptr; return nullptr;
} }
obj->initFixedSlot(lambdaSlot(), ObjectValue(*func)); obj->initFixedSlot(lambdaSlot(), ObjectValue(*callee));
return static_cast<NamedLambdaObject*>(obj); return static_cast<NamedLambdaObject*>(obj);
} }
/* static */ /* static */
NamedLambdaObject* NamedLambdaObject::createTemplateObject( NamedLambdaObject* NamedLambdaObject::createTemplateObject(
JSContext* cx, HandleFunction callee, gc::InitialHeap heap) { JSContext* cx, HandleFunction callee, gc::InitialHeap heap) {
return create(cx, callee, callee, nullptr, heap); return create(cx, callee, nullptr, heap);
} }
/* static */ /* static */
@ -1070,7 +1069,7 @@ NamedLambdaObject* NamedLambdaObject::create(JSContext* cx,
AbstractFramePtr frame) { AbstractFramePtr frame) {
RootedFunction fun(cx, frame.callee()); RootedFunction fun(cx, frame.callee());
RootedObject enclosing(cx, frame.environmentChain()); RootedObject enclosing(cx, frame.environmentChain());
return create(cx, fun, fun, enclosing, gc::DefaultHeap); return create(cx, fun, enclosing, gc::DefaultHeap);
} }
/* static */ /* static */

1
js/src/vm/EnvironmentObject.h
View file

@ -602,7 +602,6 @@ class BlockLexicalEnvironmentObject : public ScopedLexicalEnvironmentObject {
class NamedLambdaObject : public BlockLexicalEnvironmentObject { class NamedLambdaObject : public BlockLexicalEnvironmentObject {
static NamedLambdaObject* create(JSContext* cx, HandleFunction callee, static NamedLambdaObject* create(JSContext* cx, HandleFunction callee,
HandleFunction replacement,
HandleObject enclosing, HandleObject enclosing,
gc::InitialHeap heap); gc::InitialHeap heap);