nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1901769 - Remove unused after_pointer popup position. r=layout-reviewers,jfkthame, a=dsmith

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D217934
This commit is contained in:
Emilio Cobos Álvarez 2024-07-29 13:04:46 +00:00
parent 5622512f6b
commit b76d66f149
3 changed files with 0 additions and 27 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

7
layout/xul/nsMenuPopupFrame.cpp
View file

@ -847,13 +847,6 @@ void nsMenuPopupFrame::InitializePopup(nsIContent* aAnchorContent,
mPopupAnchor = POPUPALIGNMENT_TOPLEFT; mPopupAnchor = POPUPALIGNMENT_TOPLEFT;
mPopupAlignment = POPUPALIGNMENT_TOPLEFT; mPopupAlignment = POPUPALIGNMENT_TOPLEFT;
mPosition = POPUPPOSITION_OVERLAP; mPosition = POPUPPOSITION_OVERLAP;
} else if (position.EqualsLiteral("after_pointer")) {
mPopupAnchor = POPUPALIGNMENT_TOPLEFT;
mPopupAlignment = POPUPALIGNMENT_TOPLEFT;
mPosition = POPUPPOSITION_AFTERPOINTER;
// XXXndeakin this is supposed to anchor vertically after, but with the
// horizontal position as the mouse pointer.
mYPos += 21;
} else if (position.EqualsLiteral("selection")) { } else if (position.EqualsLiteral("selection")) {
mPopupAnchor = POPUPALIGNMENT_BOTTOMLEFT; mPopupAnchor = POPUPALIGNMENT_BOTTOMLEFT;
mPopupAlignment = POPUPALIGNMENT_TOPLEFT; mPopupAlignment = POPUPALIGNMENT_TOPLEFT;

6
toolkit/content/tests/chrome/popup_trigger.js
View file

@ -259,7 +259,6 @@ var popupTests = [
"start_after", "start_after",
"end_before", "end_before",
"end_after", "end_after",
"after_pointer",
"overlap", "overlap",
"topleft topleft", "topleft topleft",
"topcenter topleft", "topcenter topleft",
@ -301,7 +300,6 @@ var popupTests = [
"start_after", "start_after",
"end_before", "end_before",
"end_after", "end_after",
"after_pointer",
"overlap", "overlap",
"topleft topleft", "topleft topleft",
"topcenter topleft", "topcenter topleft",
@ -359,7 +357,6 @@ var popupTests = [
"start_after", "start_after",
"end_before", "end_before",
"end_after", "end_after",
"after_pointer",
"overlap", "overlap",
], ],
test(testname, step) { test(testname, step) {
@ -401,7 +398,6 @@ var popupTests = [
"start_after", "start_after",
"end_before", "end_before",
"end_after", "end_after",
"after_pointer",
"overlap", "overlap",
], ],
test(testname, step) { test(testname, step) {
@ -447,7 +443,6 @@ var popupTests = [
"start_after", "start_after",
"end_before", "end_before",
"end_after", "end_after",
"after_pointer",
"overlap", "overlap",
], ],
test(testname, step) { test(testname, step) {
@ -512,7 +507,6 @@ var popupTests = [
"start_after", "start_after",
"end_before", "end_before",
"end_after", "end_after",
"after_pointer",
"overlap", "overlap",
"topcenter topleft", "topcenter topleft",
"topright bottomright", "topright bottomright",

14
toolkit/content/tests/widgets/popup_shared.js
View file

@ -520,20 +520,6 @@ function compareEdge(anchor, popup, edge, offsetX, offsetY, testname) {
return; return;
} }
if (edge == "after_pointer") {
is(
Math.round(popuprect.left),
Math.round(anchorrect.left) + offsetX,
testname + " x position"
);
is(
Math.round(popuprect.top),
Math.round(anchorrect.top) + offsetY + 21,
testname + " y position"
);
return;
}
if (edge == "overlap") { if (edge == "overlap") {
is( is(
Math.round(anchorrect.left) + offsetY, Math.round(anchorrect.left) + offsetY,