nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1895391 - Remove widget.non-native-theme.solid-outline-style pref r=gregp,emilio

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D210276
This commit is contained in:
tannal 2024-05-14 10:05:49 +00:00
parent c0591e5be4
commit b8ce3e7b7f
2 changed files with 1 additions and 14 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

6
modules/libpref/init/StaticPrefList.yaml
View file

@ -16210,12 +16210,6 @@
#endif #endif
mirror: always mirror: always
# Whether the outline style should be one big stroke or two contrasting strokes
- name: widget.non-native-theme.solid-outline-style
type: bool
value: false
mirror: always
# Preference to disable dark scrollbar implementation. # Preference to disable dark scrollbar implementation.
# This is mainly for testing because dark scrollbars have to be semi- # This is mainly for testing because dark scrollbars have to be semi-
# transparent, but many reftests expect scrollbars to look identical # transparent, but many reftests expect scrollbars to look identical

9
widget/Theme.cpp
View file

@ -1350,7 +1350,6 @@ void Theme::PaintAutoStyleOutline(nsIFrame* aFrame,
const LayoutDeviceRect& aRect, const LayoutDeviceRect& aRect,
const Colors& aColors, DPIRatio aDpiRatio) { const Colors& aColors, DPIRatio aDpiRatio) {
const auto& accentColor = aColors.Accent(); const auto& accentColor = aColors.Accent();
const bool solid = StaticPrefs::widget_non_native_theme_solid_outline_style();
LayoutDeviceCoord strokeWidth(ThemeDrawing::SnapBorderWidth(2.0f, aDpiRatio)); LayoutDeviceCoord strokeWidth(ThemeDrawing::SnapBorderWidth(2.0f, aDpiRatio));
LayoutDeviceRect rect(aRect); LayoutDeviceRect rect(aRect);
@ -1410,10 +1409,6 @@ void Theme::PaintAutoStyleOutline(nsIFrame* aFrame,
: accentColor.Get(); : accentColor.Get();
DrawRect(primaryColor); DrawRect(primaryColor);
if (solid) {
return;
}
offset += strokeWidth; offset += strokeWidth;
strokeWidth = strokeWidth =
@ -1486,9 +1481,7 @@ bool Theme::GetWidgetOverflow(nsDeviceContext* aContext, nsIFrame* aFrame,
CSSIntMargin overflow; CSSIntMargin overflow;
switch (aAppearance) { switch (aAppearance) {
case StyleAppearance::FocusOutline: { case StyleAppearance::FocusOutline: {
// 2px * one segment, or 2px + 1px const auto width = 3;
const auto width =
StaticPrefs::widget_non_native_theme_solid_outline_style() ? 2 : 3;
overflow.SizeTo(width, width, width, width); overflow.SizeTo(width, width, width, width);
break; break;
} }