nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1838330: Make AppWindow::FullscreenWillChange correctly compare window to screen using device scale. r=edgar

Browse source 
The implementation of AppWindow::ForceRoundedDimensions makes clear that
the window size from GetSize` is unscaled. This patch updates the math in
FullscreenWillChange to also consider devices pixels per css pixel.

Differential Revision: https://phabricator.services.mozilla.com/D180886
This commit is contained in:
Brad Werth 2023-06-14 18:53:34 +00:00
parent 8596ffe604
commit c03417c284
1 changed files with 6 additions and 7 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

13
xpfe/appshell/AppWindow.cpp
View file

@ -2968,20 +2968,19 @@ void AppWindow::FullscreenWillChange(bool aInFullscreen) {
}
MOZ_ASSERT(mFullscreenChangeState == FullscreenChangeState::NotChanging);
int32_t winWidth = 0;
int32_t winHeight = 0;
GetSize(&winWidth, &winHeight);
CSSToLayoutDeviceScale scale = UnscaledDevicePixelsPerCSSPixel();
CSSIntSize windowSizeCSS = RoundedToInt(GetSize() / scale);
int32_t screenWidth = 0;
int32_t screenHeight = 0;
GetAvailScreenSize(&screenWidth, &screenHeight);
CSSIntSize screenSizeCSS;
GetAvailScreenSize(&screenSizeCSS.width, &screenSizeCSS.height);
// Check if the window is already at the expected dimensions. If it is, set
// the fullscreen change state to WidgetResized to avoid waiting for a resize
// event. On macOS, a fullscreen window could be slightly higher than
// available screen size because of the OS menu bar isn't yet hidden.
mFullscreenChangeState =
(aInFullscreen == (winWidth == screenWidth && winHeight >= screenHeight))
(aInFullscreen == (windowSizeCSS.width == screenSizeCSS.width &&
windowSizeCSS.height >= screenSizeCSS.height))
? FullscreenChangeState::WidgetResized
: FullscreenChangeState::WillChange;
}