nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1326100 - Restore notable inline comments in DevTools. r=tromey

Browse source 
MozReview-Commit-ID: 6cLDkoCt0al

--HG--
extra : rebase_source : 26e95a9320998085675a1f14bfa4442f4bbc38dc
This commit is contained in:
J. Ryan Stinnett 2017-03-20 16:22:55 -05:00
parent b9f4e71243
commit c26a6274cc
25 changed files with 75 additions and 141 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

1
devtools/client/inspector/test/browser_inspector_search-01.js
View file

@ -1,7 +1,6 @@
/* vim: set ft=javascript ts=2 et sw=2 tw=80: */
/* Any copyright is dedicated to the Public Domain.
http://creativecommons.org/publicdomain/zero/1.0/ */
/* eslint no-inline-comments: 0 */
"use strict";
requestLongerTimeout(2);

6
devtools/client/netmonitor/components/request-list-header.js
View file

@ -14,10 +14,8 @@ const Actions = require("../actions/index");
const WaterfallBackground = require("../waterfall-background");
const { getFormattedTime } = require("../utils/format-utils");
// ms
const REQUESTS_WATERFALL_HEADER_TICKS_MULTIPLE = 5;
// px
const REQUESTS_WATERFALL_HEADER_TICKS_SPACING_MIN = 60;
const REQUESTS_WATERFALL_HEADER_TICKS_MULTIPLE = 5; // ms
const REQUESTS_WATERFALL_HEADER_TICKS_SPACING_MIN = 60; // px
const HEADERS = [
{ name: "status", label: "status3" },

3
devtools/client/netmonitor/middleware/batching.js
View file

@ -6,8 +6,7 @@
const { BATCH_ACTIONS, BATCH_ENABLE, BATCH_RESET } = require("../constants");
// ms
const REQUESTS_REFRESH_RATE = 50;
const REQUESTS_REFRESH_RATE = 50; // ms
/**
* Middleware that watches for actions with a "batch = true" value in their meta field.

6
devtools/client/netmonitor/request-list-tooltip.js
View file

@ -11,10 +11,8 @@ const {
const { WEBCONSOLE_L10N } = require("./utils/l10n");
const { formDataURI } = require("./utils/request-utils");
// px
const REQUESTS_TOOLTIP_IMAGE_MAX_DIM = 400;
// px
const REQUESTS_TOOLTIP_STACK_TRACE_WIDTH = 600;
const REQUESTS_TOOLTIP_IMAGE_MAX_DIM = 400; // px
const REQUESTS_TOOLTIP_STACK_TRACE_WIDTH = 600; // px
const HTML_NS = "http://www.w3.org/1999/xhtml";

6
devtools/client/netmonitor/waterfall-background.js
View file

@ -5,11 +5,9 @@
"use strict";
const HTML_NS = "http://www.w3.org/1999/xhtml";
// ms
const REQUESTS_WATERFALL_BACKGROUND_TICKS_MULTIPLE = 5;
const REQUESTS_WATERFALL_BACKGROUND_TICKS_MULTIPLE = 5; // ms
const REQUESTS_WATERFALL_BACKGROUND_TICKS_SCALES = 3;
// px
const REQUESTS_WATERFALL_BACKGROUND_TICKS_SPACING_MIN = 10;
const REQUESTS_WATERFALL_BACKGROUND_TICKS_SPACING_MIN = 10; // px
const REQUESTS_WATERFALL_BACKGROUND_TICKS_COLOR_RGB = [128, 136, 144];
// 8-bit value of the alpha component of the tick color
const REQUESTS_WATERFALL_BACKGROUND_TICKS_OPACITY_MIN = 32;

9
devtools/client/performance/components/waterfall-header.js
View file

@ -12,12 +12,9 @@ const { DOM: dom, PropTypes } = require("devtools/client/shared/vendor/react");
const { L10N } = require("../modules/global");
const { TickUtils } = require("../modules/waterfall-ticks");
// ms
const WATERFALL_HEADER_TICKS_MULTIPLE = 5;
// px
const WATERFALL_HEADER_TICKS_SPACING_MIN = 50;
// px
const WATERFALL_HEADER_TEXT_PADDING = 3;
const WATERFALL_HEADER_TICKS_MULTIPLE = 5; // ms
const WATERFALL_HEADER_TICKS_SPACING_MIN = 50; // px
const WATERFALL_HEADER_TEXT_PADDING = 3; // px
function WaterfallHeader(props) {
let { startTime, dataScale, sidebarWidth, waterfallWidth } = props;

9
devtools/client/performance/components/waterfall-tree-row.js
View file

@ -11,12 +11,9 @@
const { DOM: dom, PropTypes } = require("devtools/client/shared/vendor/react");
const { MarkerBlueprintUtils } = require("../modules/marker-blueprint-utils");
// px
const LEVEL_INDENT = 10;
// px
const ARROW_NODE_OFFSET = -14;
// px
const WATERFALL_MARKER_TIMEBAR_WIDTH_MIN = 5;
const LEVEL_INDENT = 10; // px
const ARROW_NODE_OFFSET = -14; // px
const WATERFALL_MARKER_TIMEBAR_WIDTH_MIN = 5; // px
function buildMarkerSidebar(blueprint, props) {
const { marker, level, sidebarWidth } = props;

4
devtools/client/performance/components/waterfall-tree.js
View file

@ -7,8 +7,8 @@ const { createClass, createFactory, PropTypes } = require("devtools/client/share
const Tree = createFactory(require("devtools/client/shared/components/tree"));
const WaterfallTreeRow = createFactory(require("./waterfall-tree-row"));
// px - keep in sync with var(--waterfall-tree-row-height) in performance.css
const WATERFALL_TREE_ROW_HEIGHT = 15;
// Keep in sync with var(--waterfall-tree-row-height) in performance.css
const WATERFALL_TREE_ROW_HEIGHT = 15; // px
/**
* Checks if a given marker is in the specified time range.

12
devtools/client/performance/modules/waterfall-ticks.js
View file

@ -5,16 +5,12 @@
const HTML_NS = "http://www.w3.org/1999/xhtml";
// ms
const WATERFALL_BACKGROUND_TICKS_MULTIPLE = 5;
const WATERFALL_BACKGROUND_TICKS_MULTIPLE = 5; // ms
const WATERFALL_BACKGROUND_TICKS_SCALES = 3;
// px
const WATERFALL_BACKGROUND_TICKS_SPACING_MIN = 10;
const WATERFALL_BACKGROUND_TICKS_SPACING_MIN = 10; // px
const WATERFALL_BACKGROUND_TICKS_COLOR_RGB = [128, 136, 144];
// byte
const WATERFALL_BACKGROUND_TICKS_OPACITY_MIN = 32;
// byte
const WATERFALL_BACKGROUND_TICKS_OPACITY_ADD = 32;
const WATERFALL_BACKGROUND_TICKS_OPACITY_MIN = 32; // byte
const WATERFALL_BACKGROUND_TICKS_OPACITY_ADD = 32; // byte
const FIND_OPTIMAL_TICK_INTERVAL_MAX_ITERS = 100;

15
devtools/client/performance/modules/widgets/graphs.js
View file

@ -25,10 +25,8 @@ const { createTierGraphDataFromFrameNode } = require("devtools/client/performanc
/**
* For line graphs
*/
// px
const HEIGHT = 35;
// px
const STROKE_WIDTH = 1;
const HEIGHT = 35; // px
const STROKE_WIDTH = 1; // px
const DAMPEN_VALUES = 0.95;
const CLIPHEAD_LINE_COLOR = "#666";
const SELECTION_LINE_COLOR = "#555";
@ -39,12 +37,9 @@ const MEMORY_GRAPH_COLOR_NAME = "graphs-blue";
/**
* For timeline overview
*/
// px
const MARKERS_GRAPH_HEADER_HEIGHT = 14;
// px
const MARKERS_GRAPH_ROW_HEIGHT = 10;
// px
const MARKERS_GROUP_VERTICAL_PADDING = 4;
const MARKERS_GRAPH_HEADER_HEIGHT = 14; // px
const MARKERS_GRAPH_ROW_HEIGHT = 10; // px
const MARKERS_GROUP_VERTICAL_PADDING = 4; // px
/**
* For optimization graph

27
devtools/client/performance/modules/widgets/markers-overview.js
View file

@ -19,29 +19,20 @@ const { MarkerBlueprintUtils } = require("devtools/client/performance/modules/ma
const { TickUtils } = require("devtools/client/performance/modules/waterfall-ticks");
const { TIMELINE_BLUEPRINT } = require("devtools/client/performance/modules/markers");
// px
const OVERVIEW_HEADER_HEIGHT = 14;
// px
const OVERVIEW_ROW_HEIGHT = 11;
const OVERVIEW_HEADER_HEIGHT = 14; // px
const OVERVIEW_ROW_HEIGHT = 11; // px
const OVERVIEW_SELECTION_LINE_COLOR = "#666";
const OVERVIEW_CLIPHEAD_LINE_COLOR = "#555";
// ms
const OVERVIEW_HEADER_TICKS_MULTIPLE = 100;
// px
const OVERVIEW_HEADER_TICKS_SPACING_MIN = 75;
// px
const OVERVIEW_HEADER_TEXT_FONT_SIZE = 9;
const OVERVIEW_HEADER_TICKS_MULTIPLE = 100; // ms
const OVERVIEW_HEADER_TICKS_SPACING_MIN = 75; // px
const OVERVIEW_HEADER_TEXT_FONT_SIZE = 9; // px
const OVERVIEW_HEADER_TEXT_FONT_FAMILY = "sans-serif";
// px
const OVERVIEW_HEADER_TEXT_PADDING_LEFT = 6;
// px
const OVERVIEW_HEADER_TEXT_PADDING_TOP = 1;
// px
const OVERVIEW_MARKER_WIDTH_MIN = 4;
// px
const OVERVIEW_GROUP_VERTICAL_PADDING = 5;
const OVERVIEW_HEADER_TEXT_PADDING_LEFT = 6; // px
const OVERVIEW_HEADER_TEXT_PADDING_TOP = 1; // px
const OVERVIEW_MARKER_WIDTH_MIN = 4; // px
const OVERVIEW_GROUP_VERTICAL_PADDING = 5; // px
/**
* An overview for the markers data.

3
devtools/client/performance/modules/widgets/tree-view.js
View file

@ -15,8 +15,7 @@ const { AbstractTreeItem } = require("resource://devtools/client/shared/widgets/
const URL_LABEL_TOOLTIP = L10N.getStr("table.url.tooltiptext");
const VIEW_OPTIMIZATIONS_TOOLTIP = L10N.getStr("table.view-optimizations.tooltiptext2");
// px
const CALL_TREE_INDENTATION = 16;
const CALL_TREE_INDENTATION = 16; // px
// Used for rendering values in cells
const FORMATTERS = {

2
devtools/client/performance/test/unit/test_perf-utils-allocations-to-samples.js
View file

@ -45,7 +45,6 @@ var TEST_DATA = {
]
};
/* eslint-disable no-inline-comments */
var EXPECTED_OUTPUT = {
name: "allocations",
samples: {
@ -93,4 +92,3 @@ var EXPECTED_OUTPUT = {
"C:5:6"
],
};
/* eslint-enable no-inline-comments */

41
devtools/client/shared/widgets/FlameGraph.js
View file

@ -30,8 +30,7 @@ loader.lazyRequireGetter(this, "GraphAreaDragger",
const GRAPH_SRC = "chrome://devtools/content/shared/widgets/graphs-frame.xhtml";
// ms
const GRAPH_RESIZE_EVENTS_DRAIN = 100;
const GRAPH_RESIZE_EVENTS_DRAIN = 100; // ms
const GRAPH_WHEEL_ZOOM_SENSITIVITY = 0.00035;
const GRAPH_WHEEL_SCROLL_SENSITIVITY = 0.5;
@ -40,39 +39,31 @@ const GRAPH_KEYBOARD_PAN_SENSITIVITY = 20;
const GRAPH_KEYBOARD_ACCELERATION = 1.05;
const GRAPH_KEYBOARD_TRANSLATION_MAX = 150;
// ms
const GRAPH_MIN_SELECTION_WIDTH = 0.001;
const GRAPH_MIN_SELECTION_WIDTH = 0.001; // ms
// px
const GRAPH_HORIZONTAL_PAN_THRESHOLD = 10;
const GRAPH_VERTICAL_PAN_THRESHOLD = 30;
const GRAPH_HORIZONTAL_PAN_THRESHOLD = 10; // px
const GRAPH_VERTICAL_PAN_THRESHOLD = 30; // px
const FIND_OPTIMAL_TICK_INTERVAL_MAX_ITERS = 100;
// ms
const TIMELINE_TICKS_MULTIPLE = 5;
// px
const TIMELINE_TICKS_SPACING_MIN = 75;
const TIMELINE_TICKS_MULTIPLE = 5; // ms
const TIMELINE_TICKS_SPACING_MIN = 75; // px
// px
const OVERVIEW_HEADER_HEIGHT = 16;
const OVERVIEW_HEADER_TEXT_FONT_SIZE = 9;
const OVERVIEW_HEADER_HEIGHT = 16; // px
const OVERVIEW_HEADER_TEXT_FONT_SIZE = 9; // px
const OVERVIEW_HEADER_TEXT_FONT_FAMILY = "sans-serif";
// px
const OVERVIEW_HEADER_TEXT_PADDING_LEFT = 6;
const OVERVIEW_HEADER_TEXT_PADDING_TOP = 5;
const OVERVIEW_HEADER_TEXT_PADDING_LEFT = 6; // px
const OVERVIEW_HEADER_TEXT_PADDING_TOP = 5; // px
const OVERVIEW_HEADER_TIMELINE_STROKE_COLOR = "rgba(128, 128, 128, 0.5)";
// px
const FLAME_GRAPH_BLOCK_HEIGHT = 15;
const FLAME_GRAPH_BLOCK_BORDER = 1;
const FLAME_GRAPH_BLOCK_TEXT_FONT_SIZE = 10;
const FLAME_GRAPH_BLOCK_HEIGHT = 15; // px
const FLAME_GRAPH_BLOCK_BORDER = 1; // px
const FLAME_GRAPH_BLOCK_TEXT_FONT_SIZE = 10; // px
const FLAME_GRAPH_BLOCK_TEXT_FONT_FAMILY = "message-box, Helvetica Neue," +
"Helvetica, sans-serif";
// px
const FLAME_GRAPH_BLOCK_TEXT_PADDING_TOP = 0;
const FLAME_GRAPH_BLOCK_TEXT_PADDING_LEFT = 3;
const FLAME_GRAPH_BLOCK_TEXT_PADDING_RIGHT = 3;
const FLAME_GRAPH_BLOCK_TEXT_PADDING_TOP = 0; // px
const FLAME_GRAPH_BLOCK_TEXT_PADDING_LEFT = 3; // px
const FLAME_GRAPH_BLOCK_TEXT_PADDING_RIGHT = 3; // px
// Large enough number for a diverse pallette.
const PALLETTE_SIZE = 20;

27
devtools/client/shared/widgets/Graphs.js
View file

@ -21,28 +21,23 @@ const WORKER_URL =
// Generic constants.
// ms
const GRAPH_RESIZE_EVENTS_DRAIN = 100;
const GRAPH_RESIZE_EVENTS_DRAIN = 100; // ms
const GRAPH_WHEEL_ZOOM_SENSITIVITY = 0.00075;
const GRAPH_WHEEL_SCROLL_SENSITIVITY = 0.1;
// px
const GRAPH_WHEEL_MIN_SELECTION_WIDTH = 10;
const GRAPH_WHEEL_MIN_SELECTION_WIDTH = 10; // px
// px
const GRAPH_SELECTION_BOUNDARY_HOVER_LINE_WIDTH = 4;
const GRAPH_SELECTION_BOUNDARY_HOVER_THRESHOLD = 10;
const GRAPH_MAX_SELECTION_LEFT_PADDING = 1;
const GRAPH_MAX_SELECTION_RIGHT_PADDING = 1;
const GRAPH_SELECTION_BOUNDARY_HOVER_LINE_WIDTH = 4; // px
const GRAPH_SELECTION_BOUNDARY_HOVER_THRESHOLD = 10; // px
const GRAPH_MAX_SELECTION_LEFT_PADDING = 1; // px
const GRAPH_MAX_SELECTION_RIGHT_PADDING = 1; // px
// px
const GRAPH_REGION_LINE_WIDTH = 1;
const GRAPH_REGION_LINE_WIDTH = 1; // px
const GRAPH_REGION_LINE_COLOR = "rgba(237,38,85,0.8)";
// px
const GRAPH_STRIPE_PATTERN_WIDTH = 16;
const GRAPH_STRIPE_PATTERN_HEIGHT = 16;
const GRAPH_STRIPE_PATTERN_LINE_WIDTH = 2;
const GRAPH_STRIPE_PATTERN_LINE_SPACING = 4;
const GRAPH_STRIPE_PATTERN_WIDTH = 16; // px
const GRAPH_STRIPE_PATTERN_HEIGHT = 16; // px
const GRAPH_STRIPE_PATTERN_LINE_WIDTH = 2; // px
const GRAPH_STRIPE_PATTERN_LINE_SPACING = 4; // px
/**
* Small data primitives for all graphs.

13
devtools/client/shared/widgets/LineGraphWidget.js
View file

@ -11,17 +11,14 @@ const L10N = new LocalizationHelper("devtools/client/locales/graphs.properties")
// Line graph constants.
const GRAPH_DAMPEN_VALUES_FACTOR = 0.85;
// px
const GRAPH_TOOLTIP_SAFE_BOUNDS = 8;
const GRAPH_MIN_MAX_TOOLTIP_DISTANCE = 14;
const GRAPH_TOOLTIP_SAFE_BOUNDS = 8; // px
const GRAPH_MIN_MAX_TOOLTIP_DISTANCE = 14; // px
const GRAPH_BACKGROUND_COLOR = "#0088cc";
// px
const GRAPH_STROKE_WIDTH = 1;
const GRAPH_STROKE_WIDTH = 1; // px
const GRAPH_STROKE_COLOR = "rgba(255,255,255,0.9)";
// px
const GRAPH_HELPER_LINES_DASH = [5];
const GRAPH_HELPER_LINES_WIDTH = 1;
const GRAPH_HELPER_LINES_DASH = [5]; // px
const GRAPH_HELPER_LINES_WIDTH = 1; // px
const GRAPH_MAXIMUM_LINE_COLOR = "rgba(255,255,255,0.4)";
const GRAPH_AVERAGE_LINE_COLOR = "rgba(255,255,255,0.7)";
const GRAPH_MINIMUM_LINE_COLOR = "rgba(255,255,255,0.9)";

8
devtools/client/shared/widgets/MountainGraphWidget.js
View file

@ -8,12 +8,10 @@ const { AbstractCanvasGraph } = require("devtools/client/shared/widgets/Graphs")
const GRAPH_DAMPEN_VALUES_FACTOR = 0.9;
const GRAPH_BACKGROUND_COLOR = "#ddd";
// px
const GRAPH_STROKE_WIDTH = 1;
const GRAPH_STROKE_WIDTH = 1; // px
const GRAPH_STROKE_COLOR = "rgba(255,255,255,0.9)";
// px
const GRAPH_HELPER_LINES_DASH = [5];
const GRAPH_HELPER_LINES_WIDTH = 1;
const GRAPH_HELPER_LINES_DASH = [5]; // px
const GRAPH_HELPER_LINES_WIDTH = 1; // px
const GRAPH_CLIPHEAD_LINE_COLOR = "#fff";
const GRAPH_SELECTION_LINE_COLOR = "#fff";

2
devtools/client/sourceeditor/css-autocompleter.js
View file

@ -53,7 +53,6 @@ const {getClientCssProperties} = require("devtools/shared/fronts/css-properties"
// Autocompletion types.
/* eslint-disable no-inline-comments */
const CSS_STATES = {
"null": "null",
property: "property", // foo { bar|: … }
@ -73,7 +72,6 @@ const SELECTOR_STATES = {
attribute: "attribute", // foo[b|
value: "value", // foo[bar=b|
};
/* eslint-enable no-inline-comments */
/**
* Constructor for the autocompletion object.

2
devtools/client/webconsole/console-output.js
View file

@ -64,7 +64,6 @@ const COMPAT = {
// division of message type into "category" and "severity".
/* eslint-disable no-multi-spaces */
/* eslint-disable max-len */
/* eslint-disable no-inline-comments */
PREFERENCE_KEYS: [
// Error Warning Info Log
[ "network", "netwarn", null, "networkinfo", ], // Network
@ -76,7 +75,6 @@ const COMPAT = {
[ "secerror", "secwarn", null, null, ], // Security
[ "servererror", "serverwarn", "serverinfo", "serverlog", ], // Server Logging
],
/* eslint-enable no-inline-comments */
/* eslint-enable max-len */
/* eslint-enable no-multi-spaces */

7
devtools/server/actors/highlighters/css-grid.js
View file

@ -47,10 +47,9 @@ const GRID_LINES_PROPERTIES = {
}
};
// px
const GRID_GAP_PATTERN_WIDTH = 14;
const GRID_GAP_PATTERN_HEIGHT = 14;
const GRID_GAP_PATTERN_LINE_DASH = [5, 3];
const GRID_GAP_PATTERN_WIDTH = 14; // px
const GRID_GAP_PATTERN_HEIGHT = 14; // px
const GRID_GAP_PATTERN_LINE_DASH = [5, 3]; // px
const GRID_GAP_ALPHA = 0.5;
/**

3
devtools/server/actors/utils/map-uri-to-addon-id.js
View file

@ -24,8 +24,7 @@ const GRAPHENE_ID = "{d1bfe7d9-c01e-4237-998b-7b5f960a4314}";
*/
if (!Services.appinfo
|| Services.appinfo.processType == Services.appinfo.PROCESS_TYPE_CONTENT
/* XPCShell */
|| Services.appinfo.ID === undefined
|| Services.appinfo.ID === undefined /* XPCShell */
|| Services.appinfo.ID == B2G_ID
|| Services.appinfo.ID == GRAPHENE_ID
|| !AddonPathService) {

3
devtools/shared/css/lexer.js
View file

@ -10,8 +10,7 @@
// this file violates some naming conventions and consequently locally
// disables some eslint rules.
/* eslint-disable camelcase, no-inline-comments, mozilla/no-aArgs */
/* eslint-disable no-else-return */
/* eslint-disable camelcase, mozilla/no-aArgs, no-else-return */
"use strict";

1
devtools/shared/heapsnapshot/tests/unit/test_getCensusIndividuals_01.js
View file

@ -1,7 +1,6 @@
/* Any copyright is dedicated to the Public Domain.
http://creativecommons.org/publicdomain/zero/1.0/ */
"use strict";
// eslint-disable no-inline-comments
// Test basic functionality of `CensusUtils.getCensusIndividuals`.

2
devtools/shared/security/socket.js
View file

@ -358,7 +358,7 @@ function _storeCertOverride(s, host, port) {
let overrideBits = Ci.nsICertOverrideService.ERROR_UNTRUSTED |
Ci.nsICertOverrideService.ERROR_MISMATCH;
certOverrideService.rememberValidityOverride(host, port, cert, overrideBits,
true /* temporary */); // eslint-disable-line
true /* temporary */);
}
/**

4
devtools/shared/touch/simulator-core.js
View file

@ -264,14 +264,12 @@ SimulatorCore.prototype = {
}
}
let unwrapped = XPCNativeWrapper.unwrap(target);
/* eslint-disable no-inline-comments */
unwrapped.sendTouchEvent(name, clone([0]), // event type, id
clone([evt.clientX]), // x
clone([evt.clientY]), // y
clone([1]), clone([1]), // rx, ry
clone([0]), clone([0]), // rotation, force
1); // count
/* eslint-enable no-inline-comments */
return;
}
let document = target.ownerDocument;
@ -346,12 +344,10 @@ SimulatorCore.prototype = {
// delay. But Firefox didn't support this property now, we can't get
// this value from utils.getVisitedDependentComputedStyle() to check
// if we should suppress 300ms delay.
/* eslint-disable no-inline-comments */
if (!allowZoom.value || // user-scalable = no
minZoom.value === maxZoom.value || // minimum-scale = maximum-scale
autoSize.value // width = device-width
) {
/* eslint-enable no-inline-comments */
return 0;
}
return 300;