nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1829203 - Fix valgrind suppression in Skia. r=aosmond

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D176074
This commit is contained in:
Lee Salzman 2023-04-20 19:14:22 +00:00
parent b8f66c974f
commit c891dafa82
2 changed files with 10 additions and 14 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

14
build/valgrind/x86_64-pc-linux-gnu.sup
View file

@ -1034,17 +1034,3 @@
... ...
fun:_ZN7mozilla3dom7Element7SetAttrEiP6nsAtomS3_RK12nsTSubstringIDsEP12nsIPrincipalb fun:_ZN7mozilla3dom7Element7SetAttrEiP6nsAtomS3_RK12nsTSubstringIDsEP12nsIPrincipalb
} }
# Skia's SkSTArenaAlloc can sometimes confuse valgrind. April 15, 2023. See bug 1821512.
# Upstream Chrome/Skia issue 14254, https://bugs.chromium.org/p/skia/issues/detail?id=14254
{
Bug 1821512
Memcheck:Addr8
fun:_ZN23SkRasterPipelineBlitter6CreateE*
fun:_Z29SkCreateRasterPipelineBlitter*
fun:_ZZN9SkBlitter6ChooseE*
fun:_ZN9SkBlitter6ChooseE*
fun:choose
fun:_ZN19SkAutoBlitterChooseC2E*
...
}

10
gfx/skia/skia/src/base/SkArenaAlloc.h
View file

@ -313,6 +313,11 @@ class SkSTArenaAlloc : private std::array<char, InlineStorageSize>, public SkAre
public: public:
explicit SkSTArenaAlloc(size_t firstHeapAllocation = InlineStorageSize) explicit SkSTArenaAlloc(size_t firstHeapAllocation = InlineStorageSize)
: SkArenaAlloc{this->data(), this->size(), firstHeapAllocation} {} : SkArenaAlloc{this->data(), this->size(), firstHeapAllocation} {}
~SkSTArenaAlloc() {
// Be sure to unpoison the memory that is probably on the stack.
sk_asan_unpoison_memory_region(this->data(), this->size());
}
}; };
template <size_t InlineStorageSize> template <size_t InlineStorageSize>
@ -321,6 +326,11 @@ class SkSTArenaAllocWithReset
public: public:
explicit SkSTArenaAllocWithReset(size_t firstHeapAllocation = InlineStorageSize) explicit SkSTArenaAllocWithReset(size_t firstHeapAllocation = InlineStorageSize)
: SkArenaAllocWithReset{this->data(), this->size(), firstHeapAllocation} {} : SkArenaAllocWithReset{this->data(), this->size(), firstHeapAllocation} {}
~SkSTArenaAllocWithReset() {
// Be sure to unpoison the memory that is probably on the stack.
sk_asan_unpoison_memory_region(this->data(), this->size());
}
}; };
#endif // SkArenaAlloc_DEFINED #endif // SkArenaAlloc_DEFINED