nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1893087 - Part 2: Add test for constructing an actor under an already dead manager, r=ipc-reviewers,mccr8

Browse source 
Depends on D208936

Differential Revision: https://phabricator.services.mozilla.com/D209053
This commit is contained in:
Nika Layzell 2024-04-30 21:27:34 +00:00
parent 039cb74465
commit d1d7554feb
1 changed files with 20 additions and 7 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

27
ipc/ipdl/test/gtest/TestDestroyNested.cpp
View file

@ -28,6 +28,7 @@ class TestDestroyNestedSubParent : public PTestDestroyNestedSubParent {
void ActorDestroy(ActorDestroyReason aReason) override;
bool mActorDestroyCalled = false;
bool mCloseManager = false;
nsrefcnt GetRefCnt() const { return mRefCnt; }
@ -70,13 +71,15 @@ void TestDestroyNestedSubParent::ActorDestroy(ActorDestroyReason aReason) {
EXPECT_FALSE(mActorDestroyCalled) << "re-entered ActorDestroy()";
mActorDestroyCalled = true;
EXPECT_FALSE(
static_cast<TestDestroyNestedParent*>(Manager())->mActorDestroyCalled)
<< "manager already destroyed";
Manager()->Close();
EXPECT_TRUE(
static_cast<TestDestroyNestedParent*>(Manager())->mActorDestroyCalled)
<< "manager successfully destroyed";
if (mCloseManager) {
EXPECT_FALSE(
static_cast<TestDestroyNestedParent*>(Manager())->mActorDestroyCalled)
<< "manager already destroyed";
Manager()->Close();
EXPECT_TRUE(
static_cast<TestDestroyNestedParent*>(Manager())->mActorDestroyCalled)
<< "manager successfully destroyed";
}
// Make sure we also process any pending events, because we might be spinning
// a nested event loop within `ActorDestroy`.
@ -92,6 +95,7 @@ void TestDestroyNestedParent::ActorDestroy(ActorDestroyReason aReason) {
IPDL_TEST(TestDestroyNested) {
auto p = MakeRefPtr<TestDestroyNestedSubParent>();
p->mCloseManager = true;
auto* rv1 = mActor->SendPTestDestroyNestedSubConstructor(p);
ASSERT_EQ(p, rv1) << "can't allocate Sub";
@ -105,6 +109,15 @@ IPDL_TEST(TestDestroyNested) {
<< "Sub not destroyed";
ASSERT_EQ(p->GetRefCnt(), 1u) << "Outstanding references to Sub remain";
// Try to allocate a new actor under the already-destroyed manager, and ensure
// that it is destroyed as expected.
auto p2 = MakeRefPtr<TestDestroyNestedSubParent>();
auto* rv3 = mActor->SendPTestDestroyNestedSubConstructor(p2);
ASSERT_EQ(rv3, nullptr) << "construction succeeded unexpectedly";
ASSERT_TRUE(p2->mActorDestroyCalled)
<< "Sub not destroyed";
}
} // namespace mozilla::_ipdltest