diff --git a/.eslintrc.js b/.eslintrc.js index a1145e63265d..bf77a98ca849 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -497,7 +497,6 @@ module.exports = { "no-shadow": "off", "no-sparse-arrays": "off", "no-throw-literal": "off", - "no-unreachable": "off", "no-useless-call": "off", "no-useless-concat": "off", }, diff --git a/dom/events/test/clipboard/simple_navigator_clipboard_read.html b/dom/events/test/clipboard/simple_navigator_clipboard_read.html index 89f38a324088..825089e79996 100644 --- a/dom/events/test/clipboard/simple_navigator_clipboard_read.html +++ b/dom/events/test/clipboard/simple_navigator_clipboard_read.html @@ -18,7 +18,6 @@ let items = await navigator.clipboard.read(); if (items.length != 1) { throw Error(`incorrect number of clipboard item (${items.length})`); - return; } let item = items[0]; diff --git a/dom/media/webrtc/tests/mochitests/test_peerConnection_throwInCallbacks.html b/dom/media/webrtc/tests/mochitests/test_peerConnection_throwInCallbacks.html index 5a3872c120d0..c476c60161b3 100644 --- a/dom/media/webrtc/tests/mochitests/test_peerConnection_throwInCallbacks.html +++ b/dom/media/webrtc/tests/mochitests/test_peerConnection_throwInCallbacks.html @@ -38,7 +38,6 @@ runNetworkTest(function () { finish(); } throw new Error("window.onerror may throw"); - return false; } let pc0, pc1, pc2; diff --git a/dom/media/webspeech/recognition/test/test_online_http.html b/dom/media/webspeech/recognition/test/test_online_http.html index 43be7a656af0..644a9a098b7c 100644 --- a/dom/media/webspeech/recognition/test/test_online_http.html +++ b/dom/media/webspeech/recognition/test/test_online_http.html @@ -40,14 +40,12 @@ that audio is being properly encoded while (true) { if (performance.now() - start > 10000) { return false; - break; } analyser.getByteFrequencyData(data); if (data[binIndexForFrequency(200)] < 50 && data[binIndexForFrequency(440)] > 180 && data[binIndexForFrequency(1000)] < 50) { return true; - break; } await new Promise(r => requestAnimationFrame(r)); } diff --git a/dom/media/webspeech/recognition/test/test_online_http_webkit.html b/dom/media/webspeech/recognition/test/test_online_http_webkit.html index 7f6c7e6d7d1e..5801697a45b6 100644 --- a/dom/media/webspeech/recognition/test/test_online_http_webkit.html +++ b/dom/media/webspeech/recognition/test/test_online_http_webkit.html @@ -40,14 +40,12 @@ that audio is being properly encoded while (true) { if (performance.now() - start > 10000) { return false; - break; } analyser.getByteFrequencyData(data); if (data[binIndexForFrequency(200)] < 50 && data[binIndexForFrequency(440)] > 180 && data[binIndexForFrequency(1000)] < 50) { return true; - break; } await new Promise(r => requestAnimationFrame(r)); } diff --git a/dom/payments/test/test_retryPayment.html b/dom/payments/test/test_retryPayment.html index 3ce389f475d3..7caed56b0cc0 100644 --- a/dom/payments/test/test_retryPayment.html +++ b/dom/payments/test/test_retryPayment.html @@ -148,13 +148,10 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=1435161 try { await payResponse.retry(validationErrors); ok(false, `${testName}: Unexpected success when retry the PaymentResponse.`); - return; } catch(err) { is(err.name, "InvalidStateError", expectedErrMsg(testName, "InvalidStateError", err.name, "retrying")); - await requestChromeAction("finish-test"); - return; } await requestChromeAction("finish-test"); } diff --git a/dom/security/test/csp/test_redirects.html b/dom/security/test/csp/test_redirects.html index 9cc569ed72b7..3993560c1415 100644 --- a/dom/security/test/csp/test_redirects.html +++ b/dom/security/test/csp/test_redirects.html @@ -19,10 +19,9 @@ var path = "/tests/dom/security/test/csp/"; // debugging function log(s) { - return; - dump("**" + s + "\n"); - var log = document.getElementById("log"); - log.textContent = log.textContent+s+"\n"; + // dump("**" + s + "\n"); + // var log = document.getElementById("log"); + // log.textContent = log.textContent+s+"\n"; } SpecialPowers.registerObservers("csp-on-violate-policy"); diff --git a/dom/serviceworkers/test/strict_mode_warning.js b/dom/serviceworkers/test/strict_mode_warning.js index 38418de3d80f..4709b2b66763 100644 --- a/dom/serviceworkers/test/strict_mode_warning.js +++ b/dom/serviceworkers/test/strict_mode_warning.js @@ -1,4 +1,5 @@ function f() { return 1; + // eslint-disable-next-line no-unreachable return 2; } diff --git a/dom/serviceworkers/test/test_devtools_bypass_serviceworker.html b/dom/serviceworkers/test/test_devtools_bypass_serviceworker.html index 09c05d557aaa..ec73f59dc0f8 100644 --- a/dom/serviceworkers/test/test_devtools_bypass_serviceworker.html +++ b/dom/serviceworkers/test/test_devtools_bypass_serviceworker.html @@ -53,7 +53,6 @@ async function testBypassSW () { } throw("Unexpected error"); - return; } let docShell = SpecialPowers.wrap(window).docShell; diff --git a/dom/workers/test/WorkerDebuggerGlobalScope.reportError_debugger.js b/dom/workers/test/WorkerDebuggerGlobalScope.reportError_debugger.js index 9d50dc67cd27..b3d8e5d440a8 100644 --- a/dom/workers/test/WorkerDebuggerGlobalScope.reportError_debugger.js +++ b/dom/workers/test/WorkerDebuggerGlobalScope.reportError_debugger.js @@ -7,6 +7,5 @@ this.onmessage = function (event) { break; case "throw": throw new Error("thrown"); - break; } }; diff --git a/dom/workers/test/WorkerDebugger_sharedWorker.js b/dom/workers/test/WorkerDebugger_sharedWorker.js index 18dfa87783ca..037abe6d6d13 100644 --- a/dom/workers/test/WorkerDebugger_sharedWorker.js +++ b/dom/workers/test/WorkerDebugger_sharedWorker.js @@ -11,7 +11,6 @@ self.onconnect = function (event) { close(); // Let's loop forever. while (1) {} - break; } }; }; diff --git a/dom/workers/test/dynamicImport_worker.js b/dom/workers/test/dynamicImport_worker.js index 44e5fc4e0aa5..90bd422efe8f 100644 --- a/dom/workers/test/dynamicImport_worker.js +++ b/dom/workers/test/dynamicImport_worker.js @@ -10,6 +10,5 @@ onmessage = function (event) { break; default: throw new Error("Bad message: " + event.data); - break; } }; diff --git a/dom/workers/test/importScripts_worker.js b/dom/workers/test/importScripts_worker.js index b206df1e754a..ca46c949b92c 100644 --- a/dom/workers/test/importScripts_worker.js +++ b/dom/workers/test/importScripts_worker.js @@ -56,7 +56,6 @@ onmessage = function (event) { break; default: throw new Error("Bad message: " + event.data); - break; } }; diff --git a/dom/workers/test/recursion_worker.js b/dom/workers/test/recursion_worker.js index 73c86358bcb3..84eb6d9740bf 100644 --- a/dom/workers/test/recursion_worker.js +++ b/dom/workers/test/recursion_worker.js @@ -42,5 +42,6 @@ onmessage = function (event) { throw "Weird number of messages: " + messageCount; } + // eslint-disable-next-line no-unreachable throw "Impossible to get here!"; }; diff --git a/dom/workers/test/sharedWorker_sharedWorker.js b/dom/workers/test/sharedWorker_sharedWorker.js index f5dd52d72b94..a7f859919f0f 100644 --- a/dom/workers/test/sharedWorker_sharedWorker.js +++ b/dom/workers/test/sharedWorker_sharedWorker.js @@ -80,6 +80,7 @@ onconnect = function (event) { // at us. (function () { return; + // eslint-disable-next-line no-unreachable 1; }); diff --git a/dom/workers/test/test_sharedWorker.html b/dom/workers/test/test_sharedWorker.html index b8ced379d53d..0a3cde2d32e8 100644 --- a/dom/workers/test/test_sharedWorker.html +++ b/dom/workers/test/test_sharedWorker.html @@ -22,7 +22,7 @@ const sentMessage = "ping"; const errorFilename = href.substring(0, href.lastIndexOf("/") + 1) + filename; - const errorLine = 97; + const errorLine = 98; const errorColumn = 11; var worker = new SharedWorker(filename);