From d6d99aaf8a2cb50b5abb36a44c652bda19b8e02d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Thu, 9 Jan 2020 19:08:30 +0000 Subject: [PATCH] Bug 1607408 - Remove InspectorUtils.getBindingURLs. r=jwatt Does nothing, and it's unused. Differential Revision: https://phabricator.services.mozilla.com/D58914 --HG-- extra : moz-landing-system : lando --- dom/chrome-webidl/InspectorUtils.webidl | 2 -- layout/inspector/InspectorUtils.cpp | 4 ---- layout/inspector/InspectorUtils.h | 3 --- layout/inspector/tests/test_bug462787.html | 8 -------- layout/inspector/tests/test_bug462789.html | 7 ------- 5 files changed, 24 deletions(-) diff --git a/dom/chrome-webidl/InspectorUtils.webidl b/dom/chrome-webidl/InspectorUtils.webidl index 9545e8272ac3..437f53629250 100644 --- a/dom/chrome-webidl/InspectorUtils.webidl +++ b/dom/chrome-webidl/InspectorUtils.webidl @@ -49,8 +49,6 @@ namespace InspectorUtils { Node? getParentForNode(Node node, boolean showingAnonymousContent); [NewObject] NodeList getChildrenForNode(Node node, boolean showingAnonymousContent); - // FIXME(emilio, bug 1607408): Remove this. - sequence getBindingURLs(Element element); [Throws] boolean setContentState(Element element, unsigned long long state); [Throws] boolean removeContentState( Element element, diff --git a/layout/inspector/InspectorUtils.cpp b/layout/inspector/InspectorUtils.cpp index d6f3078fa33c..78c4f5229379 100644 --- a/layout/inspector/InspectorUtils.cpp +++ b/layout/inspector/InspectorUtils.cpp @@ -510,10 +510,6 @@ bool InspectorUtils::IsValidCSSColor(GlobalObject& aGlobalObject, return ServoCSSParser::IsValidCSSColor(aColorString); } -void InspectorUtils::GetBindingURLs(GlobalObject& aGlobalObject, - Element& aElement, - nsTArray& aResult) {} - /* static */ bool InspectorUtils::SetContentState(GlobalObject& aGlobalObject, Element& aElement, uint64_t aState, diff --git a/layout/inspector/InspectorUtils.h b/layout/inspector/InspectorUtils.h index f1f4341c1578..85cf2d00e572 100644 --- a/layout/inspector/InspectorUtils.h +++ b/layout/inspector/InspectorUtils.h @@ -186,9 +186,6 @@ class InspectorUtils { static already_AddRefed GetChildrenForNode( nsINode& aNode, bool aShowingAnonymousContent); - static void GetBindingURLs(GlobalObject& aGlobal, Element& aElement, - nsTArray& aResult); - /** * Setting and removing content state on an element. Both these functions * call EventStateManager::SetContentState internally; the difference is diff --git a/layout/inspector/tests/test_bug462787.html b/layout/inspector/tests/test_bug462787.html index 72d24cb1d515..62548bd02c5d 100644 --- a/layout/inspector/tests/test_bug462787.html +++ b/layout/inspector/tests/test_bug462787.html @@ -54,14 +54,6 @@ function do_test() { is(e.name, "TypeError", "got the expected exception"); } - try { - InspectorUtils.getBindingURLs(null); - ok(false, "expected an exception"); - } - catch(e) { - is(e.name, "TypeError", "got the expected exception"); - } - try { InspectorUtils.getContentState(null); ok(false, "expected an exception"); diff --git a/layout/inspector/tests/test_bug462789.html b/layout/inspector/tests/test_bug462789.html index 285c940e57f3..e213fa831e62 100644 --- a/layout/inspector/tests/test_bug462789.html +++ b/layout/inspector/tests/test_bug462789.html @@ -58,13 +58,6 @@ function do_test() { } catch(e) { ok(false, "got an unexpected exception:" + e); } - try { - var res = InspectorUtils.getBindingURLs(docElement); - ok(Array.isArray(SpecialPowers.unwrap(res)), "getBindingURLs result type"); - is(res.length, 0, "getBindingURLs array length"); - } - catch(e) { ok(false, "got an unexpected exception:" + e); } - try { InspectorUtils.getContentState(docElement); ok(true, "Should not throw");