nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1762444 - Make no-addtask-setup eslint rule case-insensitive. r=Gijs

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D150329
This commit is contained in:
Mathew Hodson 2022-08-29 08:54:55 +00:00
parent 1f4593f091
commit d714558ef6
2 changed files with 11 additions and 4 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

8
tools/lint/eslint/eslint-plugin-mozilla/lib/rules/no-addtask-setup.js
View file

@ -9,9 +9,9 @@
"use strict";
// -----------------------------------------------------------------------------
// Rule Definition
// -----------------------------------------------------------------------------
function isNamedLikeSetup(name) {
return name.toLowerCase() === "setup";
}
module.exports = {
meta: {
@ -27,7 +27,7 @@ module.exports = {
if (
arg.type !== "FunctionExpression" ||
!arg.id ||
arg.id.name !== "setup"
!isNamedLikeSetup(arg.id.name)
) {
return;
}

7
tools/lint/eslint/eslint-plugin-mozilla/tests/no-addtask-setup.js
View file

@ -63,5 +63,12 @@ ruleTester.run("no-addtask-setup", rule, {
"Do not use add_task() for setup, use add_setup() instead."
),
},
{
code: "add_task(async function setUp() {});",
output: "add_setup(async function() {});",
errors: callError(
"Do not use add_task() for setup, use add_setup() instead."
),
},
],
});