nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1533429 - Return -1 for atk_text_get_caret_offset when we can't get the offset r=surkov

Browse source 
This makes Gecko conform to the newly documented expected behavior of ATK.

MozReview-Commit-ID: K9sRUDqeLq4

Differential Revision: https://phabricator.services.mozilla.com/D22550

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Martin Robinson 2019-03-07 18:07:24 +00:00
parent 338d8b76f5
commit d74ffde9eb
1 changed files with 2 additions and 2 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

4
accessible/atk/nsMaiInterfaceText.cpp
View file

@ -287,7 +287,7 @@ static gint getCaretOffsetCB(AtkText* aText) {
if (accWrap) { if (accWrap) {
HyperTextAccessible* text = accWrap->AsHyperText(); HyperTextAccessible* text = accWrap->AsHyperText();
if (!text || !text->IsTextRole()) { if (!text || !text->IsTextRole()) {
return 0; return -1;
} }
return static_cast<gint>(text->CaretOffset()); return static_cast<gint>(text->CaretOffset());
@ -297,7 +297,7 @@ static gint getCaretOffsetCB(AtkText* aText) {
return static_cast<gint>(proxy->CaretOffset()); return static_cast<gint>(proxy->CaretOffset());
} }
return 0; return -1;
} }
static AtkAttributeSet* getRunAttributesCB(AtkText* aText, gint aOffset, static AtkAttributeSet* getRunAttributesCB(AtkText* aText, gint aOffset,