nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1485862 - Set correct text-input-type for input[type=number]. r=surkov

Browse source
This commit is contained in:
Eitan Isaacson 2018-08-24 13:34:00 +03:00
parent dcedbb628b
commit dd36aade7d
2 changed files with 7 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

6
accessible/html/HTMLFormControlAccessible.cpp
View file

@ -307,7 +307,11 @@ HTMLTextFieldAccessible::NativeAttributes()
// Expose type for text input elements as it gives some useful context, // Expose type for text input elements as it gives some useful context,
// especially for mobile. // especially for mobile.
nsAutoString type; nsAutoString type;
if (mContent->AsElement()->GetAttr(kNameSpaceID_None, nsGkAtoms::type, type)) { // In the case of input[type=number], mContent is anonymous and is an
// input[type=text]. Getting the root not-anonymous content will give
// us the right type. In case of other input types, this returns the same node.
nsIContent* content = mContent->FindFirstNonChromeOnlyAccessContent();
if (content->AsElement()->GetAttr(kNameSpaceID_None, nsGkAtoms::type, type)) {
nsAccUtils::SetAccAttr(attributes, nsGkAtoms::textInputType, type); nsAccUtils::SetAccAttr(attributes, nsGkAtoms::textInputType, type);
if (!ARIARoleMap() && type.EqualsLiteral("search")) { if (!ARIARoleMap() && type.EqualsLiteral("search")) {
nsAccUtils::SetAccAttr(attributes, nsGkAtoms::xmlroles, nsAccUtils::SetAccAttr(attributes, nsGkAtoms::xmlroles,

2
accessible/tests/mochitest/attributes/test_obj.html
View file

@ -114,6 +114,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=558036
testAttrs("search", {"text-input-type": "search"}, true); testAttrs("search", {"text-input-type": "search"}, true);
testAttrs("tel", {"text-input-type": "tel"}, true); testAttrs("tel", {"text-input-type": "tel"}, true);
testAttrs("url", {"text-input-type": "url"}, true); testAttrs("url", {"text-input-type": "url"}, true);
testAttrs(getAccessible("number").firstChild, {"text-input-type": "number"}, true);
// ARIA // ARIA
testAttrs("searchbox", {"text-input-type": "search"}, true); testAttrs("searchbox", {"text-input-type": "search"}, true);
@ -220,6 +221,7 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=558036
<input id="search" type="search"/> <input id="search" type="search"/>
<input id="tel" type="tel"/> <input id="tel" type="tel"/>
<input id="url" type="url"/> <input id="url" type="url"/>
<input id="number" type="number"/>
<div id="searchbox" role="searchbox"></div> <div id="searchbox" role="searchbox"></div>
<!-- html --> <!-- html -->