Bug 1687136 - remove svg.transform-box.enabled pref r=emilio

It's been default true since Firefox 55 via bug 1208550

Differential Revision: https://phabricator.services.mozilla.com/D102093

devtools/shared/css/generated/properties-db.js

@@ -11032,10 +11032,6 @@ exports.PREFERENCES = [
     "touch-action",
     "layout.css.touch_action.enabled"
   ],
-  [
-    "transform-box",
-    "svg.transform-box.enabled"
-  ],
   [
     "-webkit-line-clamp",
     "layout.css.webkit-line-clamp.enabled"

layout/reftests/transform/reftest.list

@@ -126,11 +126,11 @@ fuzzy-if(skiaContent,0-2,0-5) == stresstest-1.html stresstest-1-ref.html
 == table-2b.html table-2-ref.html
 # Bug 722463
 == inline-1a.html inline-1-ref.html
-pref(svg.transform-box.enabled,true) == transform-box-svg-1a.svg transform-box-svg-1-ref.svg
-pref(svg.transform-box.enabled,true) == transform-box-svg-1b.svg transform-box-svg-1-ref.svg
-pref(svg.transform-box.enabled,true) == transform-box-svg-2a.svg transform-box-svg-2-ref.svg
-pref(svg.transform-box.enabled,true) == transform-box-svg-2b.svg transform-box-svg-2-ref.svg
-pref(svg.transform-box.enabled,true) == transform-box-svg-3a.svg pass.svg
+== transform-box-svg-1a.svg transform-box-svg-1-ref.svg
+== transform-box-svg-1b.svg transform-box-svg-1-ref.svg
+== transform-box-svg-2a.svg transform-box-svg-2-ref.svg
+== transform-box-svg-2b.svg transform-box-svg-2-ref.svg
+== transform-box-svg-3a.svg pass.svg
 == transform-origin-svg-1a.svg transform-origin-svg-1-ref.svg
 == transform-origin-svg-1b.svg transform-origin-svg-1-ref.svg
 == transform-origin-svg-2a.svg transform-origin-svg-2-ref.svg

layout/style/nsStyleTransformMatrix.cpp

@@ -13,7 +13,6 @@
 #include "nsPresContext.h"
 #include "mozilla/MotionPathUtils.h"
 #include "mozilla/ServoBindings.h"
-#include "mozilla/StaticPrefs_svg.h"
 #include "mozilla/StyleAnimationValue.h"
 #include "mozilla/SVGUtils.h"
 #include "gfxMatrix.h"
@@ -49,14 +48,7 @@ void TransformReferenceBox::EnsureDimensionsAreCached() {
   mIsCached = true;
 
   if (mFrame->HasAnyStateBits(NS_FRAME_SVG_LAYOUT)) {
-    if (!StaticPrefs::svg_transform_box_enabled()) {
-      mX = -mFrame->GetPosition().x;
-      mY = -mFrame->GetPosition().y;
-      Size contextSize = SVGUtils::GetContextSize(mFrame);
-      mWidth = nsPresContext::CSSPixelsToAppUnits(contextSize.width);
-      mHeight = nsPresContext::CSSPixelsToAppUnits(contextSize.height);
-    } else if (mFrame->StyleDisplay()->mTransformBox ==
-               StyleGeometryBox::FillBox) {
+    if (mFrame->StyleDisplay()->mTransformBox == StyleGeometryBox::FillBox) {
       // Percentages in transforms resolve against the SVG bbox, and the
       // transform is relative to the top-left of the SVG bbox.
       nsRect bboxInAppUnits = nsLayoutUtils::ComputeGeometryBox(

layout/style/test/property_database.js

@@ -3895,6 +3895,14 @@ var gCSSProperties = {
       "matrix3d(1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 20%, 10%, 15, 16)",
     ],
   },
+  "transform-box": {
+    domProp: "transformBox",
+    inherited: false,
+    type: CSS_TYPE_LONGHAND,
+    initial_values: ["border-box"],
+    other_values: ["fill-box", "view-box"],
+    invalid_values: ["content-box", "padding-box", "stroke-box", "margin-box"],
+  },
   "transform-origin": {
     domProp: "transformOrigin",
     inherited: false,
@@ -12023,17 +12031,6 @@ if (IsCSSPropertyPrefEnabled("layout.css.font-variations.enabled")) {
   );
 }
 
-if (IsCSSPropertyPrefEnabled("svg.transform-box.enabled")) {
-  gCSSProperties["transform-box"] = {
-    domProp: "transformBox",
-    inherited: false,
-    type: CSS_TYPE_LONGHAND,
-    initial_values: ["border-box"],
-    other_values: ["fill-box", "view-box"],
-    invalid_values: ["content-box", "padding-box", "stroke-box", "margin-box"],
-  };
-}
-
 var isGridTemplateSubgridValueEnabled = IsCSSPropertyPrefEnabled(
   "layout.css.grid-template-subgrid-value.enabled"
 );

layout/style/test/test_computed_style_prefs.html

@@ -68,8 +68,7 @@ function step() {
 // ----
 
 var gProps = {
-  "layout.css.touch_action.enabled": ["touch-action"],
-  "svg.transform-box.enabled": ["transform-box"]
+  "layout.css.touch_action.enabled": ["touch-action"]
 };
 
 var gCS = getComputedStyle(document.body, "");

modules/libpref/init/StaticPrefList.yaml

@@ -9708,12 +9708,6 @@
 # Prefs starting with "svg."
 #---------------------------------------------------------------------------
 
-# Is support for transform-box enabled?
-- name: svg.transform-box.enabled
-  type: bool
-  value: true
-  mirror: always
-
 # This pref controls whether the 'context-fill' and 'context-stroke' keywords
 # can be used in SVG-as-an-image in the content processes to use the fill/
 # stroke specified on the element that embeds the image. (These keywords are

servo/components/style/properties/longhands/box.mako.rs

@@ -573,7 +573,6 @@ ${helpers.single_keyword(
     "border-box fill-box view-box",
     engines="gecko",
     gecko_enum_prefix="StyleGeometryBox",
-    gecko_pref="svg.transform-box.enabled",
     spec="https://drafts.csswg.org/css-transforms/#transform-box",
     gecko_inexhaustive="True",
     animation_value_type="discrete",