nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1637617 - Adjusted message margins to prevent panel closing; added panel header to main view panel & updated fluent strings r=andreio,fluent-reviewers,flod

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D76162
This commit is contained in:
emcminn 2020-06-03 18:25:02 +00:00
parent 319d3205ce
commit de56c3d325
4 changed files with 36 additions and 5 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

3
browser/components/customizableui/content/panelUI.inc.xhtml
View file

@ -975,6 +975,9 @@
<panelview id="PanelUI-whatsNew" class="PanelUI-subView">
<vbox class="panel-subview-body">
<box id="PanelUI-whatsNew-title" class="panel-header">
<label data-l10n-id="whatsnew-panel-header"/>
</box>
<toolbaritem id="PanelUI-whatsNew-content"
orient="vertical"
smoothscroll="false">

2
browser/locales/en-US/browser/appmenu.ftl
View file

@ -22,6 +22,8 @@ fxa-toolbar-sync-now =
## What's New panel in App menu.
whatsnew-panel-header = What’s New
# Checkbox displayed at the bottom of the What's New panel, allowing users to
# enable/disable What's New notifications.
whatsnew-panel-footer-checkbox =

17
browser/themes/shared/customizableui/panelUI.inc.css
View file

@ -1856,6 +1856,11 @@ panelview[mainview] #PanelUI-whatsNew-content {
height: 43em;
}
/* Hide the What's New header when the panel is a subview */
panelview:not([mainview]) #PanelUI-whatsNew-title {
display: none;
}
#PanelUI-whatsNew .panel-subview-body {
padding-top: 0;
}
@ -1899,7 +1904,7 @@ panelview[mainview] #PanelUI-whatsNew-content {
border: 1px solid #A9A9A9;
border-radius: 2px;
margin: 0;
margin-inline-end: 10px;
margin-inline-end: 6px;
background-color: #FFF;
background-position: center;
background-repeat: no-repeat;
@ -1915,7 +1920,7 @@ panelview[mainview] #PanelUI-whatsNew-content {
#PanelUI-whatsNew .whatsNew-message {
cursor: pointer;
margin: 0 12px;
margin: 0;
padding: 0;
}
@ -1940,12 +1945,14 @@ panelview[mainview] #PanelUI-whatsNew-content {
font-size: .85em;
margin: -12px;
margin-top: 0;
margin-inline-start: 0;
padding: 6px 16px;
background: var(--arrowpanel-dimmed);
}
#PanelUI-whatsNew .whatsNew-message-body {
padding: 6px 6px 10px;
padding: 5px 0 10px;
margin-inline-start: 12px;
text-align: inherit;
text-decoration: none;
color: inherit;
@ -1970,7 +1977,7 @@ panelview[mainview] #PanelUI-whatsNew-content {
inset-inline-end: 6px;
height: 32px;
position: absolute;
top: 22px;
top: 24px;
width: 32px;
}
@ -1999,7 +2006,7 @@ panelview[mainview] #PanelUI-whatsNew-content {
#PanelUI-whatsNew .whatsNew-message-content {
display: block;
margin: 10px 0;
margin: 5px 0 10px;
}
#PanelUI-whatsNew .text-link {

19
python/l10n/fluent_migrations/bug_1637617_whatsnew_panel_header.py Normal file
View file

@ -0,0 +1,19 @@
# coding=utf8
# Any copyright is dedicated to the Public Domain.
# http://creativecommons.org/publicdomain/zero/1.0/
from __future__ import absolute_import
from fluent.migrate.helpers import transforms_from
def migrate(ctx):
"""Bug 1637617 - Adjusted message margins to prevent panel closing; added panel header to main view panel, part {index}."""
ctx.add_transforms(
"browser/browser/appmenu.ftl",
"browser/browser/appmenu.ftl",
transforms_from("""
whatsnew-panel-header = { COPY_PATTERN(from_path, "cfr-whatsnew-panel-header") }
""", from_path="browser/browser/newtab/asrouter.ftl"))