From debf431a77939ecb1994d124833e4d5552d50c01 Mon Sep 17 00:00:00 2001
From: Pierre-Yves David <pierre-yves.david@octobus.net>
Date: Wed, 1 May 2024 14:54:58 +0000
Subject: [PATCH] Bug 1894160: hgignore: drop the negative lookahead assertion
 around vscode; r=sheehan

This lookahead prevents the use of more modern and efficient regexp engine
slowing down status.

In practice we only have two vscode directory tracked in Mercurial:
* the root one, that see active development,
* the one in "remote/test/puppeteer/" that was never touched since its addition.

It is easy to not match the root in the hgignore, but harder for the other one.

Please note that once a file is tracked by Mercurial, the fact it is ignored or
not no longer matters, so in practice this will only affect "future" addition.

However the history shows that this addition are extremely rare (one in over 15
years) and that the only occurrence is some venturing, where the vscode file
seems less important.

So dropping this exception seems fine, the small inconvenience of having to
manually add the file in an hypothetical future is negligible compared to
concrete performance improvement of common operation to everyone.

See the other changesets dropping the second lookahead patterns for performance
number.

Differential Revision: https://phabricator.services.mozilla.com/D208967
---
 .gitignore | 8 ++------
 .hgignore  | 8 ++++----
 2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/.gitignore b/.gitignore
index 28c53adcd362..6eaf50745af7 100644
--- a/.gitignore
+++ b/.gitignore
@@ -293,13 +293,9 @@ toolchains.json
 lextab.py
 
 # Ignore Visual Studio/Visual Studio Code workspace files.
+# (but the root .vscode directory)
 .vs/
-# lint-ignore-next-line: syntax-difference
-.vscode/
-# lint-ignore-next-line: syntax-difference
-!.vscode/extensions.json
-# lint-ignore-next-line: syntax-difference
-!.vscode/tasks.json
+*/.vscode/
 *.user
 
 # Thunderbird source tree
diff --git a/.hgignore b/.hgignore
index a9d02a34e210..7a596d31e1b1 100644
--- a/.hgignore
+++ b/.hgignore
@@ -289,10 +289,10 @@ tps_result\.json$
 ^lextab\.py$
 
 # Ignore Visual Studio/Visual Studio Code workspace files.
-^\.vs/
-# lint-ignore-next-line: syntax-difference
-^\.vscode/(?!extensions\.json$|tasks\.json$)
-.*\.user$
+# (but the root .vscode directory)
+\.vs/
+.+/\.vscode/
+\.user$
 
 # Thunderbird source tree
 ^comm/