nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1495944: Add a test for shortcut keys on about:devtools-toolbox page. r=jdescottes

Browse source 
Depends on D16687

Differential Revision: https://phabricator.services.mozilla.com/D16788

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Daisuke Akatsuka 2019-01-18 16:27:00 +00:00
parent e31d28f2d6
commit df7a101bda
2 changed files with 95 additions and 0 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

1
devtools/client/aboutdebugging-new/test/browser/browser.ini
View file

@ -42,6 +42,7 @@ skip-if = (os == 'linux' && bits == 32) # ADB start() fails on linux 32, see Bug
[browser_aboutdebugging_devtools.js]
[browser_aboutdebugging_devtoolstoolbox_contextmenu.js]
[browser_aboutdebugging_devtoolstoolbox_menubar.js]
[browser_aboutdebugging_devtoolstoolbox_shortcuts.js]
[browser_aboutdebugging_navigate.js]
[browser_aboutdebugging_persist_connection.js]
[browser_aboutdebugging_routes.js]

94
devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_devtoolstoolbox_shortcuts.js Normal file
View file

@ -0,0 +1,94 @@
/* Any copyright is dedicated to the Public Domain.
http://creativecommons.org/publicdomain/zero/1.0/ */
"use strict";
/* import-globals-from helper-collapsibilities.js */
Services.scriptloader.loadSubScript(CHROME_URL_ROOT + "helper-collapsibilities.js", this);
/**
* Test shortcut keys on about:devtools-toolbox page.
*/
add_task(async function() {
info("Force all debug target panes to be expanded");
prepareCollapsibilitiesTest();
const { document, tab, window } = await openAboutDebugging();
info("Show about:devtools-toolbox page");
const target = findDebugTargetByText("about:debugging", document);
ok(target, "about:debugging tab target appeared");
const inspectButton = target.querySelector(".js-debug-target-inspect-button");
ok(inspectButton, "Inspect button for about:debugging appeared");
inspectButton.click();
await Promise.all([
waitUntil(() => tab.nextElementSibling),
waitForRequestsToSettle(window.AboutDebugging.store),
gDevTools.once("toolbox-ready"),
]);
info("Wait for about:devtools-toolbox tab will be selected");
const devtoolsTab = tab.nextElementSibling;
await waitUntil(() => gBrowser.selectedTab === devtoolsTab);
info("Check whether the shortcut keys which opens devtools is disabled");
await assertShortcutKeys(gBrowser.selectedBrowser, false);
info("Force to select about:debugging page");
gBrowser.selectedTab = tab;
info("Check whether the shortcut keys which opens devtools is enabled");
await assertShortcutKeys(gBrowser.selectedBrowser, true);
await removeTab(devtoolsTab);
await Promise.all([
waitForRequestsToSettle(window.AboutDebugging.store),
gDevTools.once("toolbox-destroyed"),
]);
await removeTab(tab);
});
async function assertShortcutKeys(browser, shouldBeEnabled) {
await assertShortcutKey(browser.contentWindow, "VK_F12", {}, shouldBeEnabled);
await assertShortcutKey(browser.contentWindow, "I", {
accelKey: true,
shiftKey: !navigator.userAgent.match(/Mac/),
altKey: navigator.userAgent.match(/Mac/),
}, shouldBeEnabled);
}
async function assertShortcutKey(win, key, modifiers, shouldBeEnabled) {
info(`Assert shortcut key [${ key }]`);
if (shouldBeEnabled) {
await assertShortcutKeyEnabled(win, key, modifiers);
} else {
await assertShortcutKeyDisabled(win, key, modifiers);
}
}
async function assertShortcutKeyDisabled(win, key, modifiers) {
let isReadyCalled = false;
const toolboxListener = () => {
isReadyCalled = true;
};
gDevTools.on("toolbox-ready", toolboxListener);
EventUtils.synthesizeKey(key, modifiers, win);
await wait(1000);
ok(!isReadyCalled, `Devtools should not be opened by ${ key }`);
gDevTools.off("toolbox-ready", toolboxListener);
}
async function assertShortcutKeyEnabled(win, key, modifiers) {
// Open devtools
const onToolboxReady = gDevTools.once("toolbox-ready");
EventUtils.synthesizeKey(key, modifiers, win);
await onToolboxReady;
ok(true, `Devtools should be opened by ${ key }`);
// Close devtools
const onToolboxDestroyed = gDevTools.once("toolbox-destroyed");
EventUtils.synthesizeKey(key, modifiers, win);
await onToolboxDestroyed;
ok(true, `Devtopls should be closed by ${ key }`);
}