diff --git a/.eslintignore b/.eslintignore index 171db4ff9428..fded29d8a802 100644 --- a/.eslintignore +++ b/.eslintignore @@ -167,7 +167,6 @@ dom/base/test/unit/test_serializers_entities*.js dom/base/test/unit_ipc/** dom/base/test/jsmodules/** dom/bindings/** -dom/browser-element/** dom/canvas/** dom/encoding/** dom/events/** diff --git a/dom/browser-element/BrowserElementChild.js b/dom/browser-element/BrowserElementChild.js index 796bbde38f2f..dc1c1c631379 100644 --- a/dom/browser-element/BrowserElementChild.js +++ b/dom/browser-element/BrowserElementChild.js @@ -2,6 +2,9 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this file, * You can obtain one at http://mozilla.org/MPL/2.0/. */ +/* eslint-env mozilla/frame-script */ +/* global api, CopyPasteAssistent */ + "use strict"; var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm"); diff --git a/dom/browser-element/BrowserElementChildPreload.js b/dom/browser-element/BrowserElementChildPreload.js index cfa62571b5e4..ec74b9fe99dd 100644 --- a/dom/browser-element/BrowserElementChildPreload.js +++ b/dom/browser-element/BrowserElementChildPreload.js @@ -4,6 +4,8 @@ "use strict"; +/* eslint-env mozilla/frame-script */ + function debug(msg) { // dump("BrowserElementChildPreload - " + msg + "\n"); } @@ -40,7 +42,7 @@ function sendSyncMsg(msg, data) { // Ensure that we don't send any messages before BrowserElementChild.js // finishes loading. if (!BrowserElementIsReady) { - return; + return undefined; } if (!data) { @@ -160,10 +162,8 @@ BrowserElementChild.prototype = { addMessageListener("browser-element-api:call", this); - let els = Cc["@mozilla.org/eventlistenerservice;1"] - .getService(Ci.nsIEventListenerService); LISTENED_SYSTEM_EVENTS.forEach(event => { - els.addSystemEventListener(global, event.type, this, event.useCapture); + Services.els.addSystemEventListener(global, event.type, this, event.useCapture); }); OBSERVED_EVENTS.forEach((aTopic) => { @@ -192,10 +192,8 @@ BrowserElementChild.prototype = { removeMessageListener("browser-element-api:call", this); - let els = Cc["@mozilla.org/eventlistenerservice;1"] - .getService(Ci.nsIEventListenerService); LISTENED_SYSTEM_EVENTS.forEach(event => { - els.removeSystemEventListener(global, event.type, this, event.useCapture); + Services.els.removeSystemEventListener(global, event.type, this, event.useCapture); }); OBSERVED_EVENTS.forEach((aTopic) => { @@ -281,6 +279,7 @@ BrowserElementChild.prototype = { if (message.data.msg_name in mmCalls) { return mmCalls[message.data.msg_name].apply(self, arguments); } + return undefined; }, _paintFrozenTimer: null, @@ -363,6 +362,7 @@ BrowserElementChild.prototype = { args.promptType == "custom-prompt") { return returnValue; } + return undefined; }, /** @@ -379,7 +379,7 @@ BrowserElementChild.prototype = { // I have no idea what waiting for a result means when there's no inner // window, so let's just bail. debug("_waitForResult: No inner window. Bailing."); - return; + return undefined; } this._windowIDDict[outerWindowID] = Cu.getWeakReference(win); @@ -902,7 +902,7 @@ BrowserElementChild.prototype = { if (menu) { this._maybeCopyAttribute(menu, menuObj, "label"); - for (var i = 0, child; child = menu.children[i++];) { + for (var i = 0, child; (child = menu.children[i++]);) { if (child.nodeName === "MENU") { menuObj.items.push(this._buildMenuObj(child, idPrefix + i + "_", false)); } else if (child.nodeName === "MENUITEM") { @@ -1026,8 +1026,7 @@ BrowserElementChild.prototype = { } // Remove password from uri. - location = Cc["@mozilla.org/docshell/urifixup;1"] - .getService(Ci.nsIURIFixup).createExposableURI(location); + location = Services.uriFixup.createExposableURI(location); var webNav = docShell.QueryInterface(Ci.nsIWebNavigation); @@ -1036,6 +1035,7 @@ BrowserElementChild.prototype = { canGoForward: webNav.canGoForward }); }, + // eslint-disable-next-line complexity onStateChange(webProgress, request, stateFlags, status) { if (webProgress != docShell) { return; diff --git a/dom/browser-element/BrowserElementCopyPaste.js b/dom/browser-element/BrowserElementCopyPaste.js index d40d8a84566c..a9d985d1fc11 100644 --- a/dom/browser-element/BrowserElementCopyPaste.js +++ b/dom/browser-element/BrowserElementCopyPaste.js @@ -6,6 +6,14 @@ "use strict"; +/* +global addMessageListener +global removeMessageListener +global docShell +global content +global sendAsyncMsg +*/ + function debug(msg) { // dump("BrowserElementCopyPaste - " + msg + "\n"); } @@ -71,7 +79,7 @@ var CopyPasteAssistent = { e.stopPropagation(); let boundingClientRect = e.boundingClientRect; - let canPaste = this._isCommandEnabled("paste"); + this._isCommandEnabled("paste"); let zoomFactor = content.innerWidth == 0 ? 1 : content.screen.width / content.innerWidth; let detail = { diff --git a/dom/browser-element/BrowserElementParent.jsm b/dom/browser-element/BrowserElementParent.jsm index 75062e8866d8..54642352a5bc 100644 --- a/dom/browser-element/BrowserElementParent.jsm +++ b/dom/browser-element/BrowserElementParent.jsm @@ -16,14 +16,6 @@ function debug(msg) { // dump("BrowserElementParent - " + msg + "\n"); } -function getIntPref(prefName, def) { - try { - return Services.prefs.getIntPref(prefName); - } catch (err) { - return def; - } -} - function handleWindowEvent(e) { if (this._browserElementParents) { let beps = ChromeUtils.nondeterministicGetWeakMapKeys(this._browserElementParents); @@ -96,11 +88,9 @@ BrowserElementParent.prototype = { this._window._browserElementParents = new WeakMap(); let handler = handleWindowEvent.bind(this._window); let windowEvents = ["visibilitychange", "fullscreenchange"]; - let els = Cc["@mozilla.org/eventlistenerservice;1"] - .getService(Ci.nsIEventListenerService); for (let event of windowEvents) { - els.addSystemEventListener(this._window, event, handler, - /* useCapture = */ true); + Services.els.addSystemEventListener(this._window, event, handler, + /* useCapture = */ true); } } @@ -138,7 +128,7 @@ BrowserElementParent.prototype = { receiveMessage(aMsg) { if (!this._isAlive()) { - return; + return undefined; } // Messages we receive are handed to functions which take a (data) argument, @@ -184,6 +174,7 @@ BrowserElementParent.prototype = { } else if (aMsg.data.msg_name in mmSecuritySensitiveCalls) { return mmSecuritySensitiveCalls[aMsg.data.msg_name].apply(this, arguments); } + return undefined; }, _removeMessageListener() { @@ -210,7 +201,6 @@ BrowserElementParent.prototype = { promptAuth(authDetail, callback) { let evt; - let self = this; let callbackCalled = false; let cancelCallback = function() { if (!callbackCalled) { diff --git a/dom/browser-element/BrowserElementPromptService.jsm b/dom/browser-element/BrowserElementPromptService.jsm index ab1f44bab887..95a880ab05f5 100644 --- a/dom/browser-element/BrowserElementPromptService.jsm +++ b/dom/browser-element/BrowserElementPromptService.jsm @@ -294,8 +294,6 @@ BrowserElementAuthPrompt.prototype = { return; let prompt = this._asyncPrompts[hashKey]; - let [hostname, httpRealm] = this._getAuthTarget(prompt.channel, - prompt.authInfo); this._asyncPromptInProgress.set(prompt.browserElementParent, true); prompt.inProgress = true; @@ -570,16 +568,14 @@ var BrowserElementPromptService = { // If the pref is disabled, do nothing except wait for the pref to change. if (!this._browserFramesPrefEnabled()) { - var prefs = Cc["@mozilla.org/preferences-service;1"].getService(Ci.nsIPrefBranch); - prefs.addObserver(BROWSER_FRAMES_ENABLED_PREF, this, /* ownsWeak = */ true); + Services.prefs.addObserver(BROWSER_FRAMES_ENABLED_PREF, this, /* ownsWeak = */ true); return; } this._initialized = true; this._browserElementParentMap = new WeakMap(); - var os = Cc["@mozilla.org/observer-service;1"].getService(Ci.nsIObserverService); - os.addObserver(this, "outer-window-destroyed", /* ownsWeak = */ true); + Services.obs.addObserver(this, "outer-window-destroyed", /* ownsWeak = */ true); // Wrap the existing @mozilla.org/prompter;1 implementation. var contractID = "@mozilla.org/prompter;1"; @@ -644,12 +640,7 @@ var BrowserElementPromptService = { }, _browserFramesPrefEnabled() { - var prefs = Cc["@mozilla.org/preferences-service;1"].getService(Ci.nsIPrefBranch); - try { - return prefs.getBoolPref(BROWSER_FRAMES_ENABLED_PREF); - } catch (e) { - return false; - } + return Services.prefs.getBoolPref(BROWSER_FRAMES_ENABLED_PREF, false); }, observe(subject, topic, data) { diff --git a/dom/browser-element/mochitest/async.js b/dom/browser-element/mochitest/async.js index e16513556f67..8afa3ab7664c 100644 --- a/dom/browser-element/mochitest/async.js +++ b/dom/browser-element/mochitest/async.js @@ -69,7 +69,7 @@ } ).catch(err => reject(err)); } - step(gen.next(value)); + return step(gen.next(value)); } }); }; diff --git a/dom/browser-element/mochitest/browserElement_Alert.js b/dom/browser-element/mochitest/browserElement_Alert.js index 846d1762adf8..9603ba69b2bc 100644 --- a/dom/browser-element/mochitest/browserElement_Alert.js +++ b/dom/browser-element/mochitest/browserElement_Alert.js @@ -4,6 +4,8 @@ // Test that alert works. "use strict"; +/* global browserElementTestHelpers */ + SimpleTest.waitForExplicitFinish(); browserElementTestHelpers.setEnabledPref(true); browserElementTestHelpers.addPermission(); diff --git a/dom/browser-element/mochitest/browserElement_AlertInFrame.js b/dom/browser-element/mochitest/browserElement_AlertInFrame.js index 5a2c3beb431f..77a9537a4167 100644 --- a/dom/browser-element/mochitest/browserElement_AlertInFrame.js +++ b/dom/browser-element/mochitest/browserElement_AlertInFrame.js @@ -4,6 +4,8 @@ // Test that alert works from inside an