nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1594515 - Pass INTERNET_FLAG_SECURE when using https symbol supplier. r=gsvelto

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D130927
This commit is contained in:
Will Kahn-Greene 2021-11-16 13:13:23 +00:00
parent 2ed21be3b6
commit e6d2fa42bb
1 changed files with 8 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

9
tools/crashreporter/minidump_stackwalk/http_symbol_supplier.cc
View file

@ -253,6 +253,7 @@ bool FetchURLToFile(HINTERNET session, const string& url, const string& file,
}
DWORD start = GetTickCount();
string scheme(comps.lpszScheme, comps.dwSchemeLength);
string host(comps.lpszHostName, comps.dwHostNameLength);
string path(comps.lpszUrlPath, comps.dwUrlPathLength);
HINTERNET conn = InternetConnectA(session, host.c_str(), comps.nPort, nullptr,
@ -263,8 +264,14 @@ bool FetchURLToFile(HINTERNET session, const string& url, const string& file,
return false;
}
DWORD flags = INTERNET_FLAG_NO_COOKIES;
if (strcmp(scheme.c_str(), "https") == 0) {
flags = flags | INTERNET_FLAG_SECURE;
BPLOG(INFO) << "HTTPSymbolSupplier: using HTTPS";
}
HINTERNET req = HttpOpenRequestA(conn, "GET", path.c_str(), nullptr, nullptr,
nullptr, INTERNET_FLAG_NO_COOKIES, 0);
nullptr, flags, 0);
if (!req) {
BPLOG(INFO) << "HTTPSymbolSupplier: HttpSendRequest: Error: "
<< GetLastError();