nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1863044 - remove unneeded variable and associated MOZ_ASSERT r=ipc-reviewers,nika

Browse source 
`mFileDialogInstance` is not needed, since we don't reuse old file-
dialog actors. (We _do_ reuse active file-dialog utility processes as
hosts for those actors; this check is a leftover from when that was
expected not to be the case.)

Differential Revision: https://phabricator.services.mozilla.com/D192983
This commit is contained in:
Ray Kraesig 2023-11-08 17:25:57 +00:00
parent 5e55c7effe
commit e722e487bb
2 changed files with 0 additions and 5 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

4
ipc/glue/UtilityProcessChild.cpp
View file

@ -310,9 +310,6 @@ mozilla::ipc::IPCResult UtilityProcessChild::RecvStartWinFileDialogService(
"UtilityProcessChild::RecvStartWinFileDialogService", OTHER, "UtilityProcessChild::RecvStartWinFileDialogService", OTHER,
MarkerOptions(MarkerTiming::IntervalUntilNowFrom(mChildStartTime))); MarkerOptions(MarkerTiming::IntervalUntilNowFrom(mChildStartTime)));
MOZ_RELEASE_ASSERT(!mFileDialogInstance,
"attempted to double-start file dialog service");
auto instance = MakeRefPtr<widget::filedialog::WinFileDialogChild>(); auto instance = MakeRefPtr<widget::filedialog::WinFileDialogChild>();
if (!instance) { if (!instance) {
return IPC_FAIL(this, "Failed to create WinFileDialogChild"); return IPC_FAIL(this, "Failed to create WinFileDialogChild");
@ -323,7 +320,6 @@ mozilla::ipc::IPCResult UtilityProcessChild::RecvStartWinFileDialogService(
return IPC_FAIL(this, "Failed to bind created WinFileDialogChild"); return IPC_FAIL(this, "Failed to bind created WinFileDialogChild");
} }
mFileDialogInstance = std::move(instance);
return IPC_OK(); return IPC_OK();
} }

1
ipc/glue/UtilityProcessChild.h
View file

@ -100,7 +100,6 @@ class UtilityProcessChild final : public PUtilityProcessChild {
RefPtr<dom::JSOracleChild> mJSOracleInstance{}; RefPtr<dom::JSOracleChild> mJSOracleInstance{};
#ifdef XP_WIN #ifdef XP_WIN
RefPtr<PWindowsUtilsChild> mWindowsUtilsInstance; RefPtr<PWindowsUtilsChild> mWindowsUtilsInstance;
RefPtr<PWinFileDialogChild> mFileDialogInstance;
#endif #endif
AsyncBlockers mShutdownBlockers; AsyncBlockers mShutdownBlockers;