nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1869472 - Make "Custom" variants use the same code path as others in AnimationValue::eq. r=zrhoffman,emilio

Browse source 
Differential Revision: https://phabricator.services.mozilla.com/D196993
This commit is contained in:
Ziran Sun 2024-01-03 10:07:28 +00:00
parent be4999cd86
commit ed8c7e5344
1 changed files with 21 additions and 24 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

45
servo/components/style/properties/helpers/animated_properties.mako.rs
View file

@ -162,32 +162,29 @@ impl PartialEq for AnimationValue {
fn eq(&self, other: &Self) -> bool {
use self::AnimationValue::*;
match (self, other) {
(Custom(animated_value1), Custom(animated_value2)) => {
*animated_value1 == *animated_value2
},
_ => {
unsafe {
let this_tag = *(self as *const _ as *const u16);
let other_tag = *(other as *const _ as *const u16);
if this_tag != other_tag {
return false;
}
unsafe {
let this_tag = *(self as *const _ as *const u16);
let other_tag = *(other as *const _ as *const u16);
if this_tag != other_tag {
return false;
}
match *self {
% for ty, props in groupby(animated, key=lambda x: x.animated_type()):
${" |\n".join("{}(ref this)".format(prop.camel_case) for prop in props)} => {
let other_repr =
&*(other as *const _ as *const AnimationValueVariantRepr<${ty}>);
*this == other_repr.value
}
% endfor
${" |\n".join("{}(void)".format(prop.camel_case) for prop in unanimated)} => {
void::unreachable(void)
},
AnimationValue::Custom(..) => { debug_unreachable!() },
}
match *self {
% for ty, props in groupby(animated, key=lambda x: x.animated_type()):
${" |\n".join("{}(ref this)".format(prop.camel_case) for prop in props)} => {
let other_repr =
&*(other as *const _ as *const AnimationValueVariantRepr<${ty}>);
*this == other_repr.value
}
% endfor
${" |\n".join("{}(void)".format(prop.camel_case) for prop in unanimated)} => {
void::unreachable(void)
},
AnimationValue::Custom(ref this) => {
let other_repr =
&*(other as *const _ as *const AnimationValueVariantRepr<CustomAnimatedValue>);
*this == other_repr.value
},
}
}
}