nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1803750 - Fix build breakage for Early Beta sim regarding refAsNonNull in WasmIonCompile.cpp. r=rhunt.

Browse source 
I believe bug 1799856 has caused this failure, by causing
FunctionCompiler::refAsNonNull (and its dependency ::compareIsNull) to be
guarded by ENABLE_WASM_FUNCTION_REFERENCES, whilst the uses are not similarly
guarded.

This patch makes those routines not be guarded by
ENABLE_WASM_FUNCTION_REFERENCES, so as to match the use points.

Differential Revision: https://phabricator.services.mozilla.com/D163734
This commit is contained in:
Julian Seward 2022-12-02 18:16:42 +00:00
parent 790e35aea5
commit f355713f7a
1 changed files with 1 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
js/src/wasm/WasmIonCompile.cpp
View file

@ -813,7 +813,6 @@ class FunctionCompiler {
curBlock_->setSlot(info().localSlot(slot), def); curBlock_->setSlot(info().localSlot(slot), def);
} }
#ifdef ENABLE_WASM_FUNCTION_REFERENCES
MDefinition* compareIsNull(MDefinition* value, JSOp compareOp) { MDefinition* compareIsNull(MDefinition* value, JSOp compareOp) {
MDefinition* nullVal = nullRefConstant(); MDefinition* nullVal = nullRefConstant();
if (!nullVal) { if (!nullVal) {
@ -850,6 +849,7 @@ class FunctionCompiler {
return true; return true;
} }
#ifdef ENABLE_WASM_FUNCTION_REFERENCES
bool brOnNull(uint32_t relativeDepth, const DefVector& values, bool brOnNull(uint32_t relativeDepth, const DefVector& values,
const ResultType& type, MDefinition* condition) { const ResultType& type, MDefinition* condition) {
if (inDeadCode()) { if (inDeadCode()) {