nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1596056 - Enable ESLint on reftest harness files (manual fixes). r=tnikkel

Browse source 
Depends on D189058

Differential Revision: https://phabricator.services.mozilla.com/D189059
This commit is contained in:
Mark Banner 2023-09-24 10:38:56 +00:00
parent a0c258004e
commit fae54d1098
4 changed files with 6 additions and 3 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
.eslintignore
View file

@ -24,6 +24,8 @@
# Also ignore reftest - specially crafted to produce expected output. # Also ignore reftest - specially crafted to produce expected output.
**/reftest/ **/reftest/
**/reftests/ **/reftests/
# Don't ignore the reftest harness files.
!/layout/tools/reftest/
# Exclude expected objdirs. # Exclude expected objdirs.
obj*/ obj*/

1
layout/tools/reftest/globals.jsm
View file

@ -162,6 +162,7 @@ for (let [key, val] of Object.entries({
dumpedConditionSandbox: false, dumpedConditionSandbox: false,
}, },
})) { })) {
// eslint-disable-next-line mozilla/reject-global-this
this[key] = val; this[key] = val;
EXPORTED_SYMBOLS.push(key); EXPORTED_SYMBOLS.push(key);
} }

2
layout/tools/reftest/manifest.jsm
View file

@ -682,7 +682,7 @@ function BuildConditionSandbox(aURL) {
sandbox.swgl = g.windowUtils.layerManagerType.startsWith( sandbox.swgl = g.windowUtils.layerManagerType.startsWith(
"WebRender (Software" "WebRender (Software"
); );
sandbox.layersOMTC = g.windowUtils.layerManagerRemote == true; sandbox.layersOMTC = !!g.windowUtils.layerManagerRemote;
// Shortcuts for widget toolkits. // Shortcuts for widget toolkits.
sandbox.Android = xr.OS == "Android"; sandbox.Android = xr.OS == "Android";

4
layout/tools/reftest/reftest-content.js
View file

@ -535,13 +535,13 @@ function WaitForTestEnd(
var operationInProgress = false; var operationInProgress = false;
function OperationInProgress() { function OperationInProgress() {
if (operationInProgress != false) { if (operationInProgress) {
LogWarning("Nesting atomic operations?"); LogWarning("Nesting atomic operations?");
} }
operationInProgress = true; operationInProgress = true;
} }
function OperationCompleted() { function OperationCompleted() {
if (operationInProgress != true) { if (!operationInProgress) {
LogWarning("Mismatched OperationInProgress/OperationCompleted calls?"); LogWarning("Mismatched OperationInProgress/OperationCompleted calls?");
} }
operationInProgress = false; operationInProgress = false;