Commit graph

628 commits

Author SHA1 Message Date
Ian Moody
011b59d595 Bug 1536556 - Replace raw thrown Cr.ERRORs with Components.Exception. r=mossop,remote-protocol-reviewers,marionette-reviewers,whimboo,necko-reviewers,geckoview-reviewers,valentin,agi
Raw Cr.ERROR don't get stack information, same as throwing JS literals instead
of `new Error()`s.

This was done automatically with a new eslint rule that will be introduced in
the next commit.  One instance of a raw Cr.ERROR was not replaced since it is
used in a test that specifically checks the preservation of raw Cr values in
XPCJS.  The rule will be disabled for that instance.

Differential Revision: https://phabricator.services.mozilla.com/D28073
2020-05-05 17:41:36 +00:00
Bianca Danforth
700da17102 Bug 1598464 - Stop pre-filtering logins from the context menu to about:logins. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D72780
2020-04-29 00:14:04 +00:00
Andreea Pavel
26c02e4ad0 Backed out 7 changesets (bug 1602075, bug 1551574) for failing multiple dt e.g. browser_accessibility_context_menu_inspector.js on a CLOSED TREE
Backed out changeset d878be5e1884 (bug 1551574)
Backed out changeset 2b11feb2473d (bug 1602075)
Backed out changeset 1406b19b25e9 (bug 1602075)
Backed out changeset 0aa8307788b6 (bug 1602075)
Backed out changeset 418dbded9752 (bug 1602075)
Backed out changeset 2c19213df4d7 (bug 1602075)
Backed out changeset 98a4b4e8fda3 (bug 1602075)
2020-04-27 20:23:42 +03:00
Yura Zenevich
f25cf1bb96 Bug 1602075 - display Inspect Accessibility Properties menu item if devtools.accessibility.auto-init.enabled pref is set to true. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D71586
2020-04-27 14:00:18 +00:00
Andreas Farre
6adf2b375d Bug 1576188 - Handle save-as for cross process iframes. r=peterv
Depends on D70388

Differential Revision: https://phabricator.services.mozilla.com/D70389
2020-04-27 05:41:40 +00:00
Dorel Luca
c2d429f9a0 Backed out 2 changesets (bug 1576188) for Build bustage in docshell/base/BrowsingContext.cpp. CLOSED TREE
Backed out changeset 7e5e86986811 (bug 1576188)
Backed out changeset b731cbad59a8 (bug 1576188)
2020-04-24 23:02:11 +03:00
Andreas Farre
55a186014d Bug 1576188 - Handle save-as for cross process iframes. r=peterv
Depends on D70388

Differential Revision: https://phabricator.services.mozilla.com/D70389
2020-04-24 15:47:26 +00:00
Arthur Iakab
c278cf13d3 Backed out 2 changesets (bug 1576188) for causing browser-chrome failures on browser_persist_cross_origin_iframe.js
CLOSED TREE

Backed out changeset d2c102f8d898 (bug 1576188)
Backed out changeset 9ddd9a63d178 (bug 1576188)
2020-04-23 19:38:58 +03:00
Csoregi Natalia
230cef6455 Backed out 6 changesets (bug 1602075) for devtools failures caused by markup-context-menu.js. CLOSED TREE
Backed out changeset cf06e30be068 (bug 1602075)
Backed out changeset 51f01135d82f (bug 1602075)
Backed out changeset fbb30bd09d66 (bug 1602075)
Backed out changeset e1e570497527 (bug 1602075)
Backed out changeset 3aa7f4f31934 (bug 1602075)
Backed out changeset 7d568f0fa1e4 (bug 1602075)
2020-04-23 19:03:05 +03:00
Yura Zenevich
cfeeac415d Bug 1602075 - display Inspect Accessibility Properties menu item if devtools.accessibility.auto-init.enabled pref is set to true. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D71586
2020-04-23 14:40:17 +00:00
Andreas Farre
6a4f39685d Bug 1576188 - Handle save-as for cross process iframes. r=peterv
Depends on D70388

Differential Revision: https://phabricator.services.mozilla.com/D70389
2020-04-23 13:56:26 +00:00
Gijs Kruitbosch
1c0a1c9f3e Bug 1631358 - remove traces of CPOWs from browser/, testing/ and toolkit/, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D71510
2020-04-21 14:05:35 +00:00
Gijs Kruitbosch
971ae919c8 Bug 1616881 - remove saveImageURL which, besides the now-dead CPOW checks, just calls internalSave, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D70684

--HG--
extra : moz-landing-system : lando
2020-04-13 17:43:22 +00:00
Matthew Noorenberghe
3f7f09f6df Bug 1625075 - Use HTMLInputElement.hasBeenTypePassword for the context menu. r=sfoster
* Remove usernameField from getFieldContext since it isn't used if we return the state of the specified field. Then we don't need the hacky override for usernameField depending on hasBeenTypePassword.
* Return early in LMP._onPasswordEditedOrGenerated if the tab closes to address a test failure in browser_context_menu.js.

Differential Revision: https://phabricator.services.mozilla.com/D69314

--HG--
extra : moz-landing-system : lando
2020-04-02 22:28:09 +00:00
Masatoshi Kimura
3df19bc1d4 Bug 1623222 - Remove the charset parameter from nsITextToSubURI::UnEscapeURIForUI. r=hsivonen
Only 3 callers are using a non-UTF-8 charset as the first parameter.
* MediaDocument.cpp: This does not make sense because the "filename" part of
  URLs will always be encoded with UTF-8.
* nsContextMenu.js: This is wrong because "mailto:" URLs don't care about the
  document charset.
* Finder.jsm: This caused bug 1623222.

Differential Revision: https://phabricator.services.mozilla.com/D67386

--HG--
extra : moz-landing-system : lando
2020-03-19 10:45:28 +00:00
Neil Deakin
55da8f6ebd Bug 1621298, remove unused messageManager use from nsContextMenu.js, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D66230

--HG--
extra : moz-landing-system : lando
2020-03-10 16:42:39 +00:00
Matthew Noorenberghe
06bbe43c45 Bug 1615220 - Disable password generation when master password is locked. r=jaws
This aligns with the behaviour before bug 1595915 since password generation was nested under the disabled "Fill (username|password)" option.

Differential Revision: https://phabricator.services.mozilla.com/D64405

--HG--
extra : moz-landing-system : lando
2020-02-28 16:04:46 +00:00
Marco Bonardo
8e3ea27643 Bug 1612653 - Update 'Bookmark This Page' menuitems when the star state changes. r=Standard8
Instead of updating the Bookmark This Page / Edit Bookmark menuteitems on popupshowing,
update them when the star button is suppposed to change. This better supports MacOS behavior
where the native menubar can't be updated after being shown, and avoids many callpoints in
favor of just a few.

Differential Revision: https://phabricator.services.mozilla.com/D64399

--HG--
extra : moz-landing-system : lando
2020-02-27 12:04:15 +00:00
Bogdan Tara
e5bd696ee3 Backed out changeset fbc90d35117e (bug 1615220) for browser_autocomplete_generated_password_private_window.js failures CLOSED TREE 2020-02-26 23:19:40 +02:00
Matthew Noorenberghe
0adc7718cf Bug 1615220 - Disable password generation when master password is locked. r=jaws
This aligns with the behaviour before bug 1595915 since password generation was nested under the disabled "Fill (username|password)" option.

Differential Revision: https://phabricator.services.mozilla.com/D64405

--HG--
extra : moz-landing-system : lando
2020-02-26 19:02:49 +00:00
Jonas Jenwald
601789bfbc Bug 1593235 - Hide the "View Background Image" context menu option in the PDF Viewer. r=bdahl
Given that the "View Background Image" option never makes sense in the PDF Viewer, it's simply always removed from the context menu.

Differential Revision: https://phabricator.services.mozilla.com/D52599

--HG--
extra : moz-landing-system : lando
2020-02-12 09:40:37 +00:00
Jared Wein
4c27f9fc7d Bug 1613731 - Move the 'fill login' menuitem up to the top of the context menu. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D61919

--HG--
extra : moz-landing-system : lando
2020-02-07 21:02:09 +00:00
Razvan Maries
fb4e88935e Backed out changeset f15513c3ad0e (bug 1613731) for Mochitest perma failures. CLOSED TREE 2020-02-07 21:12:16 +02:00
Jared Wein
10c19a0f81 Bug 1613731 - Move the 'fill login' menuitem up to the top of the context menu. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D61919

--HG--
extra : moz-landing-system : lando
2020-02-06 20:15:00 +00:00
Neil Deakin
0355257f83 Bug 1505915, move view source components to use JSWindowActor. This allows view frame source to work in out of process child frames, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D60253

--HG--
rename : toolkit/components/viewsource/content/viewSource-content.js => toolkit/actors/ViewSourceChild.jsm
rename : toolkit/components/viewsource/content/viewSource-content.js => toolkit/actors/ViewSourcePageChild.jsm
rename : toolkit/components/viewsource/ViewSourceBrowser.jsm => toolkit/actors/ViewSourcePageParent.jsm
extra : moz-landing-system : lando
2020-01-24 19:53:55 +00:00
Matthew Noorenberghe
3f6697449b Bug 1595915 - Move the password generation context menu item to the top-level. r=sfoster,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D60640

--HG--
extra : moz-landing-system : lando
2020-01-23 23:01:04 +00:00
Andreea Pavel
a34592d2b5 Backed out 2 changesets (bug 1595915) for failing fission bc at browser/browser_context_menu_iframe.js on a CLOSED TREE
Backed out changeset d844b69b9fbd (bug 1595915)
Backed out changeset 8e751164816c (bug 1595915)
2020-01-24 00:23:40 +02:00
Matthew Noorenberghe
cb2556b19d Bug 1595915 - Move the password generation context menu item to the top-level. r=sfoster,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D60640

--HG--
extra : moz-landing-system : lando
2020-01-23 20:19:17 +00:00
Gijs Kruitbosch
0606b71ddb Bug 1526731 - pass content policy to webbrowserpersist to improve image request headers, r=smaug,johannh
Differential Revision: https://phabricator.services.mozilla.com/D60567

--HG--
extra : moz-landing-system : lando
2020-01-23 08:36:00 +00:00
Ciure Andrei
d35aa07785 Backed out 2 changesets (bug 1595915) for causing browser_contextmenuFillLogins.js perma fails CLOSED TREE
Backed out changeset 5675d8e0f9f5 (bug 1595915)
Backed out changeset 9ef66fee0f47 (bug 1595915)
2020-01-23 06:49:47 +02:00
Matthew Noorenberghe
3248d7392d Bug 1595915 - Move the password generation context menu item to the top-level. r=sfoster,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D60640

--HG--
extra : moz-landing-system : lando
2020-01-23 03:43:40 +00:00
Neil Deakin
3d7ffd608a Bug 1603020, allow sendMessageToActor to send the message to all descendants, not just process roots, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D58990

--HG--
extra : moz-landing-system : lando
2020-01-20 15:14:31 +00:00
Emma Malysz
57215abe07 Bug 1601094, rename the remaining .xul files in browser/ to .xhtml r=marionette-reviewers,whimboo,mossop
Differential Revision: https://phabricator.services.mozilla.com/D55751

--HG--
rename : browser/base/content/aboutDialog.xul => browser/base/content/aboutDialog.xhtml
rename : browser/base/content/newInstall.xul => browser/base/content/newInstall.xhtml
rename : browser/base/content/pageinfo/pageInfo.xul => browser/base/content/pageinfo/pageInfo.xhtml
rename : browser/base/content/safeMode.xul => browser/base/content/safeMode.xhtml
rename : browser/base/content/sanitize.xul => browser/base/content/sanitize.xhtml
rename : browser/base/content/titlebar-items.inc.xul => browser/base/content/titlebar-items.inc.xhtml
rename : browser/base/content/webext-panels.xul => browser/base/content/webext-panels.xhtml
rename : browser/base/content/webrtcIndicator.xul => browser/base/content/webrtcIndicator.xhtml
rename : browser/components/downloads/content/contentAreaDownloadsView.xul => browser/components/downloads/content/contentAreaDownloadsView.xhtml
rename : browser/components/migration/content/migration.xul => browser/components/migration/content/migration.xhtml
rename : browser/components/places/content/bookmarkProperties.xul => browser/components/places/content/bookmarkProperties.xhtml
rename : browser/components/places/content/bookmarksSidebar.xul => browser/components/places/content/bookmarksSidebar.xhtml
rename : browser/components/places/content/historySidebar.xul => browser/components/places/content/historySidebar.xhtml
rename : browser/components/places/content/places.xul => browser/components/places/content/places.xhtml
rename : browser/components/shell/content/setDesktopBackground.xul => browser/components/shell/content/setDesktopBackground.xhtml
extra : moz-landing-system : lando
2019-12-11 00:27:19 +00:00
Jonathan Watt
8b155d8f62 Bug 1602561. Make PrintUtils.printWindow() act on a BrowsingContext. r=Gijs
Factored out from patches to make printing work with Fission enabled.

Differential Revision: https://phabricator.services.mozilla.com/D56436

--HG--
extra : moz-landing-system : lando
2019-12-10 21:59:02 +00:00
Matthew Noorenberghe
7dca7daa86 Bug 1599752 - Partial back out of changeset c72321ba48b8 to remove subdomain suggestions in the context menu.
Differential Revision: https://phabricator.services.mozilla.com/D54937

--HG--
extra : moz-landing-system : lando
2019-11-27 14:25:19 +00:00
Mike Conley
e819bd0638 Bug 1597787 - Send principals directly across JSWindowActors rather than serializing / deserializing them. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D53867

--HG--
extra : moz-landing-system : lando
2019-11-23 00:53:52 +00:00
Matthew Noorenberghe
66f2568013 Bug 1566536 - Support password generation in private windows. r=sfoster
* Inform users in autocomplete that using a generated password will cause it to be automatically saved.
* Don't fill generated passwords from the context menu directly, that menu item (renamed) should simply force the generation UI to appear in autocomplete.

Differential Revision: https://phabricator.services.mozilla.com/D54338

--HG--
extra : moz-landing-system : lando
2019-11-23 03:26:03 +00:00
Matthew Noorenberghe
5899ac5cb2 Bug 1200472 - Include subdomain login fill suggestions in the context menu. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D51354

--HG--
extra : moz-landing-system : lando
2019-11-15 01:03:48 +00:00
Mike Conley
62940db419 Bug 1592729 - Hide the Picture-in-Picture context menu item for MediaStream videos. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D51157

--HG--
extra : moz-landing-system : lando
2019-10-31 14:36:30 +00:00
Julian Descottes
c72c1dcdcc Bug 1588773 - Use ContentDOMReference for context menu Inspect Element r=mconley,pbro
Depends on D49941

Using ContentDOMReference instead of creating an array of selectors makes inspect element more stable in case the page is modified between after the contextmenu opens.
It will also make the feature easier to make fission compatible

Differential Revision: https://phabricator.services.mozilla.com/D49303

--HG--
extra : moz-landing-system : lando
2019-10-28 09:10:29 +00:00
Dão Gottwald
eda4c79a87 Bug 1589328 - Remove global-scope pollution from nsContextMenu.js. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D49583

--HG--
extra : moz-landing-system : lando
2019-10-21 13:40:00 +00:00
Dão Gottwald
79806540d1 Bug 1588813 - Remove redundant imports and service getters from browser-fullScreenAndPointerLock.js and nsContextMenu.js. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D49298

--HG--
extra : moz-landing-system : lando
2019-10-15 15:06:22 +00:00
Mike de Boer
87107fa64b Bug 1563024 - Add a context menu item for the in-content popup to allow to perform a search in a new private window, using a private browsing mode default search engine. r=jaws,mak
Differential Revision: https://phabricator.services.mozilla.com/D48672

--HG--
extra : moz-landing-system : lando
2019-10-10 22:49:06 +00:00
Michael Kaply
d3547ee818 Bug 158968 - Implement kiosk mode. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D41848

--HG--
extra : moz-landing-system : lando
2019-10-04 19:47:56 +00:00
monikamaheshwari
9d60e0d578 Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629

--HG--
extra : moz-landing-system : lando
2019-09-14 09:39:26 +00:00
Emma Malysz
392fe89b3a Bug 1569738, make PageInfo fission compatible r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D42978

--HG--
extra : moz-landing-system : lando
2019-08-29 20:31:19 +00:00
Thomas Nguyen
c175f3d626 Bug 1576347 - Correct referrerInfo when saving media and add a test of "Go To Download Page" button r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D43749

--HG--
extra : moz-landing-system : lando
2019-08-30 18:38:38 +00:00
Mark Banner
511a7ababf Bug 1562929 - Use the default private search engine in the context menu. r=daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D43771

--HG--
extra : moz-landing-system : lando
2019-08-29 14:43:43 +00:00
Sam Foster
f84227e740 Bug 1571700 - Don't show fill logins context menu item in about: pages. r=MattN
* Skip showing the password manager items in the context menu from an about: page

Differential Revision: https://phabricator.services.mozilla.com/D42963

--HG--
extra : moz-landing-system : lando
2019-08-21 22:01:26 +00:00
Matthew Noorenberghe
a846d2015c Bug 1569093 - Don't offer pwgen via the context menu on sites where the user disabled pw saving. r=sfoster
Depends on D39937

Differential Revision: https://phabricator.services.mozilla.com/D39938

--HG--
extra : moz-landing-system : lando
2019-07-31 19:21:52 +00:00