Commit graph

20 commits

Author SHA1 Message Date
Brian Grinstead
193683f1c6 Bug 1592054 - Initialize tabbrowser-tab contents before appending it into the DOM r=dao
This prevents a brief flash of unstyled tab content that can be noticed especially
in debug builds.

What happens currently is that we first append child content into the tab
upon connection, then we do attribute inheritance which sets the relevant
styling properties.

With this change we first set up the child content and attributes _before_ appending
the tab into the DOM, so that it's ready to render after being appended.

Differential Revision: https://phabricator.services.mozilla.com/D50837

--HG--
extra : moz-landing-system : lando
2019-10-29 17:23:29 +00:00
Brian Grinstead
997857d2d9 Bug 1590554 - Cache the parsed tabbrowser-tab fragment on the constructor instead of on each element;r=Gijs
This means we only need to call parseXULToFragment a max of once per document
instead of a maximum of once per tab (which in practice isn't any better than
not caching since we only run connectedCallback logic once per tab).

Differential Revision: https://phabricator.services.mozilla.com/D50137

--HG--
extra : moz-landing-system : lando
2019-10-22 22:44:52 +00:00
Abdoulaye Oumar Ly
70d817b8d5 Bug 1481055 - Improve the consistency of params of tab multiselection functions in gBrowser. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D36356

--HG--
extra : moz-landing-system : lando
2019-07-22 17:16:40 +00:00
Narcis Beleuzu
a30f010301 Backed out changeset ff49c94ed1d2 (bug 1481055) for bc failures on browser_multiselect_tabs_using_keyboard.js . CLOSED TREE 2019-07-18 23:10:58 +03:00
Abdoulaye O. Ly
edb8d71d8c Bug 1481055 - Improve the consistency of params of tab multiselection functions in gBrowser. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D36356

--HG--
extra : moz-landing-system : lando
2019-07-11 18:43:05 +00:00
James Teh
0faff9a8fe Bug 1410757: Expose the info provided in the tool tip for the focused browser tab as the tab's accessible description. r=Gijs
The tool tip for a browser tab exposes information such as the process ids (on Nightly) and the container tab name.
It appears when a user mouses over the tab, but this isn't really accessible to screen reader users.
Ideally, we'd expose this information as the accessible description for all browser tabs.
However, doing this for all tabs and keeping it up to date is rather difficult and potentially expensive.
Instead, just expose this description for a tab when it gets focus; i.e. the user has to focus the tab bar to access it.

To enable this, XUL tab elements now fire an AriaFocus event on the ARIA focused tab when the ariaFocusedItem property is set.

Differential Revision: https://phabricator.services.mozilla.com/D38027

--HG--
extra : moz-landing-system : lando
2019-07-15 11:21:15 +00:00
Victor Porof
f9f5914039 Bug 1561435 - Format browser/base/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36041

--HG--
extra : source : 96b3895a3b2aa2fcb064c85ec5857b7216884556
2019-07-05 09:48:57 +02:00
Andrew Swan
f1d137eff5 Bug 1555060 Stop using dom structure for <tabs>/<tab> relationships
A bunch of existing code assumes that <tab> elements are the immediate
and only children of a <tabs> element, and uses dom apis to traverse
relationships between these elements.  To simplify conversion of <tabs>
to a custom element (and hopefully improve readability a bit at the same
time!), introduce new apis:

On <tab>
this.parentNode -> this.container
this.nextElementSibling -> this.container.findNextTab(...)
this.previousElementSibiling -> this.container.findNextTab(...)

On <tabs>
this.children -> this.allTabs

Differential Revision: https://phabricator.services.mozilla.com/D34648

--HG--
extra : source : f4e21e465f384b90fa1e768141c4db708748bf66
extra : histedit_source : 95d8a4242e8e04df9e29c2b647558d37e910b845
2019-06-11 14:49:46 -07:00
Ciure Andrei
c04368fddd Backed out 3 changesets (bug 1555060) for causing test_tabbar.py to perma fail CLOSED TREE
Backed out changeset a5c6deeda8a9 (bug 1555060)
Backed out changeset f4e21e465f38 (bug 1555060)
Backed out changeset c71c45fe3e63 (bug 1555060)

--HG--
rename : browser/base/content/tabbrowser-tabs.js => browser/base/content/tabbrowser.xml
2019-06-28 00:21:50 +03:00
Andrew Swan
6fd54d15e6 Bug 1555060 Stop using dom structure for <tabs>/<tab> relationships
A bunch of existing code assumes that <tab> elements are the immediate
and only children of a <tabs> element, and uses dom apis to traverse
relationships between these elements.  To simplify conversion of <tabs>
to a custom element (and hopefully improve readability a bit at the same
time!), introduce new apis:

On <tab>
this.parentNode -> this.container
this.nextElementSibling -> this.container.findNextTab(...)
this.previousElementSibiling -> this.container.findNextTab(...)

On <tabs>
this.children -> this.allTabs

Differential Revision: https://phabricator.services.mozilla.com/D34648

--HG--
extra : rebase_source : affeda0295a5195124709f322de524aea3a28a3f
2019-06-11 14:49:46 -07:00
meandave
a41d4f81aa Bug 1554579 - Pinned tab becomes too wide when picture-in-picture icon is present. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D34418

--HG--
extra : moz-landing-system : lando
2019-06-24 16:10:58 +00:00
Karan Sapolia
1a5439aa95 Bug 1557281 - Clean up MozTabbrowserTab fragment markup. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D33957

--HG--
extra : moz-landing-system : lando
2019-06-07 12:34:26 +00:00
Dão Gottwald
703d67b283 Bug 1556196 - Clean up interaction between MozTabbrowserTab::on_mousedown and MozTab::on_mousedown. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D33412

--HG--
extra : moz-landing-system : lando
2019-06-04 21:20:46 +00:00
Alexander Surkov
b73a345486 Bug 1555943 - Update outdated comment referring to XBL field behavior, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D33268

--HG--
extra : moz-landing-system : lando
2019-06-01 21:53:36 +00:00
Dão Gottwald
b6e691a46f Bug 1555929 - Use handleEvent and on_<event name> pattern in MozTab and MozTabbrowserTab. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D33272

--HG--
extra : moz-landing-system : lando
2019-05-31 17:32:26 +00:00
Alexander Surkov
452c2f3269 Bug 1519514 - convert tabbrowser-tab binding to a Custom Element, r=aswan
Differential Revision: https://phabricator.services.mozilla.com/D28662

--HG--
extra : source : 8488d800a7856b6dc4a1619592fc776dc1a5e444
2019-05-28 22:00:28 +00:00
Alexander Surkov
31d477bd4a Bug 1519514 - hg copy tabbrowser.xml to tabbrowser-tabs.js to preserve history for tab binding conversion to a Custom Element, r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D26601

--HG--
rename : browser/base/content/tabbrowser.xml => browser/base/content/tabbrowser-tab.js
extra : source : 858b9456eb3c8b081d652468afdefd7cbf79538c
2019-05-28 22:00:18 +00:00
Cosmin Sabou
fa7207a14d Backed out 4 changesets (bug 1519514) for causing several browser chrome failures. CLOSED TREE
Backed out changeset 485c2c76fab6 (bug 1519514)
Backed out changeset 8488d800a785 (bug 1519514)
Backed out changeset 858b9456eb3c (bug 1519514)
Backed out changeset 2cd983857de6 (bug 1519514)
2019-05-29 11:01:47 +03:00
Alexander Surkov
0f1bc68db8 Bug 1519514 - convert tabbrowser-tab binding to a Custom Element, r=aswan
Differential Revision: https://phabricator.services.mozilla.com/D28662

--HG--
extra : moz-landing-system : lando
2019-05-28 22:00:28 +00:00
Alexander Surkov
0d427d4360 Bug 1519514 - hg copy tabbrowser.xml to tabbrowser-tabs.js to preserve history for tab binding conversion to a Custom Element, r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D26601

--HG--
rename : browser/base/content/tabbrowser.xml => browser/base/content/tabbrowser-tab.js
extra : moz-landing-system : lando
2019-05-28 22:00:18 +00:00