nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
742446 commits 1 branch 98 tags 6.4 GiB
Commit graph

54 commits

Author SHA1 Message Date
Mark Banner
787d4fd95d Bug 1686226 - Add references to the Matrix Lint & Formatting room in the coding style docs. r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D101463
 2021-01-12 15:04:35 +00:00
Kartik Gautam
8828f6896c Bug 1682817 - Make whitespace/newline linter also fail for absent newline character at the end of files and also implement fix for it r=sylvestre 
Depends on D100484

Differential Revision: https://phabricator.services.mozilla.com/D100443
 2021-01-07 08:53:16 +00:00
Kartik Gautam
5a1125a101 Bug 1675131 - Make whitespace / newline linter also fail for missing empty lines at the end of files. r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D98000
 2020-12-15 21:49:43 +00:00
Butkovits Atila
cd73ee5d0b Backed out changeset eb6cdd43ce2e (bug 1677549) as requested by Simon. CLOSED TREE 2020-12-14 17:32:44 +02:00
Simon Giesecke
ba0db06d63 Bug 1677549 - Add some guidelines on include directives and header files to the coding style. r=andi,sylvestre,asuth 
Differential Revision: https://phabricator.services.mozilla.com/D97916
 2020-12-11 10:35:54 +00:00
Sylvestre Ledru
38008eb1cd Bug 1676514 - Add --fix to mozlint/clippy 
I will add a test once this feature is considered as stable upstream

Differential Revision: https://phabricator.services.mozilla.com/D96634
 2020-11-17 12:03:33 +00:00
Sylvestre Ledru
31b3856da6 Bug 1667831 - doc: fix more pygments r=firefox-source-docs-reviewers,championshuttler DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D91868
 2020-09-30 07:03:41 +00:00
Sylvestre Ledru
3c813005a1 Bug 1667831 - doc: fix more warnings r=firefox-source-docs-reviewers,ahal DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D91642
 2020-09-29 18:48:17 +00:00
Sylvestre Ledru
6be67c14c4 Bug 1667831 - doc: refresh links as many pages moved in-tree r=firefox-source-docs-reviewers,ahal DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D91619
 2020-09-29 17:53:54 +00:00
ruchikabgosain
5e3cc11a26 Bug 1587022 - Improve documentation for Mozilla specific ESLint rules. r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D52626
 2020-09-29 15:18:56 +00:00
Markus Stange
9aa3b6a184 Bug 1667463 - Fix two typos in using_cxx_in_firefox_code.rst. r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D91472
 2020-09-25 20:25:23 +00:00
Simon Giesecke
3abd6dca98 Bug 1648010 - Update coding style with respect to string literals. r=froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D81503
 2020-07-21 11:24:06 +00:00
Sylvestre Ledru
f23398e021 no bug - Update the pylint doc r=andi DONTBUILD 
Also do that to verify reviewbot

Differential Revision: https://phabricator.services.mozilla.com/D90075
 2020-09-14 10:34:37 +00:00
Bryce Seager van Dyk
0c45c50c1f Bug 1659726 - Fix mode line docs to use 2 space indents rather than 8. r=sylvestre DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D87448
 2020-08-19 07:51:42 +00:00
Sylvestre Ledru
5ea6c250c3 Bug 1657926 - firefox doc: fix some warnings r=championshuttler 
Differential Revision: https://phabricator.services.mozilla.com/D86732
 2020-08-11 23:20:25 +00:00
Simon Giesecke
ee62debaab Bug 1653532 - Improve reference of Google Coding Style for C++ Code. r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D83923
 2020-08-04 08:31:17 +00:00
Sylvestre Ledru
d9d0eda42a no bug - python CS doc - point to our linters r=marco 
Differential Revision: https://phabricator.services.mozilla.com/D82897
 2020-07-10 12:50:25 +00:00
Tom Prince
2244b1cc7c Bug 1651731: [lint] Only allow files that are typically executable to have shebang lines override permission check; r=linter-reviewers,sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D82949
 2020-07-09 21:16:32 +00:00
Chris AtLee
d1fb386dae Bug 1555560: Add support for black formatting with mozlint; r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D33125
 2020-07-08 22:08:08 +00:00
Mihai Alexandru Michis
5f385df474 Backed out 2 changesets (bug 1555560) for causing multiple lint failures. 
CLOSED TREE

Backed out changeset bd9460ac6e48 (bug 1555560)
Backed out changeset f2896032ced6 (bug 1555560)
 2020-07-09 01:04:18 +03:00
Chris AtLee
7f8f324f06 Bug 1555560: Add support for black formatting with mozlint; r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D33125
 2020-07-08 19:35:49 +00:00
Sylvestre Ledru
56fbafd822 Bug 1647265 - mozlint: when type is 'regex', add the capability to ignore the case r=ahal 
Differential Revision: https://phabricator.services.mozilla.com/D80477
 2020-06-23 21:45:16 +00:00
Sylvestre Ledru
503bdb7fd3 Bug 1623024 - mozlint/pylint - follow up: fix a syntax issue in the rst file 
Differential Revision: https://phabricator.services.mozilla.com/D80375
 2020-06-20 12:28:48 +00:00
Sylvestre Ledru
f47f1968a4 Bug 1623024 - mozlint: Add pylint as new linter r=linter-reviewers,ahal 
Differential Revision: https://phabricator.services.mozilla.com/D79076
 2020-06-18 20:04:50 +00:00
Sylvestre Ledru
47b3629cd9 Bug 1642825 - mozlint: Add a linter to prevent further use of black/whitelist r=Gijs,linter-reviewers,mossop,ahal 
Note that I cannot do unit test because of it doesn't support regex payload
''Failed: could not resolve a lint function from''

Differential Revision: https://phabricator.services.mozilla.com/D78158
 2020-06-16 17:02:59 +00:00
Sylvestre Ledru
7de68c2cea Bug 1642898 - Remove most of the references of black/whitelist within the doc r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D78000
 2020-06-03 09:34:12 +00:00
Sylvestre Ledru
df7f09424c Bug 1641848 - Import https://developer.mozilla.org/en-US/docs/Mozilla/Using_CXX_in_Mozilla_code in-tree r=nalexander 
I replaced the color by bold on "No".
It seems we can't have color in cells with rst :/

Differential Revision: https://phabricator.services.mozilla.com/D77444
 2020-05-29 19:28:52 +00:00
Tilden Windsor
a73234e7ec Bug 1614477 - Replaced deprecated dxr links with searchfox links. r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D76621
 2020-05-24 13:46:30 +00:00
Sylvestre Ledru
fedde13549 Bug 1636494 - doc: update the doc about some of the lint job moved to tier-2 r=linter-reviewers,ahal 
Depends on D74435

Differential Revision: https://phabricator.services.mozilla.com/D74436
 2020-05-13 09:32:57 +00:00
Ian Moody
a52653c73c Bug 1536556 - Extend no-throw-cr-literal ESLint rule to forbid and fix throw new Error(Cr.ERROR);. r=Standard8 
Code should be using `throw Components.Exception("", Cr.ERROR);` instead,
since `new Error()` just converts the int value of the Cr.ERROR into a string,
whereas `Exception` constructs an Exception object with the result property set
to the Cr.ERROR value, so other code can identify it.

Differential Revision: https://phabricator.services.mozilla.com/D28074
 2020-05-05 17:43:39 +00:00
Ian Moody
85f9392bc8 Bug 1536556 - Add custom no-throw-cr-literal ESLint rule, and enable it by default. r=Standard8 
This rule is based on the ESLint built-in no-throw-literal. Cr.ERRORs are also
literals since they are just integers and so have all the same disadvantages of
no stack info.

TestInterfaceJS.js is explicitly testing handling of throwing raw Cr.ERRORs and
thus needs to stay.

Differential Revision: https://phabricator.services.mozilla.com/D28072
 2020-05-05 15:00:50 +00:00
Sylvestre Ledru
af4a04d2c5 no bug - static analysis doc: Fix a trivial rst typo in the doc 
Differential Revision: https://phabricator.services.mozilla.com/D71449
 2020-04-18 10:55:15 +00:00
Sylvestre Ledru
ee37eb29a7 Bug 1466070 - Integrate clang-format into mozlint r=linter-reviewers,ahal 
For now, the local detection sucks. I will fix that once bug 1625884
is fixed

Differential Revision: https://phabricator.services.mozilla.com/D69683

--HG--
extra : moz-landing-system : lando
 2020-04-15 20:39:32 +00:00
Chris Peterson
32270107d9 Bug 1625855 - Replace MOZ_MUST_USE with [[nodiscard]] in some Servo Rust code. r=emilio 
Are there any Rust crates outside mozilla-central that include or emit Mozilla C++ code that should be updated to use [[nodiscard]] instead of MOZ_MUST_USE?

Depends on D68751

Differential Revision: https://phabricator.services.mozilla.com/D69319

--HG--
extra : moz-landing-system : lando
 2020-04-02 08:27:59 +00:00
Sylvestre Ledru
7cfa120eb9 Bug 1623320 - Add support to run mozlint on dotfile r=linter-reviewers,ahal 
Differential Revision: https://phabricator.services.mozilla.com/D67316

--HG--
extra : moz-landing-system : lando
 2020-03-20 21:51:03 +00:00
Andrew Halberstadt
ed55b7f24b Bug 1623656 - [mozlint] Make output of ./mach lint --list readable, r=linter-reviewers,sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D67501

--HG--
extra : moz-landing-system : lando
 2020-03-19 18:06:41 +00:00
Andrew Halberstadt
f4ff3c2181 Bug 1623339 - [lint.flake8] Fix path filtering bug when specifying subdirectory of excluded path, r=linter-reviewers,sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D67335

--HG--
rename : tools/lint/test/files/flake8/subdir/exclude/bad.py => tools/lint/test/files/flake8/subdir/exclude/exclude_subdir/bad.py
extra : moz-landing-system : lando
 2020-03-18 17:02:34 +00:00
Andi-Bogdan Postelnicu
bc9dbe64a1 Bug 1619921 - enable clang-plugin with support for alpha checkers module. r=froydnj,sg 
Differential Revision: https://phabricator.services.mozilla.com/D65314

--HG--
extra : moz-landing-system : lando
 2020-03-17 07:01:09 +00:00
Andreea Pavel
a6b6afe578 Backed out changeset 780399392e20 (bug 1619921) for breaking toolchains on a CLOSED TREE 2020-03-16 18:27:17 +02:00
Andi-Bogdan Postelnicu
1ee04a1f77 Bug 1619921 - enable clang-plugin with support for alpha checkers module. r=froydnj,sg 
Differential Revision: https://phabricator.services.mozilla.com/D65314

--HG--
extra : moz-landing-system : lando
 2020-03-16 16:04:00 +00:00
Sylvestre Ledru
ff3d04b683 Bug 1620635 - doc follow up - fix a typo DONTBUILD 
Differential Revision: https://phabricator.services.mozilla.com/D65864

--HG--
extra : moz-landing-system : lando
 2020-03-07 12:13:02 +00:00
Sylvestre Ledru
93ef1bd928 Bug 1620635 - static analysis, linting and coding style - add link to meta bugs r=static-analysis-reviewers,Ehsan 
Differential Revision: https://phabricator.services.mozilla.com/D65761

--HG--
extra : moz-landing-system : lando
 2020-03-06 21:01:22 +00:00
emilfs
5ff804de2e Bug 1618487 - fix rstcheck linter warning. r=sylvestre 
Differential Revision: https://phabricator.services.mozilla.com/D64557

--HG--
extra : moz-landing-system : lando
 2020-03-02 10:40:30 +00:00
Sylvestre Ledru
374863b8ad Bug 1605934 - Add nested namespaces in the C++ coding style r=sg 
Differential Revision: https://phabricator.services.mozilla.com/D64301

--HG--
extra : moz-landing-system : lando
 2020-02-26 09:31:44 +00:00
Sylvestre Ledru
101e156501 no bug - Recommends using instead of typedef r=sg 
Differential Revision: https://phabricator.services.mozilla.com/D63834

--HG--
extra : moz-landing-system : lando
 2020-02-24 13:13:19 +00:00
Sylvestre Ledru
90cb950547 no bug - doc: Add a list of all the clang-tidy check, now contains the list of autofix r=andi 
Differential Revision: https://phabricator.services.mozilla.com/D63818

--HG--
extra : moz-landing-system : lando
 2020-02-24 08:10:17 +00:00
Sylvestre Ledru
48271d5db0 no bug - Add missing linters and links r=static-analysis-reviewers,andi 
Differential Revision: https://phabricator.services.mozilla.com/D63543

--HG--
extra : moz-landing-system : lando
 2020-02-21 13:54:46 +00:00
Sylvestre Ledru
ef6f6d2886 Bug 1361341 - Add rust clippy to mozlint r=ahal 
Differential Revision: https://phabricator.services.mozilla.com/D58250

--HG--
extra : moz-landing-system : lando
 2020-02-19 08:50:35 +00:00
Sylvestre Ledru
33d59d070c No bug - static analysis doc: Add info about the matrix chat + review group r=static-analysis-reviewers,andi 
+ fix a link

Differential Revision: https://phabricator.services.mozilla.com/D63089

--HG--
extra : moz-landing-system : lando
 2020-02-17 16:59:37 +00:00
Ciure Andrei
7ab2d76537 Backed out changeset a63ccd650889 (bug 1361341) for causing mozlint failures CLOSED TREE 2020-02-14 11:10:29 +02:00