Calling window.restore will return the window to its previous
dimensions. Prior to this patch, extension windows transitioning to
normal state would add a second step where they would forcibly resize
the window to content. The motivating reason for this additional step is
some kind of difficulty with macOS windows restoring from other states.
Those issues were handled comprehensively in Bug 1631735, and now the
extra step is unnecessary and surprising to users. Since the call was
being made potentially during a deminimization native transition, the
window is at a very small size and expanding it to fit the content is
resizing it to a strange small size. Window.restore will do the right
thing, so this patch stops calling sizeToContent.
Differential Revision: https://phabricator.services.mozilla.com/D189972
There are 2 failing test cases in `browser/components/extensions/test/browser/browser_ext_browserAction_popup_preload.js` for the `html:body` that are sending clicks to a `<body>` element to dismiss the pending popup using an alternative way of the popup dismissal, where the other way like `Esc` key is available, therefore these two test clicks can be excluded from the a11y_checks.
Another test cases are in `browser/components/extensions/test/browser/browser_ext_menus_capture_secondary_click.js` that are clicking on the `<menu>` parent container to confirm the click event is not going to be triggered for the attached menu items, thus these clicks are also excluded from the a11y_checks.
These actions are not expected or do not have to be done by a user of an assistive technology and we do not have to confirm the accessibility of these elements.
Thus, we are excluding these click events from accessibility checks.
Differential Revision: https://phabricator.services.mozilla.com/D193574
We intentionally turn off a11y_checks for these click events, because the clicks in the patch are targeting disabled controls to confirm the click events won't come through. These clicks are not meant to be interactive and are not expected to be accessible.
Thus, we are excluding this click event from accessibility checks and removing the fail-if annotation that was added by bug 1854460 before the investigation in the meta bug 1854461.
Differential Revision: https://phabricator.services.mozilla.com/D193329
Calling window.restore will return the window to its previous
dimensions. Prior to this patch, extension windows transitioning to
normal state would add a second step where they would forcibly resize
the window to content. The motivating reason for this additional step is
some kind of difficulty with macOS windows restoring from other states.
Those issues were handled comprehensively in Bug 1631735, and now the
extra step is unnecessary and surprising to users. Since the call was
being made potentially during a deminimization native transition, the
window is at a very small size and expanding it to fit the content is
resizing it to a strange small size. Window.restore will do the right
thing, so this patch stops calling sizeToContent.
Differential Revision: https://phabricator.services.mozilla.com/D189972
Prepend the mochitest directory listing with `<!DOCTYPE html>` to prevent the document to be loaded in quirks mode and flood the log with console messages.
Differential Revision: https://phabricator.services.mozilla.com/D190544
There are some a11y_checks that are intermittently failing on Autoland and pass on Try and vice versa. Also, a couple of tests are crashing while performing a11y_checks, thus they are to be skipped while we continue the investigation into each of them.
Related bugs:
- Fail-if tests: meta bug 1848402
- Explore capturing click events for a11y_checks: bug 1692110
Differential Revision: https://phabricator.services.mozilla.com/D191259
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to fail-if the failing tests altogether and then handle each one of them individually.
This task is to add `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.
Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, Webextensions-sepecific meta bug 1854461
- Explore capturing click events for a11y_checks: bug 1692110
Depends on D188912
Differential Revision: https://phabricator.services.mozilla.com/D188913
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.
This task is to skip with `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.
Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, Webextensions-sepecific meta bug 1854461
- Explore capturing click events for a11y_checks: bug 1692110
Differential Revision: https://phabricator.services.mozilla.com/D188913
This patch changes the behavior as follows:
- match_about_blank in content_scripts in manifest.json will now only
run in top-level about:blank if its `matches` key specifies a match
pattern set that is equivalent to all http(s) URLs.
- matchAboutBlank in tabs.executeScript requires activeTab permission
(as before), or an all-URLs host permission.
Differential Revision: https://phabricator.services.mozilla.com/D189492
