Commit graph

795 commits

Author SHA1 Message Date
Tooru Fujisawa
98bed8bd01 Bug 1442465 - followup: Wait for session store update in browser/components/migration/tests/browser/browser_undo_notification.js. r=me 2018-03-19 12:40:46 +09:00
Tooru Fujisawa
1adba8c1fc Bug 1442465 - Part 4.2: Stop unnecessarily awaiting on BrowserTestUtils.removeTab (simple part). r=dao 2018-03-19 11:16:45 +09:00
Felipe Gomes
c4516c1ca8 Bug 1439443 - Policies: Don't create the default and smart bookmarks on the profile. r=mak
--HG--
rename : browser/components/enterprisepolicies/tests/browser/disable_developer_tools/browser.ini => browser/components/enterprisepolicies/tests/browser/disable_default_bookmarks/browser.ini
2018-03-16 21:02:05 -03:00
Kit Cambridge
0c40fa1232 Bug 1199077 - Split change sources for automatic and manual bookmark restores. r=mak
MozReview-Commit-ID: 1glcCPj2X90

--HG--
extra : rebase_source : 2d8372029df5851ecbb30a65393325442addd84c
2018-03-01 13:37:13 -08:00
Gijs Kruitbosch
56c730ca53 Bug 1438763 - fix intermittent orange in undo_notification_multiple_dismissal.js, r=ursula
When bug 1433324 made these tests run against activity stream, it made the notification
fire from the test's head.js file itself. Unfortunately, that races with the new tab / home
page actually loading, triggering an `onLocationChange` event in the tabbrowser, which
removes the notification again, meaning it is then no longer there when the test expects
it to be.

This wasn't an issue before, because the notification bar was opened via a message from
within the new tab page, which always arrived after the `onLocationChange` event.

Because the current state is temporary anyway, I'm just changing the test to open 2 tabs
first, and then opening the notification bars, which in practice guarantees this happens
after the `onLocationChange` event.

MozReview-Commit-ID: LOzgjrZBp0H

--HG--
extra : rebase_source : 10568c1ad97b03143d79b2d967ccac42550000a6
2018-03-07 16:07:41 +00:00
Daniel Marshall
d337129b4a Bug 1434483 - Renamed profileStorage singleton to formAutofillStorage to make it more clear; r=MattN
MozReview-Commit-ID: CaPYBGLfs5I

--HG--
extra : rebase_source : ea59d03458c0e253201fd2c1476062dfb2e9a3d6
2018-02-10 21:23:19 +00:00
Mark Banner
0722fe3ee3 Bug 1434869 - Automatically mark EXPORTED_SYMBOLS as used, so that we don't need to ignore it in ESLint's no-unused-vars rule. r=florian.
MozReview-Commit-ID: IVMeZHGdVBk

--HG--
extra : rebase_source : 0705e96256baf6dc82811297058aa1d820b2f119
2018-03-06 12:01:59 +00:00
Narcis Beleuzu
34b2bf4c13 Backed out changeset a8130e46c530 (bug 1434483) for ESlint failures on browser_change_shipping.js. CLOSED TREE 2018-03-05 23:50:02 +02:00
Daniel Marshall
57b922d77c Bug 1434483 - Renamed profileStorage singleton to formAutofillStorage to make it more clear; r=MattN
MozReview-Commit-ID: CaPYBGLfs5I

--HG--
extra : rebase_source : 379bd1db1e50ae415806713878e6b3ef36889e89
2018-02-10 21:23:19 +00:00
Gijs Kruitbosch
7dd5677adc Bug 1437940 - fix where we look for a 'Local State' file for non-release Chrome data, r=dthayer
MozReview-Commit-ID: CXghkKKhHfx

--HG--
extra : rebase_source : 8050e98033da4b265c61b7f612f906828b9241e9
2018-03-01 15:07:28 +00:00
Gijs Kruitbosch
21074e3307 Bug 1437940 - include Chrome Beta and Chrome Dev in migration list on Linux, r=dthayer
MozReview-Commit-ID: HDTkdXdYos3

--HG--
extra : rebase_source : c5e9abdd2f8c3077e38a716d26d6afa7cdc93914
2018-03-01 14:03:06 +00:00
Florian Quèze
c714053d73 Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Mark Banner
6afe18b30a Bug 1440379 - Tidy up ESlint no-unused-vars definitions wrt Ci/Cu/Cr/Cc usage for varsIgnorePattern. r=florian
MozReview-Commit-ID: HmliR8iNRDq

--HG--
extra : rebase_source : 483ae0b54b9e781cceac2accdfb2255d725ace6a
2018-02-22 16:55:36 +00:00
Sebastian Hengst
e6ed14057b merge mozilla-central to autoland on a CLOSED TREE
--HG--
extra : amend_source : d88824ea9bbe5e0298f0d64fd0e4cdedcbee342c
2018-02-24 03:07:44 +02:00
Florian Quèze
682b1ec3b2 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Doug Thayer
511d92a9fe Bug 1432529 - Exit spinEventLoopUntil when canceling migrator r=Gijs
Fairly trivial - discussed in bug 862127. Opt to cancel the spin wait
rather than disable canceling in the UI.

MozReview-Commit-ID: B55Fsw34uX7

--HG--
extra : rebase_source : 3b7e83799af01cef096894b40537c1a4021ffc16
2018-02-15 11:55:10 -08:00
Narcis Beleuzu
2d9816273c Merge inbound to mozilla-central. a=merge 2018-02-16 11:49:59 +02:00
Margareta Eliza Balazs
428a385d22 Backed out changeset ebbcdc3e642d (bug 1433593) for X failing in toolkit/components/passwordmgr/test/unit/test_maybeImportLogin.js on a CLOSED TREE 2018-02-16 04:50:42 +02:00
Andrei Ciure
2e4c4d8b80 Bug 1425323 - disable test_refresh_firefox.py on Windows pgo and opt r=jmaher 2018-02-15 11:58:09 -05:00
Gijs Kruitbosch
9239725b9a Bug 1434167 - remove home page code from the migration wizard, r=MattN
This removes all the homepage-related code. All the cases where we advance the wizard straight to
the homepage wizardpage now go straight to the 'start migrating' page (the 'point' was skipping
earlier pages that allowed users to select items).
The brand bundle was only used by the homepage code so is also being removed.

MozReview-Commit-ID: I9nSU2IMkQz

--HG--
extra : rebase_source : da803ed67b443cb164f2bc55550bfd7c107fa916
2018-02-07 10:37:20 +00:00
Gijs Kruitbosch
ac1ce88bcf Bug 1434167 - remove getSourceHomePageURL implementations and callsites, r=dthayer
MozReview-Commit-ID: 98p2Iy70EPv

--HG--
extra : rebase_source : 7980fffb74a3deff1493353c610d03a506c392d9
2018-02-07 10:18:46 +00:00
Nathan Watson
1605552221 Bug 1434262 - Remove PlacesTestUtils.clearHistory() r=mak
MozReview-Commit-ID: In2RaM0LBsc

--HG--
extra : rebase_source : 0cb5dc65a53bfa384b93fb2a8c2af67ad9d3fe1c
2018-01-31 22:03:05 -08:00
Mark Banner
2fd2fd7199 Bug 1436389 - Update complexity rules to adapt for the algorithm in the new ESLint. r=mossop
MozReview-Commit-ID: 1LlfamNvBEM

--HG--
extra : rebase_source : 8e41e5a5f67bfd43444fde25287cb3709452a349
2018-02-07 16:16:09 +00:00
Jeremy Lempereur
6a893d8284 Bug 1249596 - Part 2: Remove FHR client id migration code. r=Dexter
Removed a fallback import from a legacy FHR file when there is no valid ID in the DRS file.
This commit is related to bug 1431544
MozReview-Commit-ID: AACq7InWJpy

--HG--
extra : rebase_source : c48bf48addc515b9d86f22dd4e8ad5a066ebc76a
2018-01-18 23:51:24 +01:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Florian Quèze
2b1c8dccb6 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
George Dan, Ryan Neilsen, Dylan Turner
4cbac2527f Bug 1387632: Rename ProfileStorage module to FormAutofillStorage. r=MattN
--HG--
rename : browser/extensions/formautofill/ProfileStorage.jsm => browser/extensions/formautofill/FormAutofillStorage.jsm
extra : rebase_source : aa456b06046f1d995d65bec13044cde081559061
extra : histedit_source : 620bdb1c33de4b4b656066ea6432826f3631c3b4
2018-01-30 14:44:59 -08:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Doug Thayer
acb8cf28cc Bug 1433024 - Update MigrationUtils' sourceHomePageURL r=Gijs
Fairly trivial. This was breaking for the test_refresh_firefox
test in beta, since the code which calls this is only active if
certain branding strings are present.

MozReview-Commit-ID: 3CkosXHgoMm

--HG--
extra : rebase_source : b027b12f3f09a8114ccf32c767262a32543b3a74
2018-01-29 09:03:24 -08:00
Doug Thayer
57731e3f90 Bug 1426721 - Encrypt Chrome logins in background thread r=keeler,MattN
A significant chunk of migration jank that I observe locally
happens due to login encryption. This patch reduces the locally
observed jank (measured importing 100 logins) from 180ms to 25ms.

Try is green, and as far as I can tell I don't see any thread
safety issues, but I'm not 100% sure on that. I don't see any
red flags inside the SecretDecoderRing::Encrypt implementation.

I only moved Chrome logins over since I wanted to frontload any
potential issues with the whole approach. It shouldn't be too
hard to move the MSMigrationUtils and IEProfileMigrator uses
over though.


MozReview-Commit-ID: 75edUqJlk8x

--HG--
extra : rebase_source : 0a8e16c46e05972fb01c9703b52cdb5755b0b40b
2018-01-04 15:10:54 -08:00
Marco Bonardo
04c132a988 Bug 1416377 - Use new async Places APIs in test_refresh_firefox.py. r=standard8
MozReview-Commit-ID: HvN8oHgIbbq

--HG--
extra : rebase_source : 5a21dba36985008f5383ed6332571f91565716a5
2018-01-23 15:14:38 +01:00
Doug Thayer
c84d12a090 Bug 862127 - Fix migrator tests to use async interfaces r=Gijs
MozReview-Commit-ID: 9qFA4y8viSW

--HG--
extra : rebase_source : 8addec4f65d58c05c83009ca4bd23917d9961c0c
2018-01-11 15:35:05 -08:00
Doug Thayer
9cae8e6dac Bug 862127 - Remove all sync IO from Chrome migration r=Gijs
Now that the interfaces are all async, we can simply replace all
the sync IO in the Chrome migrator with the equivalent async IO.
Other browsers will be addressed in separate patches.

MozReview-Commit-ID: FyGRRKY57Gm

--HG--
extra : rebase_source : 0228b9b72c7217e3f6e607256cb3828bf5819189
2018-01-11 09:52:56 -08:00
Doug Thayer
cec5b96dc3 Bug 862127 - Convert migration.js to use async migration interfaces r=Gijs
migration.js is a special case where we generally need blocking
calls in order for the wizard to work correctly. Accordingly we
block waiting for the new async interfaces. With automigration
and potential new UIs that are in the works for migration, the
asynchronicity of these interfaces will be more relevant, but
here it's not really important enough to make big changes to the
way the UI is implemented.

MozReview-Commit-ID: LkfwBVfpCJO

--HG--
extra : rebase_source : 1f9f2c7e2fa20b883840e091dbee366a161eaaf7
2018-01-12 09:11:38 -08:00
Doug Thayer
efdd84d094 Bug 862127 - Make migration interfaces more async r=Gijs
In order to clean up sync IO within our profile migrators, we
need to have async interfaces for those parts which are currently
doing sync IO. This converts the sync interfaces and adjusts most
of the call sites (migration.js call site changes are addressed
in a separate patch to break it out a bit).


MozReview-Commit-ID: 2Kcrxco4iYr

--HG--
extra : rebase_source : 53d123c435e43622a999a7e849dddbe1919061e0
2018-01-12 09:06:21 -08:00
Sam R-T, Joseph F, Robin H
b6f7cc8e46 Bug 1432062 - Require dangling commas via eslint for the migration component. r=MattN 2018-01-22 15:22:35 -08:00
Doug Thayer
b9fbe56e33 Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin r=MattN
In bug 1426721 we added a bulk interface for importing logins, which
works in a background thread. This patch cleans up the single-login
interface and updates the remaining usages to consume the bulk
interface.

MozReview-Commit-ID: IziLXkO5dxQ

--HG--
extra : rebase_source : 5e9be186b1f112afb5bd46c1a979b3403ce3b59d
2018-02-15 10:26:44 -08:00
shindli
b92e3fe192 Backed out 2 changesets (bug 1433593) for xpcshell on /tests/unit/test_IE7_passwords.js on a CLOSED TREE
Backed out changeset c1b0ea577728 (bug 1433593)
Backed out changeset 96327b595b91 (bug 1433593)
2018-02-20 23:01:54 +02:00
Doug Thayer
1ad355de43 Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin r=MattN
In bug 1426721 we added a bulk interface for importing logins, which
works in a background thread. This patch cleans up the single-login
interface and updates the remaining usages to consume the bulk
interface.

MozReview-Commit-ID: IziLXkO5dxQ

--HG--
extra : rebase_source : 7b2df904fde5ec0abeb7d30633b0dd819de0cc9e
2018-02-15 10:26:44 -08:00
Doug Thayer
b17207c350 Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin r=MattN
In bug 1426721 we added a bulk interface for importing logins, which
works in a background thread. This patch cleans up the single-login
interface and updates the remaining usages to consume the bulk
interface.

MozReview-Commit-ID: IziLXkO5dxQ

--HG--
extra : rebase_source : 7b2df904fde5ec0abeb7d30633b0dd819de0cc9e
2018-02-15 10:26:44 -08:00
Ed Lee
4632096315 Bug 1433324 - Part 2. Get auto migration tests running with activity stream enabled. r=Gijs
MozReview-Commit-ID: AOItGs3ca5v

--HG--
extra : rebase_source : 975bda934fa30b57d82d53a50d25e80c532aafa0
2018-02-14 22:52:40 -08:00
Doug Thayer
dcdcf8ed13 Bug 1430318 - Fix getLastUsedDate bugs from using typedURLs r=mak
getLastUsedDate should be converting the microseconds of typedURLs
into milliseconds.

MozReview-Commit-ID: DjJKm5aPcGD

--HG--
extra : rebase_source : 017a33f2599b779403988997145d5d1a9acdf109
2018-01-17 11:15:27 -08:00
Doug Thayer
99aab18a1e Bug 1430318 - Prevent zeroes Edge history timestamps from breaking import r=mak
Edge history visit times can be zero. Not sure of exactly what
conditions cause this, but the Edge start page has a visit time of
0 on a local machine.

MozReview-Commit-ID: KJ9iwbLIhj2

--HG--
extra : rebase_source : 726461a6acb6a58c7b45c9e2f1ceb7e911a83c72
2018-01-16 11:08:21 -08:00
Doug Thayer
1e3446b9cc Bug 1421703 - Fix tests to use onVisits r=mak
Fairly straightforward. Fixes the tests that were broken due to
the changes introduced in part 1.

MozReview-Commit-ID: GbZ9ZpmG9nE

--HG--
extra : rebase_source : ebb2088288718631a941139d5a4d945259aaa0c6
2017-12-14 16:55:31 -06:00
Florian Quèze
0f55cd45be Bug 1421992 - script-generated patch to replace do_execute_soon, do_print and do_register_cleanup with executeSoon, info and registerCleanupFunction, rs=Gijs. 2017-12-21 11:10:23 +01:00
Matthew Noorenberghe
e6e4165603 Bug 1415692 - Show the bookmark toolbar in new profiles with > 3 bookmarks on it. r=Gijs,mak
MozReview-Commit-ID: C3tmqIrt5ak

--HG--
extra : rebase_source : 936b8cab5de587e2dde708b94f8be597f9c83e6a
2017-12-04 15:24:02 -08:00
Sebastian Hengst
35e834df9a Backed out changeset 8312a6286023 (bug 1415692) for failing to parse dom/events/test/mochitest.ini on Android due pref usage. r=backout 2017-12-05 19:56:51 +02:00
Matthew Noorenberghe
02471f5cfa Bug 1415692 - Show the bookmark toolbar in new profiles with > 3 bookmarks on it. r=Gijs,mak
MozReview-Commit-ID: C3tmqIrt5ak

--HG--
extra : rebase_source : 20eeacd571e6f50ff076ae1a97924720bf7a55f3
2017-12-04 15:24:02 -08:00
Evan Tseng
9e8a45eb49 Bug 1410839 - Add the ChromeMigrationUtils.jsm module and implement the getExtensionList and related functions to export all extensions information installed in a specific profile. r=Gijs
MozReview-Commit-ID: AqlJzKkTjWp

--HG--
extra : rebase_source : 85d2ca1550297fcc57eb625552eb93d13aa99181
2017-11-23 10:48:18 +08:00
Doug Thayer
78bc8cef16 Bug 1338800 - await completeDeferred for all resources r=mak
To reduce any contention from migrating multiple resources at the
same time, it seems prudent to wait for each to finish before
migrating the next. res.migrate is only sometimes properly async,
so the simplest thing to do today is to just always await
completeDeferred.promise. Additionally I am filing Bug 1418455
to track simplifying this to simply await res.migrate.

MozReview-Commit-ID: LdgNsxfuzu4

--HG--
extra : rebase_source : d111110f1445ed84785523ee12b5afb3da2d7207
2017-11-17 11:45:44 -08:00