Commit graph

2465 commits

Author SHA1 Message Date
Brian Grinstead
08992fb8e8 Bug 1546501 - Remove unnecessary type attributes (i.e. [type="application/javascript"]) on non-test script tags r=mossop
This is an autogenerated commit, generated with https://bug1546501.bmoattachments.org/attachment.cgi?id=9060222

Differential Revision: https://phabricator.services.mozilla.com/D28559

--HG--
extra : moz-landing-system : lando
2019-04-24 19:43:57 +00:00
Rob Wu
4a6f84f91d Bug 1544834 - Replace deprecated generics in test code r=evilpie
- `Array.map` becomes `Array.from`
- Array copying via `Array.slice` becomes `Array.from`.
- `Array.forEach` that did not rely on closures becomes `for`-`of` loops.
- Anything else: `Array.X` becomes `Array.prototype.X`.

Complex cases:

dom/bindings/test/TestInterfaceJS.js and
dom/bindings/test/test_exception_options_from_jsimplemented.html
use `Array.indexOf` to generate an error with a specific error message.
Switched to `Array.prototype.forEach` to generate the same error.

js/src/jit-test/tests/basic/exception-column-number.js
In this test `Array.indexOf()` is used to generate an error. Since the
exact message doesn't matter, I switched to `Array.from()`.

Intentionally not changed:

editor/libeditor/tests/browserscope/lib/richtext/richtext/js/range.js
Did not modify because this is 3rd-party code and the code uses
feature detection as a fall back when Array generics are not used.

testing/talos/talos/tests/dromaeo/lib/mootools.js
Did not modify because mootools adds the `Array.slice` method to the
`Array` object.

Not changed because they check the implementation of Array generics:
js/src/jit-test/tests/basic/arrayNatives.js
js/src/jit-test/tests/basic/bug563243.js
js/src/jit-test/tests/basic/bug618853.js
js/src/jit-test/tests/basic/bug830967.js
js/src/jit-test/tests/jaeger/recompile/bug656753.js
js/src/jit-test/tests/self-hosting/alternate-static-and-instance-array-extras.js
js/src/tests/non262/Array/generics.js
js/src/tests/non262/Array/regress-415540.js
js/src/tests/non262/extensions/regress-355497.js
js/src/tests/non262/extensions/typedarray-set-neutering.js

Depends on D27802

Differential Revision: https://phabricator.services.mozilla.com/D27803

--HG--
extra : moz-landing-system : lando
2019-04-17 19:03:19 +00:00
Rob Wu
1af4c55c01 Bug 1544834 - Replace non-test uses of deprecated Array generics r=evilpie,dao
- `Array.forEach` becomes for-of loop or `array.forEach`.
- `Array.slice(a)` or `Array.slice(a, 0)` becomes `Array.from(a)`.
- `Array.map` becomes `Array.from`
- `Array` copy + concatenation becomes Array literal + spread syntax.
- All other `Array.X(a, ...)` become `Array.prototype.X.call` or `Array.from(a).X(...)`

Differential Revision: https://phabricator.services.mozilla.com/D27802

--HG--
extra : moz-landing-system : lando
2019-04-17 19:03:17 +00:00
Nika Layzell
50a5699074 Bug 1539163 - Part 2: Support changing the process of subframes, r=qdot
When a remote type mismatch is found for a subframe, this patch checks if
fission is enabled for that window. If it is, it triggers a process switch,
continuing the load in a new process.

With this patch, subframes will only change process when navigating to a HTML
subframe, and not when navigating to a non-HTML subframe. That will be fixed in
a follow-up. This patch also does not change the remote type selection logic,
so only very limited types of remote iframes are supported.

Differential Revision: https://phabricator.services.mozilla.com/D27513

--HG--
extra : moz-landing-system : lando
2019-04-17 00:53:32 +00:00
Drew Willcoxon
c1f323bbe7 Bug 1541929 - Don't autofill the first result in some cases. r=mak
We need to handle autofilling the first result separately from autofilling results in general (which happens in UrlbarInput.setValueFromResult), so add a new UrlbarInput.autofillFirstResult method. The controller calls it instead of setValueFromResult. I ported the logic from nsAutoCompleteController, as described in the bug.

Other changes are related to the new test for this.

As part of this work, I was interested in learning how awesomebar handles browser_autoFill_typed.js, so I added it to the legacy tests, with a small tweak in the test for awesomebar.

Differential Revision: https://phabricator.services.mozilla.com/D26852

--HG--
extra : moz-landing-system : lando
2019-04-15 13:15:30 +00:00
Andreea Pavel
14f11a2e84 Bug 1435394 - disabled browser_upgrade_backup.js on win and osx r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D27062

--HG--
extra : moz-landing-system : lando
2019-04-11 13:30:08 +00:00
Peter Van der Beken
023a72eb9b Bug 1534638 - Part 1: remove unused arguments from session history listeners. r=qdot
Differential Revision: https://phabricator.services.mozilla.com/D25761

--HG--
extra : moz-landing-system : lando
2019-04-04 16:18:48 +00:00
Sebastian Streich
879635b243 Bug 1539853 - Throw Exceptions on null Principal within SpeculativeConnectInternal and Handle on Callsite r=ckerschb,Gijs
***
++Linting

Differential Revision: https://phabricator.services.mozilla.com/D25725

--HG--
extra : moz-landing-system : lando
2019-04-02 16:36:09 +00:00
Mark Banner
dba6983e75 Bug 1415265 - Remove now unnecessary .eslintrc.js files or entries. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D23850

--HG--
extra : moz-landing-system : lando
2019-03-28 09:38:14 +00:00
Gijs Kruitbosch
5e05f6c9c9 Bug 1353013 - move new tab preload browser tracking into a separate module, r=dthayer
Differential Revision: https://phabricator.services.mozilla.com/D21126

--HG--
extra : moz-landing-system : lando
2019-03-19 17:29:14 +00:00
shindli
a7af1edc71 Backed out 3 changesets (bug 1353013) for a11y failures in accessible/tests/mochitest/relations/test_tabbrowser.xul CLOSED TREE
Backed out changeset af8bce2330e9 (bug 1353013)
Backed out changeset a3d1302b06c0 (bug 1353013)
Backed out changeset 976afd1adf84 (bug 1353013)
2019-03-18 18:21:16 +02:00
Gijs Kruitbosch
b7a741e6cb Bug 1353013 - move new tab preload browser tracking into a separate module, r=dthayer
Differential Revision: https://phabricator.services.mozilla.com/D21126

--HG--
extra : moz-landing-system : lando
2019-03-12 14:34:04 +00:00
Kyle Machulis
b1414002ac Bug 1524709 - Remove aShouldBeRemote from updateBrowserRemoteness; r=nika
Just set the RemoteType in the options object argument, instead of
doubling up the information.

Differential Revision: https://phabricator.services.mozilla.com/D23250

--HG--
extra : moz-landing-system : lando
2019-03-14 00:51:30 +00:00
Dão Gottwald
fb03a6d522 Backed out changeset 59c8fffe9e41 (bug 1442694) 2019-03-07 11:41:29 +01:00
Dão Gottwald
9d4207731e Backed out changeset 3bd9591627ce (bug 1442694) 2019-03-07 11:31:48 +01:00
Dão Gottwald
14505d9bf1 Backed out changeset 8b3fe0426ffc (bug 1442694) 2019-03-07 11:31:30 +01:00
Dão Gottwald
dd32a46b52 Backed out changeset 764939fcdaf3 (bug 1532498) 2019-03-07 11:31:12 +01:00
Doug Thayer
965b1cacf3 Bug 1532498 - Check userContextId when consuming preopened tabs r=Gijs
This will fix the behavior, I think it might still be worth deliberating
over whether we want to consider non-default userContextId's when tracking
the number of pinned tabs or not. This will be visually correct - the
number of pinned tabs won't change, so things won't be moving around in
the tab bar, but we will throw away the preopened tab once we get further
down in SessionStore.jsm, which is less than ideal.

Differential Revision: https://phabricator.services.mozilla.com/D22195

--HG--
extra : moz-landing-system : lando
2019-03-06 11:50:15 +00:00
Felipe Gomes
eca5644792 Bug 827976 - Use requestIdleCallback from Timer.jsm instead of from the hidden window. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D21085

--HG--
extra : moz-landing-system : lando
2019-03-04 18:53:22 +00:00
Doug Thayer
bfac029223 Bug 1442694 - Fix failures due to removing selected tab r=Gijs
This adds test which reproduce the failure as well as the fix. Essentially,
if we hit the edited case in SessionStore with `tab` equal to `tabbrowser.tabs[t]`,
we remove the tab and then try to pin it, which obviously blows up.

Note: the additional method in SessionStore.jsm was largely to get around
complexity requirements inside restoreWindow. Cleaner solutions welcome.

Differential Revision: https://phabricator.services.mozilla.com/D21383

--HG--
extra : moz-landing-system : lando
2019-03-01 18:29:09 +00:00
Doug Thayer
b189426fb7 Bug 1442694 - Add tests for preopened pinned tabs r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D19463

--HG--
extra : moz-landing-system : lando
2019-03-01 18:29:00 +00:00
Doug Thayer
9790c57933 Bug 1442694 - Preopen pinned tabs before session restore r=Gijs
When we open firefox with pinned tabs, we first paint a window with
one tab open, and then that tab gets displaced after the pinned tabs
come in. This aims to ensure that our first paint contains the
pinned tab, so that we don't have tabs moving around after first
paint.

MozReview-Commit-ID: GC1y6NlgLTd

Differential Revision: https://phabricator.services.mozilla.com/D18742

--HG--
extra : moz-landing-system : lando
2019-03-01 18:28:53 +00:00
Cosmin Sabou
a706bb3916 Backed out 16 changesets (bug 827976) for causing bug 1532054. a=backout
Backed out changeset 54c0b12443ed (bug 827976)
Backed out changeset 92b45080d080 (bug 827976)
Backed out changeset 443087a359f9 (bug 827976)
Backed out changeset f976c2d4cebb (bug 827976)
Backed out changeset 66cffb171024 (bug 827976)
Backed out changeset 845e1d0b2402 (bug 827976)
Backed out changeset fd94066a1d76 (bug 827976)
Backed out changeset e253b264e7bd (bug 827976)
Backed out changeset 07ef335770a8 (bug 827976)
Backed out changeset 9d3805d77b99 (bug 827976)
Backed out changeset eed600ceb606 (bug 827976)
Backed out changeset 3b64368cff52 (bug 827976)
Backed out changeset 69d0378e0c09 (bug 827976)
Backed out changeset 9203871a5c6f (bug 827976)
Backed out changeset 96a507c818e2 (bug 827976)
Backed out changeset e254496ff95b (bug 827976)
2019-03-02 20:40:01 +02:00
Jason Orendorff
17dc68fa03 Bug 1524726 - Fix a race condition in a SessionStore test. r=florian
The test uses some custom code to wait for the new window, probably just
because the test is old. The fix is to use the BrowserUtils method instead.

Differential Revision: https://phabricator.services.mozilla.com/D18478

--HG--
extra : moz-landing-system : lando
2019-02-28 20:45:33 +00:00
Felipe Gomes
fe436b6b68 Bug 827976 - Use requestIdleCallback from Timer.jsm instead of from the hidden window. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D21085

--HG--
extra : moz-landing-system : lando
2019-03-01 21:07:13 +00:00
Alphan Chen
6d33e62c06 Bug 1497147 - Rewrite "mapFrameTree" implementation to C++ r=peterv
Get rid of mapFrameTree() implementation

Differential Revision: https://phabricator.services.mozilla.com/D17149

--HG--
extra : moz-landing-system : lando
2019-02-28 13:09:54 +00:00
Marco Bonardo
5c4e44ce0a Bug 1528751 - Add a custom eslint rule to check "consistent" if bracing. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D20753

--HG--
extra : moz-landing-system : lando
2019-02-28 08:39:33 +00:00
Gabriele Svelto
0443979a06 Bug 675539 - Make tab discard functionality work on tab objects directly r=mconley
This removes the need to go through the browser-to-tab mapping when discarding
a tab and simplifies the relevant code. Besides being renamed discardBrowser()
was also split so that one can check if a tab can be discarded prior to trying
it.

Differential Revision: https://phabricator.services.mozilla.com/D20475

--HG--
extra : moz-landing-system : lando
2019-02-26 05:35:09 +00:00
Mike Conley
3081c2863c Bug 1529088 - Hold the HTML-based about:config to Nightly until we get Product sign-off. r=florian,paolo
Differential Revision: https://phabricator.services.mozilla.com/D20825

--HG--
extra : moz-landing-system : lando
2019-02-27 21:54:57 +00:00
Mark Banner
f6e80010eb Bug 1522530 - Port session store test browser_599909.js to QuantumBar. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D21225

--HG--
rename : browser/components/sessionstore/test/browser_599909.js => browser/components/sessionstore/test/browser_tabs_in_urlbar.js
extra : moz-landing-system : lando
2019-02-27 14:35:17 +00:00
shindli
08b7f8eebb Backed out 2 changesets (bug 1442694) for breaking session restores on update a=backout
Backed out changeset f100f8631f78 (bug 1442694)
Backed out changeset 7a20c79a0e12 (bug 1442694)
2019-02-26 18:32:20 +02:00
Noemi Erli
7e23372938 Merge mozilla-central to autoland. a=merge CLOSED TREE
--HG--
extra : rebase_source : de8796d5d7d7079af1b895a2f537371885f8cc6c
2019-02-26 00:09:40 +02:00
Christoph Kerschbaumer
c8bb3d7749 Bug 1529869: Remove the 2 from speculate speculative(Anonymous)Connect2 within nsISpeculativeConnect.idl. r=valentin 2019-02-24 20:26:56 +01:00
Doug Thayer
d2b8144761 Bug 1442694 - Add tests for preopened pinned tabs r=Gijs
Depends on D18742

Differential Revision: https://phabricator.services.mozilla.com/D19463

--HG--
extra : moz-landing-system : lando
2019-02-25 19:19:30 +00:00
Doug Thayer
978e0344ff Bug 1442694 - Preopen pinned tabs before session restore r=Gijs
When we open firefox with pinned tabs, we first paint a window with
one tab open, and then that tab gets displaced after the pinned tabs
come in. This aims to ensure that our first paint contains the
pinned tab, so that we don't have tabs moving around after first
paint.

MozReview-Commit-ID: GC1y6NlgLTd

Differential Revision: https://phabricator.services.mozilla.com/D18742

--HG--
extra : moz-landing-system : lando
2019-02-25 19:19:07 +00:00
Christoph Kerschbaumer
8124d3a763 Bug 1518454: Part 2, frontend changes, add CSP to loadURIOptions dictionary and pass CSP explicitly from frontend to docshell. r=gijs 2019-02-22 09:19:26 +01:00
Jonathan Kingston
cf5ea59a1e Bug 1521878 - Have fallback consistency for (de)serialization of principals. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D17271

--HG--
extra : moz-landing-system : lando
2019-02-21 18:12:35 +00:00
Gijs Kruitbosch
ca77a3ac16 Bug 1529577 - stop tracking window minimization in BrowserWindowTracker, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D19186

--HG--
extra : rebase_source : 16e601fa7ce3b2381c245417b00a7f204b0a7923
2019-02-08 16:34:41 +00:00
Orangelynx
d4e1c8f212 Bug 384278 - Added additional state variable to store window state before window minimization. r=mikedeboer
Current window state in the sessionstore system includes `sizeMode` which can be "normal", "minimized", "maximized". However, the OS also remembers whether the window was "normal" or "maximized" before minimization to restore it appropriately. With this fix, sessionstore does likewise.

Differential Revision: https://phabricator.services.mozilla.com/D13234

--HG--
extra : moz-landing-system : lando
2019-02-20 09:03:09 +00:00
Shane Caraveo
fff2e14c0b Bug 1525125 block newtab and homepage overrides in private windows r=rpl,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D18730

--HG--
extra : moz-landing-system : lando
2019-02-19 19:19:44 +00:00
Jonathan Kingston
cf14643de4 Bug 1521549 - Move (de)serializePrincipal from sessionstore Utils to E10SUtils. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D17261

--HG--
extra : moz-landing-system : lando
2019-02-19 02:34:09 +00:00
Valentin Gosu
a5cc5b2a87 Bug 1521808 - Implement process switching based on Cross-Opener-Origin-Policy header r=nika,qdot
* New topLevel loads get the nsILoadInfo.openerPolicy of the current top level document
* Parsing the Cross-Opener-Origin-Policy of a channel will update mLoadInfo.openerPolicy and this value will get propagated to the child process.
* SessionStore now checks nsIHttpChannel.hasCrossOriginOpenerPolicyMismatch (preffed off) and performs a process switch if needed

Differential Revision: https://phabricator.services.mozilla.com/D19000

--HG--
rename : toolkit/components/remotebrowserutils/tests/browser/browser_httpResponseProcessSelection.js => toolkit/components/remotebrowserutils/tests/browser/browser_httpCrossOriginOpenerPolicy.js
extra : moz-landing-system : lando
2019-02-15 22:02:47 +00:00
Nika Layzell
15e8803fb2 Bug 1522637 - Part 6: Perform process switches separtely from on-examine-response, r=valentin
Issues were occuring where a process swap would be decided upon during
on-examine-response, but before the swap could be handled by the
channel, the channel was redirected.

This new code takes the mildly hacky approach of simply using a separate
observer notification which is fired at the correct time. A better
solution may be to use a dedicated service for responding to these
events, however that was not implemented for this initial patch.

Depends on D18606

Differential Revision: https://phabricator.services.mozilla.com/D19691

--HG--
extra : moz-landing-system : lando
2019-02-15 19:49:17 +00:00
Nika Layzell
3a5872a2f0 Bug 1522637 - Part 4: Support browsers in globals without gMultiProcessBrowser, r=qdot
Depends on D18604

Differential Revision: https://phabricator.services.mozilla.com/D18605

--HG--
extra : moz-landing-system : lando
2019-02-15 19:49:13 +00:00
Nika Layzell
947aaf1432 Bug 1522637 - Part 3: Send history index when resuming redirected loads, r=qdot
Depends on D18603

Differential Revision: https://phabricator.services.mozilla.com/D18604

--HG--
extra : moz-landing-system : lando
2019-02-15 19:49:11 +00:00
Nika Layzell
feecd3ed43 Bug 1522637 - Part 2: Include BrowsingContextID in LoadInfo for subdocument loads, r=valentin
Depends on D18602

Differential Revision: https://phabricator.services.mozilla.com/D18603

--HG--
extra : moz-landing-system : lando
2019-02-15 19:49:04 +00:00
Razvan Maries
00ff5fa61a Backed out changeset 10528ad0d7a1 (bug 1525125) for frequently failing bug 1528134. a=backout 2019-02-15 18:23:14 +02:00
Razvan Maries
d93d94cbc9 Backed out 9 changesets (bug 1522637) for causing bug 1528188. a=backout
Backed out changeset e4ca191d62a5 (bug 1522637)
Backed out changeset 540e5f318768 (bug 1522637)
Backed out changeset 0886a317a108 (bug 1522637)
Backed out changeset 4c7c512a262d (bug 1522637)
Backed out changeset d7eb272688be (bug 1522637)
Backed out changeset 67e838f49f4b (bug 1522637)
Backed out changeset 7e38890c72fa (bug 1522637)
Backed out changeset e6ca9ad18d15 (bug 1522637)
Backed out changeset 0f759e91eca8 (bug 1522637)
2019-02-15 18:21:36 +02:00
Shane Caraveo
75718b91a4 Bug 1525125 block newtab and homepage overrides in private windows r=rpl,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D18730

--HG--
extra : moz-landing-system : lando
2019-02-14 19:46:00 +00:00
Nika Layzell
a2bc82eb15 Bug 1522637 - Part 7: Perform process switches separtely from on-examine-response, r=valentin
Issues were occuring where a process swap would be decided upon during
on-examine-response, but before the swap could be handled by the
channel, the channel was redirected.

This new code takes the mildly hacky approach of simply using a separate
observer notification which is fired at the correct time. A better
solution may be to use a dedicated service for responding to these
events, however that was not implemented for this initial patch.

Depends on D18607

Differential Revision: https://phabricator.services.mozilla.com/D19691

--HG--
extra : source : 3d24e8e81c02af9d1edec7571afecefb0d2f1eb4
2019-02-14 15:37:06 +00:00