Commit graph

667 commits

Author SHA1 Message Date
Mihai Alexandru Michis
0a98aa9782 Backed out changeset d8095eaef5dc (bug 1691755) for causing bc failures in browser_viewsourceprefs.js
CLOSED TREE
2021-02-12 21:19:56 +02:00
Kagami Sascha Rosylight
b97e032178 Bug 1691755 - Move view-source context menu items to nsContextMenu r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D104956
2021-02-12 18:31:47 +00:00
Neil Deakin
12b53e11e9 Bug 1690029, move image related context menu commands into a single section and remove view image info command, r=Gijs,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D103774
2021-02-03 17:56:25 +00:00
Chris Peterson
e25d5cd7d9 Bug 1685779 - Add Alt/Command + Left Arrow keyboard shortcut to Back button tooltip. r=Gijs,masayuki,fluent-reviewers,flod
We disabled Backspace as a keyboard shortcut to go back one page (bug 1041377). We can use the Back and Forward buttons' tooltips to advertise the other shortcuts users can use instead of Backspace (like we do on the Reload button's tooltip).

Differential Revision: https://phabricator.services.mozilla.com/D102053
2021-02-01 06:44:45 +00:00
Csoregi Natalia
a7cb602561 Backed out changeset 73c1995ff098 (bug 1685779) for failures on browser_ext_menus_replace_menu.js. CLOSED TREE 2021-01-31 00:57:04 +02:00
Chris Peterson
119f424dc2 Bug 1685779 - Add Alt/Command + Left Arrow keyboard shortcut to Back button tooltip. r=Gijs,masayuki,fluent-reviewers,flod
We disabled Backspace as a keyboard shortcut to go back one page (bug 1041377). We can use the Back and Forward buttons' tooltips to advertise the other shortcuts users can use instead of Backspace (like we do on the Reload button's tooltip).

Differential Revision: https://phabricator.services.mozilla.com/D102053
2021-01-29 14:50:44 +00:00
Kris Maglione
86cc746c76 Bug 1685801: Part 9 - Move BrowserUtils.getSelectionDetails to a separate module. r=mccr8
It won't ever be used in most content processes.

Differential Revision: https://phabricator.services.mozilla.com/D101489
2021-01-28 20:58:36 +00:00
Mihai Alexandru Michis
040e2ea5d0 Backed out 12 changesets (bug 1685801) for causing bc failures in browser_ctrlTab.js
CLOSED TREE

Backed out changeset 021924b62f13 (bug 1685801)
Backed out changeset 38cc10101c1f (bug 1685801)
Backed out changeset 9ab9574ac72a (bug 1685801)
Backed out changeset 1a7f259cc2ec (bug 1685801)
Backed out changeset b267b19a7f6e (bug 1685801)
Backed out changeset 7dfcf0257487 (bug 1685801)
Backed out changeset ee0d0169b079 (bug 1685801)
Backed out changeset 0c358ee51951 (bug 1685801)
Backed out changeset 338ab91af557 (bug 1685801)
Backed out changeset a49415007aaf (bug 1685801)
Backed out changeset b91098299143 (bug 1685801)
Backed out changeset edf6209861a8 (bug 1685801)
2021-01-28 22:55:11 +02:00
Kris Maglione
61f953a36b Bug 1685801: Part 9 - Move BrowserUtils.getSelectionDetails to a separate module. r=mccr8
It won't ever be used in most content processes.

Differential Revision: https://phabricator.services.mozilla.com/D101489
2021-01-28 05:24:56 +00:00
Butkovits Atila
7decdccbdc Backed out 12 changesets (bug 1685801) for causing failures on browser_fission_maxOrigins.js. CLOSED TREE
Backed out changeset 0d7153110519 (bug 1685801)
Backed out changeset 5175062925c7 (bug 1685801)
Backed out changeset 2c1250e786f0 (bug 1685801)
Backed out changeset 0ce3c773ba74 (bug 1685801)
Backed out changeset 9d51c6e24dee (bug 1685801)
Backed out changeset 3f4dc6349441 (bug 1685801)
Backed out changeset a80de9abb9f8 (bug 1685801)
Backed out changeset 30786893a5e7 (bug 1685801)
Backed out changeset 8007b12d6e32 (bug 1685801)
Backed out changeset fa814f4b7125 (bug 1685801)
Backed out changeset 14e4e47ee99f (bug 1685801)
Backed out changeset d9f1feba9454 (bug 1685801)
2021-01-28 07:15:59 +02:00
Kris Maglione
6a91fbec71 Bug 1685801: Part 9 - Move BrowserUtils.getSelectionDetails to a separate module. r=mccr8
It won't ever be used in most content processes.

Differential Revision: https://phabricator.services.mozilla.com/D101489
2021-01-28 03:32:56 +00:00
Oliver Pope
8e6cb89585 Bug 1626600 - added check for readyState in nsContextMenu to see if PiP should display r=mtigley,mhowell
Differential Revision: https://phabricator.services.mozilla.com/D102864
2021-01-24 15:32:16 +00:00
Emma Malysz
c04c6333bc Bug 1685184, print selected frame when selecting Print Frame from context menu r=marionette-reviewers,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D100842
2021-01-07 19:34:56 +00:00
Masatoshi Kimura
ef26928389 Bug 1681642 - Improve error messages when extensions blocked downloads. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D99592
2020-12-12 21:28:13 +00:00
Michael Kaply
6197f4c30c Bug 1680095 - Block Save Link As if site is blocked by policy. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D98527
2020-12-07 16:37:12 +00:00
Tim Huang
9fadef5261 Bug 1679325 - Part 1: Making contentAreaUtils.saveURL to accept cookieJarSettings. r=smaug
This patch makes the contentAreaUtils.saveURL to be aware of the
cookieJarSettings, and updates all callers.

This also updates the documentation of the persistArgs
'cookieJarSettings' for internalPersist().

Differential Revision: https://phabricator.services.mozilla.com/D98455
2020-12-03 20:10:36 +00:00
Emilio Cobos Álvarez
472511bebf Bug 1679050 - Backed out changeset 73181c2aa309 (bug 1455479) for having too many false positives. r=backout,a=NarcisB
MANUAL PUSH: Backout on a CLOSED TREE
2020-11-25 00:41:59 +01:00
Emilio Cobos Álvarez
e69e249773 Bug 1455479 - Show paste context menu item when there are paste event listeners. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D97751
2020-11-21 16:22:42 +00:00
Tim Huang
7ec26df273 Bug 1641270 - Part 6: Pass CookieJarSettings to nsIWebBrowserPersist.saveURI() and nsIWebBrowserPersist.savePrivacyAwareURI(). r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D95616
2020-11-11 18:19:27 +00:00
Tim Huang
c342ff2008 Bug 1641270 - Part 5: Send cookieJarSettings across processes for ContextMenu. r=smaug
This patch makes the ContextMenu to send cookieJarSettings from content
to the parent process via ContextMenuChild/Parent. The cookieJarSettings
will be used in 'Save ... As'.

Differential Revision: https://phabricator.services.mozilla.com/D95615
2020-11-11 11:14:09 +00:00
Mihai Alexandru Michis
4038013e6f Backed out 9 changesets (bug 1641270) for causing dt failures in browser_jsonview_save_json.js
CLOSED TREE

Backed out changeset 89a6dab92f1a (bug 1641270)
Backed out changeset 5f9c5af66b77 (bug 1641270)
Backed out changeset dfeb879f4131 (bug 1641270)
Backed out changeset 143728b1b1ab (bug 1641270)
Backed out changeset 265ae2953416 (bug 1641270)
Backed out changeset 55ea7810c160 (bug 1641270)
Backed out changeset 7bef9112f296 (bug 1641270)
Backed out changeset 2663dc1e9a3e (bug 1641270)
Backed out changeset fcba6dba3649 (bug 1641270)
2020-11-11 13:10:11 +02:00
Tim Huang
29e828489a Bug 1641270 - Part 6: Pass CookieJarSettings to nsIWebBrowserPersist.saveURI() and nsIWebBrowserPersist.savePrivacyAwareURI(). r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D95616
2020-11-10 20:43:03 +00:00
Tim Huang
7a39439a68 Bug 1641270 - Part 5: Send cookieJarSettings across processes for ContextMenu. r=smaug
This patch makes the ContextMenu to send cookieJarSettings from content
to the parent process via ContextMenuChild/Parent. The cookieJarSettings
will be used in 'Save ... As'.

Differential Revision: https://phabricator.services.mozilla.com/D95615
2020-11-10 11:47:47 +00:00
Emilio Cobos Álvarez
9c21cb2c0d Bug 1672864 - Don't show the "print selection" context menu items when the focused selection is in a textarea / input. r=emalysz
This is a band-aid for now, because I don't know how to best deal with
it.

Probably we should just print the plaintext selection contents,
unstyled, though that's a totally different codepath than what we do for
regular document selection, so probably deserves its own bug. Meanwhile,
this should prevent easy printing failures.

View-selection-source also doesn't deal with it properly so do the same
there too for now.

Differential Revision: https://phabricator.services.mozilla.com/D94595
2020-10-24 11:46:43 +00:00
Emilio Cobos Álvarez
4e68e78542 Bug 1669925 - Add a printing.trigger keyed scalar to record what triggers a particular print dialog. r=jwatt,marionette-reviewers,maja_zf
In order to avoid over/under-counting, we need to treat window.print()
specially. The new UI was using aOpenWindowInfo.isForPrintPreview for
that, but that doesn't quite work for the old UI (because it will
trigger a regular print, not a preview).

But since isForPrintPreview was only really needed to distinguish
window.print(), just rename it and set it to true when the old UI is
triggered by window.print() as well.

Differential Revision: https://phabricator.services.mozilla.com/D92925
2020-10-09 14:59:46 +00:00
Reid Shinabarker
5a3e382de8 Bug 1653496 - Picture-in-Picture option not shown for VideoHTMLElement with VideoTrack from Twilio. r=mconley,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D91544
2020-10-09 10:52:18 +00:00
Emilio Cobos Álvarez
4b4935794b Bug 140718 - Add a "Print selection only" entry to the context menu. r=Gijs,jwatt,fluent-reviewers
This allows to use the feature from the context menu and is very
straight-forward.

This has the benefit of working with fission (as print from the focused
frame) and so on.

Making a checkbox on the UI on top of this is doable, but it is a lot
more complex (requires a bunch of both front-end and platform work)
because undoing this implies restoring the DOM which "print selection"
removes.

I think the context menu entry is very useful regardless of whether we
add a checkbox to undo it, and other browsers (with smaller context
menus) seem to agree.

Differential Revision: https://phabricator.services.mozilla.com/D92205
2020-10-07 20:45:08 +00:00
Narcis Beleuzu
93313c434d Backed out changeset 3722e6ee6ebd (bug 1653496) for bc failures on browser_mediaStreamVideos.js . CLOSED TREE 2020-10-06 00:05:00 +03:00
Reid Shinabarker
917e456342 Bug 1653496 - Picture-in-Picture option not shown for VideoHTMLElement with VideoTrack from Twilio. r=mconley,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D91544
2020-10-05 18:26:35 +00:00
Mark Banner
fcf7b37638 Bug 1567275 - Don't display the search related context items if the search service is not initialized yet. r=daleharvey.
This also moves gInitialised into SearchService, as it no longer needs to be separate, and it makes changing it for tests easier.

Depends on D88462

Differential Revision: https://phabricator.services.mozilla.com/D88622
2020-09-11 15:54:50 +00:00
Brendan Dahl
0d0bffa160 Bug 1661131 - Hide fill login context menu for PDF forms. r=Gijs
Having the fill logins context menu on PDF forms could lead to users
accidentally entering their login information into to a PDF form which
is probably not a desired or expected behavior.

Differential Revision: https://phabricator.services.mozilla.com/D88198
2020-08-26 21:21:20 +00:00
Emilio Cobos Álvarez
0ec64c5610 Bug 1660291 - Make print frame in the context menu use the new print UI when appropriate. r=nordzilla
I had to make printing subframes work with the new UI for
window.print(), we may as well use it.

Differential Revision: https://phabricator.services.mozilla.com/D87785
2020-08-20 17:48:10 +00:00
Christoph Kerschbaumer
f372af4995 Bug 1658244: Allow view-background-image to open a data: URI by setting a flag on the loadinfo r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D86592
2020-08-11 13:41:54 +00:00
Frederik Braun
a7153982e8 Bug 1366973: Rename security flags to not contain DATA anymore r=geckoview-reviewers,ckerschb,snorp
Differential Revision: https://phabricator.services.mozilla.com/D83490
2020-07-15 11:20:45 +00:00
Kris Maglione
bd94db4e9a Bug 1580764: Part 2 - Use BrowsingContext IDs rather than window IDs to compute frame IDs. r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D82464
2020-07-07 21:37:53 +00:00
Yura Zenevich
20d5203a82 Bug 1640778 - remove auto-init experiment code. r=mtigley,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D77057
2020-07-03 23:52:16 +00:00
Cosmin Sabou
4a382d7801 Backed out 4 changesets (bug 1640338, bug 1640778) for devtools failures on browser_dbg-toolbox-unselected-pause.js.
Backed out changeset 92cb02f03119 (bug 1640778)
Backed out changeset 6401dd804f28 (bug 1640338)
Backed out changeset cb4edb2627bb (bug 1640338)
Backed out changeset b2394d79f48f (bug 1640338)
2020-06-30 19:59:10 +03:00
Yura Zenevich
17dc33c60a Bug 1640778 - remove auto-init experiment code. r=mtigley,devtools-backward-compat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D77057
2020-06-30 14:53:07 +00:00
Yura Zenevich
5b6b095fcf Bug 1602075 - display Inspect Accessibility Properties menu item if devtools.accessibility.auto-init.enabled pref is set to true. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D71586
2020-05-06 15:54:58 +00:00
Ian Moody
011b59d595 Bug 1536556 - Replace raw thrown Cr.ERRORs with Components.Exception. r=mossop,remote-protocol-reviewers,marionette-reviewers,whimboo,necko-reviewers,geckoview-reviewers,valentin,agi
Raw Cr.ERROR don't get stack information, same as throwing JS literals instead
of `new Error()`s.

This was done automatically with a new eslint rule that will be introduced in
the next commit.  One instance of a raw Cr.ERROR was not replaced since it is
used in a test that specifically checks the preservation of raw Cr values in
XPCJS.  The rule will be disabled for that instance.

Differential Revision: https://phabricator.services.mozilla.com/D28073
2020-05-05 17:41:36 +00:00
Bianca Danforth
700da17102 Bug 1598464 - Stop pre-filtering logins from the context menu to about:logins. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D72780
2020-04-29 00:14:04 +00:00
Andreea Pavel
26c02e4ad0 Backed out 7 changesets (bug 1602075, bug 1551574) for failing multiple dt e.g. browser_accessibility_context_menu_inspector.js on a CLOSED TREE
Backed out changeset d878be5e1884 (bug 1551574)
Backed out changeset 2b11feb2473d (bug 1602075)
Backed out changeset 1406b19b25e9 (bug 1602075)
Backed out changeset 0aa8307788b6 (bug 1602075)
Backed out changeset 418dbded9752 (bug 1602075)
Backed out changeset 2c19213df4d7 (bug 1602075)
Backed out changeset 98a4b4e8fda3 (bug 1602075)
2020-04-27 20:23:42 +03:00
Yura Zenevich
f25cf1bb96 Bug 1602075 - display Inspect Accessibility Properties menu item if devtools.accessibility.auto-init.enabled pref is set to true. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D71586
2020-04-27 14:00:18 +00:00
Andreas Farre
6adf2b375d Bug 1576188 - Handle save-as for cross process iframes. r=peterv
Depends on D70388

Differential Revision: https://phabricator.services.mozilla.com/D70389
2020-04-27 05:41:40 +00:00
Dorel Luca
c2d429f9a0 Backed out 2 changesets (bug 1576188) for Build bustage in docshell/base/BrowsingContext.cpp. CLOSED TREE
Backed out changeset 7e5e86986811 (bug 1576188)
Backed out changeset b731cbad59a8 (bug 1576188)
2020-04-24 23:02:11 +03:00
Andreas Farre
55a186014d Bug 1576188 - Handle save-as for cross process iframes. r=peterv
Depends on D70388

Differential Revision: https://phabricator.services.mozilla.com/D70389
2020-04-24 15:47:26 +00:00
Arthur Iakab
c278cf13d3 Backed out 2 changesets (bug 1576188) for causing browser-chrome failures on browser_persist_cross_origin_iframe.js
CLOSED TREE

Backed out changeset d2c102f8d898 (bug 1576188)
Backed out changeset 9ddd9a63d178 (bug 1576188)
2020-04-23 19:38:58 +03:00
Csoregi Natalia
230cef6455 Backed out 6 changesets (bug 1602075) for devtools failures caused by markup-context-menu.js. CLOSED TREE
Backed out changeset cf06e30be068 (bug 1602075)
Backed out changeset 51f01135d82f (bug 1602075)
Backed out changeset fbb30bd09d66 (bug 1602075)
Backed out changeset e1e570497527 (bug 1602075)
Backed out changeset 3aa7f4f31934 (bug 1602075)
Backed out changeset 7d568f0fa1e4 (bug 1602075)
2020-04-23 19:03:05 +03:00
Yura Zenevich
cfeeac415d Bug 1602075 - display Inspect Accessibility Properties menu item if devtools.accessibility.auto-init.enabled pref is set to true. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D71586
2020-04-23 14:40:17 +00:00
Andreas Farre
6a4f39685d Bug 1576188 - Handle save-as for cross process iframes. r=peterv
Depends on D70388

Differential Revision: https://phabricator.services.mozilla.com/D70389
2020-04-23 13:56:26 +00:00