This removes all the code for add-on performance watching from the
perfmonitoring component. This should mean that for add-on
compartments, we no longer trigger jank or CPOW monitoring in the JS
engine. This should result in minor performance improvements. As a
result, about:performance no longer reports on add-on performance
(but still reports on web page performance).
It also removes the AddonWatchers.jsm module and the related Nightly-
only UI (disabled in the parent commit) and strings. This UI wasn't
ready for release, there wasn't sufficient data it was creating
value for users, and there was some evidence that it didn't always
correctly identify the cause of performance issues, thus potentially
leading to user confusion or annoyance. Removing it therefore seemed
the right thing to do.
MozReview-Commit-ID: LsRwuaUtq6L
--HG--
extra : rebase_source : 92d4b775a7a7cbb5793e74eea471be81be974dda
The FX_PREFERENCES_CATEGORY_OPENED probe must be extended to version 59 to support the fallback "forked" preference implementation (in-content-old).
The switchToAdvancedSubPane within utilityOverlay's openPreferences must also remain until the fallback has been removed (bug 1349689).
Patch co-authored by Zack Herrick <herrickz@msu.edu> and Ziyan Long <lzylong@gmail.com>.
MozReview-Commit-ID: 1sx0Wj15yM7
--HG--
extra : rebase_source : 0266027fb3023d4cb155533193d6809d799de1e4
The FX_PREFERENCES_CATEGORY_OPENED probe must be extended to version 59 to support the fallback "forked" preference implementation (in-content-old).
The switchToAdvancedSubPane within utilityOverlay's openPreferences must also remain until the fallback has been removed (bug 1349689).
Patch co-authored by Zack Herrick <herrickz@msu.edu> and Ziyan Long <lzylong@gmail.com>.
MozReview-Commit-ID: 1sx0Wj15yM7
--HG--
extra : rebase_source : 29359bb726a0ac8164d7304a2453ffeb8009e990
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.
MozReview-Commit-ID: ANyg2qfo3Qx
--HG--
extra : rebase_source : 61d2aa91bf9474af3d72a5dea41b25dca442c1b7
checkEmptyPageOrigin was only checking the currentURI on the passed browser for about:blank, but
sometimes the currentURI isn't the whole picture. For example, SessionStore, after restoring a
window, can cause a number of blank tabs to start to load, be cancelled, and have their history
replaced. This results in a bunch of unrestored background tabs that appear to have currentURI
set to the URI that the tab will be sent to once restored, but a null content principal, since
the original about:blank load was stopped before it could complete.
We side-step this issue by checking both the currentURI and the documentURI for about:blank
when comparing against the null principal for checkEmptyPageOrigin.
MozReview-Commit-ID: Kzm0MthLqVM
--HG--
extra : rebase_source : e6a83368dd99d458333789f9d986e4706cd4d2bf
This patch removes the redundant lazy import of AppConstants.jsm from
browser/base/content/browser.js since it gets loaded previously as described
in the bug description.
MozReview-Commit-ID: EoSfSgedgNc
--HG--
extra : rebase_source : 8db27f79b9b43559ed4f94457592b092c5f75942
This patch updates browser printing code to make use of about:printpreview
when loading new tab for print preview. The same URI is used when the user
makes use of simplify page feature while print previewing.
MozReview-Commit-ID: DXHT71hpnWo
--HG--
extra : rebase_source : 9ccda6cd971931df70093177c6a9bdd16c93b7db
This changes the `relatedBrowser` property which held a <xul:browser> to the
more explicit `sameProcessAsFrameLoader` which takes an nsIFrameLoader.
This clarifies the purpose of the property and also (by switching to the frame
loader) makes it easier to set in some contexts.
MozReview-Commit-ID: LnEvSP8zkto
--HG--
extra : rebase_source : f9f4c07995ef39f1ccd5042e9ae3df37879423b6