Commit graph

2892 commits

Author SHA1 Message Date
Jonathan Sudiaman
c758f0801b Bug 1892429 - Create an expanded sidebar state r=sidebar-reviewers,fluent-reviewers,kcochrane,sclements,extension-reviewers,robwu
Adds an `expanded` property, which, if enabled, shows labels along with their respective icons within the sidebar menu. Currently, this property is not controllable from the UI. As I understand it, the follow-up bugs are responsible for addressing that.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f269729808eed19051bea5fe4eb41550ff94ce03

Differential Revision: https://phabricator.services.mozilla.com/D210187
2024-05-28 15:55:49 +00:00
Kelly Cochrane
d2c8a86ba1 Bug 1892012 - Add toolbar entry point for the sidebar as a default setting r=sidebar-reviewers,Gijs,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D209978
2024-05-17 16:37:16 +00:00
Sarah Clements
6c0504ee55 Bug 1892965 - Rename SidebarUI and SidebarLauncher r=sidebar-reviewers,places-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D208901
2024-05-03 15:20:15 +00:00
Norisz Fay
287ff7968f Backed out changeset 75c44ff76360 (bug 1892965) for causing multiple failures 2024-05-01 22:58:27 +03:00
Sarah Clements
be64abc5f7 Bug 1892965 - Rename SidebarUI and SidebarLauncher r=sidebar-reviewers,places-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D208901
2024-05-01 12:19:41 +00:00
Hanna Jones
36a699b418 Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-24 19:16:46 +00:00
Stanca Serban
72bee76688 Backed out changeset 58e1e96263b7 (bug 1803678) mochitests failures in test_confirm_delete_dialog.html. CLOSED TREE 2024-04-24 03:14:45 +03:00
Hanna Jones
dfc2a2c958 Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-23 19:28:47 +00:00
Gijs Kruitbosch
5e3abfba45 Bug 1890718 - move bookmark and library panelview event handling to not use inline event attributes, r=places-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D207881
2024-04-23 15:21:21 +00:00
Aron Cseh
a3a7c8505a Backed out changeset 421fd8a0360c (bug 1803678) for causing mochitest failures on browser_translations_select_panel_init_failure.js CLOSED TREE 2024-04-23 18:16:55 +03:00
Hanna Jones
a1661cdc87 Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-23 13:52:27 +00:00
Gijs Kruitbosch
889a1d2763 Bug 1890718 - move mouseover sync panel handlers away from inline handlers, r=sync-reviewers,lina
Differential Revision: https://phabricator.services.mozilla.com/D207877
2024-04-22 13:07:23 +00:00
Sammy Khamis
2cc00a036d Bug 1885064 - Ability to send and receive close remote tab pushes r=lina,desktop-theme-reviewers,firefox-desktop-core-reviewers ,emilio,Gijs,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D204556
2024-04-19 20:13:16 +00:00
Cristian Tuns
b9af4e8715 Backed out changeset ab9a461da1ee (bug 1885064) for causing xpcshell failures in test_commands_closetab.js CLOSED TREE 2024-04-19 15:45:22 -04:00
Sammy Khamis
2e05624dda Bug 1885064 - Ability to send and receive close remote tab pushes r=lina,desktop-theme-reviewers,firefox-desktop-core-reviewers ,emilio,Gijs,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D204556
2024-04-19 18:44:43 +00:00
Gijs Kruitbosch
484fe1f9b4 Bug 1890718 - remove sync/fxa pane inline command listeners, r=sync-reviewers,lina
This also tidies up some variable naming (we were passing 'panel's that were not, in fact, panels)
and removes some methods that we no longer call.

Bug 1690131 removed the last call to 'showRemoteTabsFromFxaMenu', bug 1562006 removed the last
call to 'showSidebarFromFxaMenu', AFAICT.

Differential Revision: https://phabricator.services.mozilla.com/D207452
2024-04-15 23:23:52 +00:00
Gijs Kruitbosch
a88ad44f4c Bug 1890718 - remove history pane inline command listeners, r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D207121
2024-04-15 23:23:51 +00:00
Gijs Kruitbosch
33a958aba0 Bug 1890718 - remove hamburger menu mainview inline command listeners, r=mossop,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D207120
2024-04-15 23:23:51 +00:00
Gijs Kruitbosch
24f569f7b5 Bug 1890718 - driveby: remove outdated mentions of proton, r=mossop,desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D207119
2024-04-15 23:23:50 +00:00
Cosmin Sabou
271aab4b32 Backed out 3 changesets (bug 1890718) for failing sevaral UI related bc tests. CLOSED TREE
Backed out changeset 3d91014dfcef (bug 1890718)
Backed out changeset 8c09e2028ad9 (bug 1890718)
Backed out changeset ff91ebffa8ab (bug 1890718)
2024-04-15 21:11:48 +03:00
Gijs Kruitbosch
f3a4c7b9ae Bug 1890718 - remove history pane inline command listeners, r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D207121
2024-04-15 14:45:52 +00:00
Gijs Kruitbosch
712fa1e60f Bug 1890718 - remove hamburger menu mainview inline command listeners, r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D207120
2024-04-15 14:45:51 +00:00
Gijs Kruitbosch
478948ca7c Bug 1890718 - driveby: remove outdated mentions of proton, r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D207119
2024-04-15 14:45:51 +00:00
Yi Xiong Wong
ba5a094f31 Bug 1880914 - Move BrowserOpenAddonsMgr. r=Gijs,extension-reviewers,settings-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,robwu,thecount
Differential Revision: https://phabricator.services.mozilla.com/D207110
2024-04-15 10:22:46 +00:00
Yi Xiong Wong
615598bb11 Bug 1880914 - Move BrowserForceEncodingDetection. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D207108
2024-04-15 10:22:45 +00:00
Gijs Kruitbosch
8452609904 Bug 1887717 - remove prompts.windowPromptSubDialog pref, r=mtigley,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D206685
2024-04-09 18:28:44 +00:00
Emilio Cobos Álvarez
637dd80a4f Bug 1832748 - Hit the urlbar container margin to test the context menu. r=Gijs
Test passes verify locally without this change on my machine, but this
seems to work on automation and seems no more hacky than the existing
100px offset:

  https://treeherder.mozilla.org/jobs?repo=try&revision=309ff5bb95505c69250f3674131b7b5b2453795c

Differential Revision: https://phabricator.services.mozilla.com/D207032
2024-04-09 13:41:33 +00:00
Yi Xiong Wong
7493f67b8d Bug 1880914 - Move BrowserFullScreen. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D206200
2024-04-08 17:21:02 +00:00
Emilio Cobos Álvarez
d2ae027d99 Bug 1832748 - Make click consistently hit space between urlbar and nav bar. r=dao
It seems that 1px offset isn't consistently for our synthesized click to
hit where it's supposed to. There's a 4px gap between urlbar and navbar
so let's increase this a bit.

Differential Revision: https://phabricator.services.mozilla.com/D206881
2024-04-08 11:38:28 +00:00
Nika Layzell
a3f9d28206 Bug 1887029 - Simplify TabAttributes to explicitly specify supported attributes, r=sessionstore-reviewers,sfoster,dao
The only tab attribute which is ever persisted by SessionStore is
"customizemode". This patch limits the logic to only allow persisting and
restoring this attribute.

The browser_attributes.js test is also updated to use the "customizemode"
attribute for testing, rather than a custom specified attribute.

Differential Revision: https://phabricator.services.mozilla.com/D205481
2024-04-05 16:42:51 +00:00
Yi Xiong Wong
cd747f1f77 Bug 1880914 - Move BrowserOpenTab. r=Gijs,webdriver-reviewers,perftest-reviewers,extension-reviewers,sessionstore-reviewers,tabbrowser-reviewers,home-newtab-reviewers,thecount,whimboo,dao,afinder,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D205529
2024-04-03 10:32:27 +00:00
Mike Conley
3fe4452342 Bug 1888419 - Put appmenu-remote-tabs-showmore.label into sentence case. r=kcochrane,fluent-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D206016
2024-04-02 14:03:46 +00:00
Butkovits Atila
159929cd10 Backed out 3 changesets (bug 1887029, bug 1886892) for causing failures at browser_all_files_referenced.js. CLOSED TREE
Backed out changeset 07f554ea4869 (bug 1887029)
Backed out changeset daa5f2355675 (bug 1886892)
Backed out changeset 389163cbd649 (bug 1886892)
2024-04-01 21:50:42 +03:00
Nika Layzell
0278634a50 Bug 1887029 - Simplify TabAttributes to explicitly specify supported attributes, r=sessionstore-reviewers,sfoster,dao
The only tab attribute which is ever persisted by SessionStore is
"customizemode". This patch limits the logic to only allow persisting and
restoring this attribute.

The browser_attributes.js test is also updated to use the "customizemode"
attribute for testing, rather than a custom specified attribute.

Differential Revision: https://phabricator.services.mozilla.com/D205481
2024-04-01 17:11:23 +00:00
Emily McMinn
079ff41016 Bug 1724300 - Remove What's New Panel, ToolbarPanelHub components & related tests & references r=desktop-theme-reviewers,omc-reviewers,aminomancer,pdahiya,emilio,devtools-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201867
2024-03-21 22:05:28 +00:00
Mark Banner
23a339fc7c Bug 1885723 - Fix more jsm references in browser/. r=Gijs,credential-management-reviewers,omc-reviewers,aminomancer,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D204843
2024-03-19 22:08:29 +00:00
Dave Townsend
a9a51bf046 Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D203005
2024-03-19 09:36:35 +00:00
Emilio Cobos Álvarez
0e321f79be Bug 232598 - Return null for unset attributes in XUL. r=smaug,devtools-reviewers,omc-reviewers,zombie,nchevobbe,settings-reviewers,application-update-reviewers,credential-management-reviewers,mossop,aminomancer,bytesized,issammani,sessionstore-reviewers,dao
I just got bit by this in bug 1873833, let's just fix it. There isn't
all that much stuff depending on it anymore.

Differential Revision: https://phabricator.services.mozilla.com/D204496
2024-03-18 09:15:07 +00:00
Emilio Cobos Álvarez
c225b05799 Bug 1871515 - Let nsMenuPopupFrame constrain the panelview, and remove _calculateMaxHeight. r=dao,desktop-theme-reviewers
When I rewrote nsMenuPopupFrame, I made sure percentage sizes worked so
that we could do stuff like this.

This removes some complex code, and improves the behavior on platforms
where screen sizes might not be 100% reliable.

Differential Revision: https://phabricator.services.mozilla.com/D204754
2024-03-16 16:22:06 +00:00
Gregory Pappas
40af85f061 Bug 1878629 - part 1: Use EventTarget.addEventListener to add system group event listeners instead of nsIEventListenerService (browser/) r=tabbrowser-reviewers,Gijs,dao
Differential Revision: https://phabricator.services.mozilla.com/D201043
2024-03-06 19:27:10 +00:00
Kelly Cochrane
0a51eb37a7 Bug 1850591 - Convert Firefox View's domain-specific navigation component to a global component r=desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,sclements,jules,hjones,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D193593
2024-02-20 18:58:04 +00:00
Mike Conley
34e17ab7c2 Bug 1878731 - Convert ToolbarPanelHub to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201124
2024-02-12 18:49:34 +00:00
Noemi Erli
426e311669 Backed out changeset f19610ecbade (bug 1850591) for causing failures in browser_opentabs_tab_indicators.js CLOSED TREE 2024-02-10 01:07:49 +02:00
Kelly Cochrane
fa0e1f01ae Bug 1850591 - Convert Firefox View's domain-specific navigation component to a global component r=desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,sclements,jules,hjones,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D193593
2024-02-09 22:01:30 +00:00
Karandeep
c0ef1d2a55 Bug 1852051 - Remove the Search Bar from the toolbar for users who haven't used it in 120 days. r=dao,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D195001
2024-02-08 16:28:42 +00:00
Thomas Wisniewski
a85a64846f Bug 1869823 - replace Report Broken Site's <menulist> with an <html:select> to simplify some code; r=emilio,Gijs,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D196677
2024-02-06 00:02:54 +00:00
Mike Conley
88baec62ec Bug 1877196 - Move ToolbarPanelHub.jsm to browser/components/asrouter. r=pdahiya,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D200082
2024-02-05 22:03:13 +00:00
Anna Yeddi
9d6e7d3d87 Bug 1877603 - Add an exception from a11y_checks for a click on a disabled control in a Customizable UI test. r=Gijs
We intentionally turn off a11y_checks, because the test case [disabled_button_in_panel() click is targeting a disabled control](https://searchfox.org/mozilla-central/rev/2a867dd1ab015c3ef24b774a57709fb3b3dc4961/browser/components/customizableui/test/browser_940307_panel_click_closure_handling.js#111) to confirm the click event won't come through.

This disabled control is not meant to be interactive and is not expected to be accessible.

Depends on D200115

Differential Revision: https://phabricator.services.mozilla.com/D200116
2024-02-01 15:35:54 +00:00
Anna Yeddi
8f59b22007 Bug 1877602 - Update the test case browser/components/customizableui/test/browser_981418-widget-onbeforecreated-handler.js that clicks on an unlabeled toolbarbutton. r=Gijs
The test "[browser/components/customizableui/test/browser_981418-widget-onbeforecreated-handler.js](https://searchfox.org/mozilla-central/rev/2a867dd1ab015c3ef24b774a57709fb3b3dc4961/browser/components/customizableui/test/browser_981418-widget-onbeforecreated-handler.js#35,53)" creates a test widget that has no `label` or `tooltiptext` property that is being clicked. But since its created toolbarbutton has no accessible name, it is being flagged by the a11y-checks. We could add "[tooltiptext](https://searchfox.org/mozilla-central/rev/2a867dd1ab015c3ef24b774a57709fb3b3dc4961/browser/components/customizableui/CustomizableUI.sys.mjs#4249)" property to make this test toolbarbutton accessible without triggering PanelMultiView to be adding header text, etc.

Since the issue will be resolved, we should also remove the `fail-if` notation from the test manifest.

Differential Revision: https://phabricator.services.mozilla.com/D200115
2024-02-01 15:35:53 +00:00
Gregory Pappas
6d4dbd8b79 Bug 1708289 - Implement AllowFileSelectionDialogs policy r=fluent-reviewers,mkaply,emilio,Gijs,bolsson,win-reviewers,rkraesig
Differential Revision: https://phabricator.services.mozilla.com/D199328
2024-02-01 00:48:24 +00:00