nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
918510 commits 1 branch 98 tags 6.4 GiB
Commit graph

3888 commits

Author SHA1 Message Date
Jonathan Sudiaman
c758f0801b Bug 1892429 - Create an expanded sidebar state r=sidebar-reviewers,fluent-reviewers,kcochrane,sclements,extension-reviewers,robwu 
Adds an `expanded` property, which, if enabled, shows labels along with their respective icons within the sidebar menu. Currently, this property is not controllable from the UI. As I understand it, the follow-up bugs are responsible for addressing that.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f269729808eed19051bea5fe4eb41550ff94ce03

Differential Revision: https://phabricator.services.mozilla.com/D210187
 2024-05-28 15:55:49 +00:00
Mark Banner
67039cecb0 Bug 1897508 - Separate out search engine icon updates into a separate notification subject. r=search-reviewers,settings-reviewers,mcheang 
This also avoids sending an engine-update Glean event for the default engine by not handling the engine-icon-update
notification in the update tracking code.

Differential Revision: https://phabricator.services.mozilla.com/D210838
 2024-05-24 09:10:05 +00:00
ujas.thakkar
f8c049e130 Bug 1874917 - Rename SearchTestUtils.promiseNewSearchEngine to SearchTestUtils.installOpenSearchEngine r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D211309
 2024-05-23 16:17:00 +00:00
Luca Greco
7ba63347da Bug 1771328 - Persist WebExtensions menus across sessions for extensions with a non-persistent background context. r=robwu 
Differential Revision: https://phabricator.services.mozilla.com/D207311
 2024-05-23 09:21:45 +00:00
Mark Banner
82ae63cedb Bug 1897770 - Improve .sjs file environment definitions in ESLint. r=frontend-codestyle-reviewers,extension-reviewers,Gijs 
This stops sjs files from picking up the test environments/configurations which means they get just the sjs environment
which is what we want.

Differential Revision: https://phabricator.services.mozilla.com/D210928
 2024-05-20 13:49:44 +00:00
Emilio Cobos Álvarez
56e43f3b42 Bug 1895870 - Fix browser_ext_browserAction_keyclick.js 
focus() is sync so there's no need to await stuff.

The delayed one needs to remain focusable for the focus fix-up not to
kick in.

MANUAL PUSH: Trivial test change CLOSED TREE
 2024-05-14 11:55:12 +02:00
Emilio Cobos Álvarez
57df8917ac Bug 1895870 - Simplify refresh driver observer set-up. r=smaug 
There's no call to AddRefreshObserver(FlushType::Layout), so we don't
need to track layout flushes. The only reason we need
mLayoutFlushObservers is so that reflows triggered from the style flush
get processed. But at that point, we can just flush layout directly.

There's no really good distinction between style flushes and layout
flushes with container queries anyways, so this makes the code simpler
to reason about.

Differential Revision: https://phabricator.services.mozilla.com/D209924
 2024-05-14 08:12:03 +00:00
Mark Banner
aaa4991a52 Bug 1836804 - Remove support for {moz:locale} parameter replacements in search URLs. r=search-reviewers,daleharvey 
Differential Revision: https://phabricator.services.mozilla.com/D209972
 2024-05-13 22:10:30 +00:00
Tomislav Jovanovic
9fd11ac2ef Bug 1889402 - Grant origin permissions during install for mv3 r=robwu 
Differential Revision: https://phabricator.services.mozilla.com/D208426
 2024-05-03 16:05:15 +00:00
Sarah Clements
6c0504ee55 Bug 1892965 - Rename SidebarUI and SidebarLauncher r=sidebar-reviewers,places-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D208901
 2024-05-03 15:20:15 +00:00
Christoph Kerschbaumer
081474dcf3 Bug 1888117: Update tests within browser/components/ to work with https-first enabled, r=rpl,mak 
Differential Revision: https://phabricator.services.mozilla.com/D205836
 2024-05-03 11:20:52 +00:00
Norisz Fay
287ff7968f Backed out changeset 75c44ff76360 (bug 1892965) for causing multiple failures 2024-05-01 22:58:27 +03:00
Sarah Clements
be64abc5f7 Bug 1892965 - Rename SidebarUI and SidebarLauncher r=sidebar-reviewers,places-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D208901
 2024-05-01 12:19:41 +00:00
Luca Greco
f27fafd179 Bug 1875480 - runtime.getContexts API method. r=robwu,extension-reviewers,geckoview-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D207865
 2024-04-30 17:26:18 +00:00
William Durand
dcf4447762 Bug 1893116 - Remove built-in abuse report UI. r=rpl,geckoview-reviewers,desktop-theme-reviewers,emilio,amejiamarmol 
This patch removes both the backend and UI code related to the built-in
abuse reporting feature. I kept the ability to disable abuse reporting
with the `extensions.abuseReport.enabled` pref. Other prefs related to
the old abuse reporting feature have been removed.

Some tests have been deleted because they aren't relevant anymore.

On the web API side, both the property and method have been removed
since only AMO consumes these APIs and AMO already supports the absence
of these APIs. That is also why GeckoView has been slightly updated.

We do not collect Telemetry with the new AMO (abuse report) form so
all the Telemetry bits have been removed as well.

Differential Revision: https://phabricator.services.mozilla.com/D208457
 2024-04-29 13:56:26 +00:00
Jonathan Sudiaman
d606daf39d Bug 1885883 - Create an extensions API in SidebarUI r=sclements,extension-reviewers,desktop-theme-reviewers,sidebar-reviewers,robwu,dao,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D206527
 2024-04-26 09:36:29 +00:00
Hanna Jones
36a699b418 Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D207445
 2024-04-24 19:16:46 +00:00
Stanca Serban
72bee76688 Backed out changeset 58e1e96263b7 (bug 1803678) mochitests failures in test_confirm_delete_dialog.html. CLOSED TREE 2024-04-24 03:14:45 +03:00
Hanna Jones
dfc2a2c958 Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D207445
 2024-04-23 19:28:47 +00:00
Aron Cseh
a3a7c8505a Backed out changeset 421fd8a0360c (bug 1803678) for causing mochitest failures on browser_translations_select_panel_init_failure.js CLOSED TREE 2024-04-23 18:16:55 +03:00
Hanna Jones
a1661cdc87 Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer 
Differential Revision: https://phabricator.services.mozilla.com/D207445
 2024-04-23 13:52:27 +00:00
Hiroyuki Ikezoe
4dc54a1176 Bug 1775568 - Await contentTransformsReceived() to ensure the iframe has been positioned. r=layout-reviewers,extension-reviewers,tnikkel,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D208085
 2024-04-22 21:47:42 +00:00
Rob Wu
4c5b18ecb6 Bug 1888866 - Improve dark theme support in options_ui r=willdurand,desktop-theme-reviewers,emilio 
This patch changes the behavior for extensions with an embedded
options_ui page (open_in_tab not false), that have specified the
"dark" value in the "color-scheme" meta tag or CSS property, AND
with the user having indicated the preference for dark theme support.
There are no changes when any of these conditions have not been met.

The "color-scheme" CSS property is the standard way for extensions (web
pages in general) to opt in to automatic dark theme support, e.g. by
changing the foreground color to white. Prior this patch, the
background was unconditionally white, which resulted in unreadable text
when the dark theme is enabled. This patch changes the default
background color to "Canvas", which is a special keyword that is dark
theme-aware (almost black - `rgb(28, 27, 34)` by default).

When `browser_style:true` is used (which is the default in MV2),
extension.css is activated, which unconditionally specifies a black
foreground color. To avoid a poor contrast with the new theme-dependent
background color, the color is now white when the dark theme is enabled.

This patch includes comprehensive test coverage, but the only tests
whose behavior changed by this patch are:
- options_ui_dark (background changed)
- options_ui_browser_style_true_dark (color, background changed)

Differential Revision: https://phabricator.services.mozilla.com/D207540
 2024-04-17 16:28:44 +00:00
Rob Wu
219a2e4891 Bug 1847216 - Ensure that tab.isArticle is true before toggleReaderMode r=willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D207707
 2024-04-17 16:24:33 +00:00
Rob Wu
c5bf455eb6 Bug 1891954 - Fix intermittent failure in browser_ext_menus_targetElement.js r=willdurand 
Differential Revision: https://phabricator.services.mozilla.com/D207703
 2024-04-17 16:24:30 +00:00
William Durand
0603e008af Bug 1797811 - Fallback to _execute_browser_action on MV3. r=rpl 
Differential Revision: https://phabricator.services.mozilla.com/D207454
 2024-04-17 12:21:17 +00:00
Yi Xiong Wong
ba5a094f31 Bug 1880914 - Move BrowserOpenAddonsMgr. r=Gijs,extension-reviewers,settings-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,robwu,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D207110
 2024-04-15 10:22:46 +00:00
William Durand
4385dce6fc Bug 1787379 - Add origin to runtime.MessageSender. r=robwu,zombie,geckoview-reviewers 
Note that we intentionally return "null" for null principals *and* file
scheme, which is - at the time of writing - different than Chromium.

Differential Revision: https://phabricator.services.mozilla.com/D206989
 2024-04-10 21:48:40 +00:00
William Durand
8486eeb420 Bug 1784920 - Add activeTab as permission for tabs.captureVisibleTab API. r=robwu,geckoview-reviewers,amejiamarmol 
Differential Revision: https://phabricator.services.mozilla.com/D206882
 2024-04-10 14:15:23 +00:00
Gijs Kruitbosch
8452609904 Bug 1887717 - remove prompts.windowPromptSubDialog pref, r=mtigley,extension-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D206685
 2024-04-09 18:28:44 +00:00
William Durand
3d7826fb7f Bug 1843866 - Add tab parameter to commands.onCommand. r=robwu 
Differential Revision: https://phabricator.services.mozilla.com/D206880
 2024-04-08 13:45:06 +00:00
Tomislav Jovanovic
8e9153592a Bug 1880162 - Decouple ExtensionChild namespace, rename BrowserExtensionContent, r=robwu 
And export public classes from ExtensionChild.sys.mjs directly.

Differential Revision: https://phabricator.services.mozilla.com/D206235
 2024-04-06 09:47:03 +00:00
Luca Greco
54f8b23662 Bug 1816960 - Add support for options_page as an alias for options_ui.page. r=robwu,amejiamarmol,geckoview-reviewers,extension-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D206429
 2024-04-04 19:13:27 +00:00
Joel Maher
a16cc21a29 Bug 1889412 - skip 25+ minute manifests on asan/tsan. r=aryx,extension-reviewers,settings-reviewers,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D206512
 2024-04-03 17:46:29 +00:00
Yi Xiong Wong
cd747f1f77 Bug 1880914 - Move BrowserOpenTab. r=Gijs,webdriver-reviewers,perftest-reviewers,extension-reviewers,sessionstore-reviewers,tabbrowser-reviewers,home-newtab-reviewers,thecount,whimboo,dao,afinder,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D205529
 2024-04-03 10:32:27 +00:00
Irene Ni
f701879f1c Bug 1876432 - Added support for custom themes as its own menu in Reader View. r=reader-mode-reviewers,fluent-reviewers,desktop-theme-reviewers,hjones,accessibility-frontend-reviewers,bolsson,devtools-reviewers,sfoster,cmkm,jules,ayeddi 
Differential Revision: https://phabricator.services.mozilla.com/D204519
 2024-04-02 00:08:46 +00:00
Yi Xiong Wong
bfa71f327f Bug 1880914 - Move BrowserHome. r=Gijs,extension-reviewers,sessionstore-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D205528
 2024-03-28 17:05:02 +00:00
Luca Greco
ed14dccfea Bug 1881820 - Tweak browser_ext_sidebarAction to cover the fix with a regression test. r=willdurand 
Depends on D205440

Differential Revision: https://phabricator.services.mozilla.com/D205753
 2024-03-27 13:18:34 +00:00
Anna Yeddi
cfeed29f4c Bug 1886925 - Add an exception from a11y_checks for a click on a non-interactive content in Webextensions. r=rpl 
We intentionally turn off this a11y check, because the following click is purposefully targeting a non-interactive content of the page to move cursor to the center of the entire browser UI to avoid issues with other focus/hover checks. We do this to avoid intermittent test failure.

Differential Revision: https://phabricator.services.mozilla.com/D205407
 2024-03-22 21:02:51 +00:00
Mark Banner
23a339fc7c Bug 1885723 - Fix more jsm references in browser/. r=Gijs,credential-management-reviewers,omc-reviewers,aminomancer,mtigley 
Differential Revision: https://phabricator.services.mozilla.com/D204843
 2024-03-19 22:08:29 +00:00
Emilio Cobos Álvarez
0e321f79be Bug 232598 - Return null for unset attributes in XUL. r=smaug,devtools-reviewers,omc-reviewers,zombie,nchevobbe,settings-reviewers,application-update-reviewers,credential-management-reviewers,mossop,aminomancer,bytesized,issammani,sessionstore-reviewers,dao 
I just got bit by this in bug 1873833, let's just fix it. There isn't
all that much stuff depending on it anymore.

Differential Revision: https://phabricator.services.mozilla.com/D204496
 2024-03-18 09:15:07 +00:00
Mark Banner
f4ce4f5c95 Bug 1885041 - Expand disallowing JSM based imports via ESLint to everything except for devtools. r=arai,omc-reviewers,aminomancer,zombie 
Differential Revision: https://phabricator.services.mozilla.com/D204441
 2024-03-13 17:38:28 +00:00
Mark Banner
126357c138 Bug 1882577 - Make nsISearchEngine.getIconURL an async function. r=search-reviewers,extension-reviewers,settings-reviewers,robwu,mcheang,mak 
Differential Revision: https://phabricator.services.mozilla.com/D203026
 2024-03-13 14:51:06 +00:00
mcheang
00f0ac69d1 Bug 1870685 - Ensure mochi browser chrome tests pass with search-config-v2 enabled. r=Standard8 
Depends on D202637

Differential Revision: https://phabricator.services.mozilla.com/D204133
 2024-03-11 17:07:13 +00:00
mcheang
4604a693b6 Bug 1870685 - Ensure tests outside of search pass with the new search configuration enabled. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D202637
 2024-03-11 17:07:12 +00:00
Dave Townsend
2c6aa89162 Bug 1864896: Autofix unused function arguments (webextensions). r=extension-reviewers,zombie 
Differential Revision: https://phabricator.services.mozilla.com/D202999
 2024-03-05 14:21:14 +00:00
Luca Greco
fe9b492d92 Bug 1881055 - Remove use of PromptParent.openContentPrompt for handling prompts originated from extensions options page embedded in about:addons. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D202237
 2024-03-05 10:51:22 +00:00
Joel Maher
2a0bfb5827 Bug 1881925 - standardize on more manifest conditions. r=aryx,credential-management-reviewers,devtools-reviewers,dom-storage-reviewers,omc-reviewers,nchevobbe,janv,issammani 
Differential Revision: https://phabricator.services.mozilla.com/D202663
 2024-03-05 02:14:17 +00:00
Sandor Molnar
ea4651cd79 Backed out 2 changesets (bug 1881055) for causing bc failures @ toolkit/mozapps/extensions/test/browser/browser_html_options_ui.js CLOSED TREE 
Backed out changeset 34d8664ec96a (bug 1881055)
Backed out changeset bdd79dc5ecab (bug 1881055)
 2024-03-04 18:15:32 +02:00
Luca Greco
e3f0c65621 Bug 1881055 - Remove use of PromptParent.openContentPrompt for handling prompts originated from extensions options page embedded in about:addons. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D202237
 2024-03-04 15:03:35 +00:00