Commit graph

5772 commits

Author SHA1 Message Date
Katherine Patenio
130ce23c4c Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 18:44:48 +00:00
Cristian Tuns
110cfccc1f Backed out 2 changesets (bug 1834831) for causing node failures with checkBundles CLOSED TREE
Backed out changeset 58b351a155c8 (bug 1834831)
Backed out changeset 1acbb5231d14 (bug 1834831)
2023-06-19 13:22:35 -04:00
Katherine Patenio
a73f6ec769 Bug 1834831 - update imports of browser/modules JSMs r=webdriver-reviewers,perftest-reviewers,zeid,extension-reviewers,settings-reviewers,pip-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,tabbrowser-reviewers,whimboo,mhowell,sgalich,robwu,sparky,Standard8,mconley,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D179169
2023-06-19 16:46:18 +00:00
Mike Conley
c276d2c608 Bug 1838871 - Fallback to previous behaviour of Ctrl-Shift-T if the in-memory undo actions list is empty. r=dao,sessionstore-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D181273
2023-06-16 20:22:46 +00:00
Butkovits Atila
4bf8c41fca Backed out changeset b8fcfbd2c5e9 (bug 1838871) for causing failures at browser_restoreLastClosedTabOrWindowOrSession.js. CLOSED TREE 2023-06-16 22:05:16 +03:00
Mike Conley
f0269d26fb Bug 1838871 - Fallback to previous behaviour of Ctrl-Shift-T if the in-memory undo actions list is empty. r=dao,sessionstore-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D181273
2023-06-16 17:57:23 +00:00
Dão Gottwald
e34bc91336 Bug 1835890 - Make sidebar switcher panel a normal menupopup. r=Itiel,extension-reviewers,mconley,rpl
Differential Revision: https://phabricator.services.mozilla.com/D179877
2023-06-15 14:14:43 +00:00
Sarah Clements
eb795dabb9 Bug 1833416 - modify undoClosedTab keyboard shortcut r=mconley,sfoster,sessionstore-reviewers,dao
* This patch expands this keyboard shortcut to support whichever of the three
last actions were taken - last tab closed, last window closed or session restore.
* Existing test file was renamed and additional cases added.

Differential Revision: https://phabricator.services.mozilla.com/D178965
2023-06-15 13:28:26 +00:00
Itiel
cf26dda371 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-06-14 17:16:39 +00:00
Greg Tatum
541edb6150 Bug 1837078 - Simplify the isRestrictedPage to use the scheme; r=nordzilla
Differential Revision: https://phabricator.services.mozilla.com/D180473
2023-06-14 15:00:15 +00:00
Narcis Beleuzu
796486f27d Backed out 19 changesets (bug 1837078, bug 1836505, bug 1835653) for bc failures on browser_test_mixed_content_download.js . CLOSED TREE
Backed out changeset 599b32019735 (bug 1836505)
Backed out changeset e7efea009a6c (bug 1837078)
Backed out changeset 72c0e162e5a8 (bug 1837078)
Backed out changeset c0776a2926de (bug 1837078)
Backed out changeset 464b57aa51cb (bug 1837078)
Backed out changeset 2d423bdf9b9a (bug 1837078)
Backed out changeset 47593c037f71 (bug 1837078)
Backed out changeset c30b954c1f48 (bug 1837078)
Backed out changeset 406ab7121048 (bug 1837078)
Backed out changeset b04e59be41cd (bug 1837078)
Backed out changeset 07dd77f0fa2b (bug 1837078)
Backed out changeset 847a4fccbb63 (bug 1837078)
Backed out changeset b698293af16a (bug 1837078)
Backed out changeset e2c376ce8337 (bug 1837078)
Backed out changeset 2c11cf745b67 (bug 1837078)
Backed out changeset 6dbd9581b622 (bug 1837078)
Backed out changeset 267c8b09163a (bug 1837078)
Backed out changeset e06f6601bd46 (bug 1837078)
Backed out changeset 744506cdcf2c (bug 1835653)
2023-06-14 05:20:20 +03:00
Greg Tatum
873fa8c415 Bug 1837078 - Simplify the isRestrictedPage to use the scheme; r=nordzilla
Differential Revision: https://phabricator.services.mozilla.com/D180473
2023-06-14 00:27:54 +00:00
Iulian Moraru
1a03d0ff0d Backed out changeset 76c5afdda762 (bug 1830679) for causing xpcshell failures on test_VariablesView_filtering-without-controller.js. CLOSED TREE 2023-06-12 22:03:43 +03:00
Itiel
d6ff8a9975 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,Gijs,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-06-12 17:16:35 +00:00
M. Sirringhaus
df63f90286 Bug 1832579 - Add prompt for invalid UV attempts r=fluent-reviewers,flod,keeler
Differential Revision: https://phabricator.services.mozilla.com/D177777
2023-06-12 16:39:13 +00:00
Mark Banner
6725448902 Bug 1834176 - Convert consumers of NetUtil.jsm to import the ES module directly. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D178589
2023-06-07 08:42:36 +00:00
Rob Wu
3c0c3a2676 Bug 1836482 - Replace AddonManager.jsm imports with AddonManager.sys.mjs r=Standard8,webcompat-reviewers,twisniewski
This patch was generated as follows:

Run:
`./mach esmify --imports . --prefix=toolkit/mozapps/extensions/AddonManager`
In the output there are linter/prettifier errors due to unused
XPCOMUtils or separate importESModule calls. These have been fixed
manually and verified with `./mach lint --outgoing`.

The `esmify` script also inserts many unwanted newlines around imports
that are broken on two lines due to length. Due to the number of these,
I fixed them programatically.

1. Create patch from the changes so far.
2. From the patch, delete all lines that consist of "+" (i.e. added blank line).
3. Reset the working dir and apply the revised patch.
4. Verify that the diff between step 1 and 3 looks reasonable.
5. Verify that this patch as a whole looks reasonable.

Commands:

```
git diff > rename.diff
:%g/^+$/d
git commit -va -m WIP-rename
git revert HEAD
git apply --recount rename.diff
git diff HEAD^  # and verify that the removed lines are ok.
git commit -va  # one last review to verify correctness of whole patch.
git rebase -i HEAD~3  # drop the WIP + reverted commit, pick only the last.
```

`git apply` has the `--recount` option to force it to ignore mismatches
in line counts, which happens because we deleted added lines (^+$)
without fixing up the line counts in the file headers.

Differential Revision: https://phabricator.services.mozilla.com/D179874
2023-06-04 13:44:45 +00:00
Tomislav Jovanovic
0ce2ec655c Bug 1835155 - Update Origin Controls state and message for quarantined extensions r=willdurand,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D179388
2023-05-31 20:42:36 +00:00
Saira Abdulla
9691ab4a5f Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 15:27:03 +00:00
Iulian Moraru
90b739a400 Backed out 2 changesets (bug 1824612) for causing dt failures on browser_dbg-features-source-tree.js. CLOSED TREE
Backed out changeset c3f38adc818e (bug 1824612)
Backed out changeset 58ba8bb3398a (bug 1824612)
2023-05-31 17:28:16 +03:00
Saira Abdulla
2e8db5969a Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
Depends on D175553

Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 10:21:37 +00:00
Sam Foster
a3004a21be Bug 1819675 - rename SessionStore.getClosedTabCount and getClosedTabData to getClosedTabCountForWindow and getClosedTabDataForWindow. r=dao,fxview-reviewers,kcochrane
- As closed tabs will change to mean closed tabs from all windows, rename these functions to make
  changes in later patches clearer when we mean closed tabs from this window specifically, or closed
  tabs for all private/non-private windows

Differential Revision: https://phabricator.services.mozilla.com/D177849
2023-05-30 18:54:12 +00:00
Masayuki Nakano
0a5fcdfa8f Bug 1835570 - Map fullscreen menu items and toolbar buttons to the shortcut key correctly r=Gijs
Just forgetting to map them to new `key_enterFullScreen`.  Note that both
`key_enterFullScreen` and `key_exitFullScreen` have same shortcut keys.
Therefore, mapping only to `key_enterFullScreen` must be fine for the
toggle UIs.

This patch does not contain the tests for checking the tooltip label on
the toolbar buttons because the shortcut key information does not appear
in the DOM tree.

Differential Revision: https://phabricator.services.mozilla.com/D179357
2023-05-30 10:01:03 +00:00
Greg Tatum
604917b659 Bug 1829687 - Add translations command to app menu; r=nordzilla,fluent-reviewers,flod
This adds the translations panel to the app menu, per UX's
recommendation. The menu is hidden by default until the translations
pref is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D179088
2023-05-27 16:24:20 +00:00
Karandeep
ebdf250671 Bug 1829616 - Convert consumers of dom/notification to import ES modules directly. r=Standard8,geckoview-reviewers,m_kato
Depends on D178836

Differential Revision: https://phabricator.services.mozilla.com/D178837
2023-05-26 08:28:47 +00:00
Dan Ballard
aac690a769 Bug 1828939 - Remove Share URL menu item when MOZ_PROXY_BYPASS_PROTECTION and restore Share by Email. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D175941
2023-05-25 08:34:00 +00:00
Katherine Patenio
9dd38d03ab Bug 1830418 - Convert browser/components/customizableui/CustomizableUI.jsm to ESM r=Standard8,devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D177423
2023-05-24 15:52:34 +00:00
Natalia Csoregi
e87ecf485e Backed out 3 changesets (bug 1834222, bug 1834176) for causing RemoteProcessMonitor failures. CLOSED TREE
Backed out changeset 346d3a1568dd (bug 1834222)
Backed out changeset ea1d8b634bfc (bug 1834176)
Backed out changeset 74d1880272d3 (bug 1834176)
2023-05-24 04:29:45 +03:00
Mark Banner
fbc15bdb60 Bug 1834176 - Convert NetUtil.jsm to be an ES system module. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D178589
2023-05-23 19:09:29 +00:00
Noemi Erli
aa2f146d78 Backed out 2 changesets (bug 1834176) for causing xpc failures in test_unload.js CLOSED TREE
Backed out changeset 57876d77a652 (bug 1834176)
Backed out changeset ae2f0837b528 (bug 1834176)
2023-05-23 12:14:37 +03:00
Mark Banner
e3e9a991b8 Bug 1834176 - Convert NetUtil.jsm to be an ES system module. r=arai,webdriver-reviewers,perftest-reviewers,valentin,extension-reviewers,devtools-reviewers,sync-reviewers,cookie-reviewers,robwu,afinder,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D178589
2023-05-23 08:13:08 +00:00
Mark Banner
130a655906 Bug 1826062 - Automatic fixes for upgrading Prettier to 2.8.8. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,calu
Differential Revision: https://phabricator.services.mozilla.com/D177027
2023-05-20 12:26:53 +00:00
Mark Banner
8219a5c503 Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Katherine Patenio
ac4145f34d Bug 1830419 - Convert PanelMutiView.jsm and CustomizableUITestUtils.jsm in browser/components/customizableui to ESMs r=search-reviewers,Standard8,devtools-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D178362
2023-05-18 18:34:51 +00:00
Iulian Moraru
170aaf5bb7 Backed out changeset bbb3bbd9b6af (bug 1830679) for causing dt failures on browser_storage_cache_delete.js. CLOSED TREE 2023-05-18 22:09:25 +03:00
Itiel
076aaf6671 Bug 1830679 - Convert element.setAttribute(data-l10n-{id,args}) uses in the codebase to document.l10n.setAttributes(element, id, args) r=eemeli,willdurand,extension-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,mconley,Standard8,jdescottes,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D176791
2023-05-18 17:19:45 +00:00
Pushpanjali
235f25ea9c Bug 1822010 - Convert toolkit/components/url-classifier to ES modules. r=perftest-reviewers,webcompat-reviewers,geckoview-reviewers,devtools-reviewers,twisniewski,valentin,m_kato,anti-tracking-reviewers,timhuang,sparky
Differential Revision: https://phabricator.services.mozilla.com/D173390
2023-05-18 12:21:12 +00:00
Abhishek Madan
ba1d4a0dfc Bug 1831363 - Converted SitePermissions.jsm to ES modules and all of its corresponding references. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D177380
2023-05-17 14:45:26 +00:00
Gijs Kruitbosch
9ecca59317 Bug 1833585 - don't try to search for whitespace-only clipboard contents when middle-clicking new tab, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D178292
2023-05-17 13:18:36 +00:00
John Schanck
53e2e3ea9b Bug 1831392 - add an excluded WebAuthn credential prompt. r=keeler
Depends on D177944

Differential Revision: https://phabricator.services.mozilla.com/D178113
2023-05-15 23:26:24 +00:00
John Schanck
ecfd04a749 Bug 1828206 - clarify WebAuthn user presence prompts. r=keeler
Differential Revision: https://phabricator.services.mozilla.com/D177944
2023-05-15 23:26:24 +00:00
Eemeli Aro
feea556fc5 Bug 1832186 - Migrate popup warning strings to Fluent. r=mconley,fluent-reviewers,flod
The Fluent migration will show a diff for two en-US messages:

- `popup-warning-message` singular variant does not include `{ $popupCount }`, so is more appropriately using `1` rather than `one` as its key.
- `popup-warning-exceeded-message` has only one variant in English, but using the plural selector forces its use for new locales.

Differential Revision: https://phabricator.services.mozilla.com/D177666
2023-05-15 10:52:25 +00:00
Karandeep
3efcb85a15 Bug 1824609 convert consumers of toolkit/components/thumbnails/ to import ES modules directly. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D177197
2023-05-10 20:00:58 +00:00
Brice Laurencin
1c8c333cb5 Bug 1418462 - Middleclick on new tab button launch clipboard r=Gijs
Original code from bruntonross@protonmail.com,
adapted to current Firefox version.

Differential Revision: https://phabricator.services.mozilla.com/D170097
2023-05-10 10:08:24 +00:00
Stanca Serban
692d727b5e Backed out changeset 50c9a0bea4c6 (bug 1418462) for causing mochitests failures in browser_middleClick.js. CLOSED TREE 2023-05-10 02:50:36 +03:00
John Schanck
8b761c0a6d Bug 1831394 - omit the retries left counter from the invalid PIN prompt when it is large. r=keeler,fluent-reviewers,flod
The PIN for a user's security key will be temporarily blocked after three
failed PIN entry attempts, but the "retries left" counter in the invalid PIN
prompt is the (typically larger) number of attempts left before the PIN is
permanently blocked. This patch makes it so that the retries left counter is
only shown when it is equal to 1, 2, or 3.

Differential Revision: https://phabricator.services.mozilla.com/D177294
2023-05-09 21:29:37 +00:00
Jonathan Sudiaman
a911f374bc Bug 1820979 - Remove instant apply bookmarks panels code r=mak
Remove the `browser.bookmarks.editDialog.delayedApply.enabled` pref, and for all usages in conditional branches, assume that it is `true`. (Since we want to be using delayed apply logic going forward.)

`delayed_apply` spinoffs of tests are removed and merged with their instant apply counterparts. The only test removed without a corresponding spinoff is `browser_editBookmark_tags_liveUpdate.js`. That test is checking whether tags are updated in the edit dialog, if they are updated from a different place. The problem is that we don't really want this behavior anymore. It was previously set to only run with `browser.bookmarks.editDialog.delayedApply.enabled` set to `false`, but now that it's no longer configurable, it made most sense to simply get rid of this test.

https://treeherder.mozilla.org/jobs?revision=c0741eca62212a75a9dd52fc2c5c2b6c34f9f2d7&repo=try

Differential Revision: https://phabricator.services.mozilla.com/D176370
2023-05-09 21:03:19 +00:00
Brice Laurencin
3bdbccf607 Bug 1418462 - Middleclick on new tab button launch clipboard r=Gijs
Original code from bruntonross@protonmail.com,
adapted to current Firefox version.

Differential Revision: https://phabricator.services.mozilla.com/D170097
2023-05-09 20:50:04 +00:00
Katherine Patenio
485f34bf93 Bug 1830421 - convert CustomizableWidgets, CustomizeMode, DragPositionManager and SearchWidgetTracker in browser/components/customizableui to ESMs r=Standard8,ochameau
Differential Revision: https://phabricator.services.mozilla.com/D176825
2023-05-03 18:05:26 +00:00
John Schanck
92fb6d7ad4 Bug 1830944 - vendor authenticator-rs v0.4.0-alpha14. r=keeler,supply-chain-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D176938
2023-05-03 16:37:45 +00:00