Commit graph

502 commits

Author SHA1 Message Date
Mark Banner
14aedbb785 Bug 1729460 - Change users of defineLazyServiceGetter(s) to use Services.* where appropriate. r=mossop,webdriver-reviewers,extension-reviewers,whimboo,robwu
Differential Revision: https://phabricator.services.mozilla.com/D124838
2021-09-10 12:09:49 +00:00
Noemi Erli
e0f4b9b5fe Backed out 2 changesets (bug 1729460) for causing newtab failures CLOSED TREE
Backed out changeset 5617839462be (bug 1729460)
Backed out changeset 6d52fde3ee0e (bug 1729460)
2021-09-10 13:14:12 +03:00
Mark Banner
3cfdb5c41a Bug 1729460 - Change users of defineLazyServiceGetter(s) to use Services.* where appropriate. r=mossop,webdriver-reviewers,extension-reviewers,whimboo,robwu
Differential Revision: https://phabricator.services.mozilla.com/D124838
2021-09-10 09:38:42 +00:00
Stefan Zabka
873a6170d3 Bug 1711759 - Ask user for confirmation in Forget about this site. r=pbz,Standard8,flod
Differential Revision: https://phabricator.services.mozilla.com/D120363
2021-09-02 11:55:52 +00:00
Gijs Kruitbosch
a8db92c057 Bug 1714478 - go back to using 'edit' and 'delete' for bookmark menus, r=mak,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D124045
2021-09-01 16:08:50 +00:00
Nicholas Fason
0c0043f901 Bug 1702708 - Hyphenate places context menu attributes r=mak
Differential Revision: https://phabricator.services.mozilla.com/D121583
2021-08-03 14:03:03 +00:00
Paul Zuehlcke
cb8ac7af93 Bug 1705028 - Update places forget-this-site to clear storage by base domain. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D113495
2021-05-26 13:49:36 +00:00
Mark Banner
e05a30a57b Bug 1711517 - Add ESLint jsdoc validation to browser/components/places. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D115233
2021-05-18 16:27:44 +00:00
Bernard Igiri
51f18983e9 Bug 1705105 - Update bookmarks folder context menu r=fluent-reviewers,mak,flod
Changed the text on the edit and delete folder buttons and moved position of the Sort By Name menu item.

Differential Revision: https://phabricator.services.mozilla.com/D112110
2021-04-16 17:27:00 +00:00
Marco Bonardo
9e870cd715 Bug 1700929 - Restore Open All in tabs in some Places context menus. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D110478
2021-04-02 07:38:51 +00:00
Marco Bonardo
e8cc844fc4 Bug 1700929 - Restore Places context menu Delete on mixed selection. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D110477
2021-04-02 07:38:51 +00:00
Marco Bonardo
b0165a707c Bug 1700929 - Introduce an 'hideifsingleclickopens' attribute to show/hide Open in the Places context menu. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D110476
2021-04-02 07:38:51 +00:00
Marco Bonardo
5a50e7a201 Bug 1700929 - Do some renames and cleanup comments a bit in bookmarks context menu code. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D110475
2021-04-02 07:38:50 +00:00
Micah Tigley
4f62b29aa6 Bug 1693139 - Open bookmarks dialogs with in-window modal, plus some styling to input fields. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D108870
2021-03-30 00:56:35 +00:00
Erica Wright
7563ded7df Bug 1692668 - Update bookmarks context menu for clarity. r=Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D106046
2021-03-02 15:34:56 +00:00
Butkovits Atila
f8cb3c7d6a Backed out changeset b3df95f06470 (bug 1692668) for causing failure at browser_bookmark_change_location.js. CLOSED TREE 2021-02-26 23:07:49 +02:00
Erica Wright
978fc6c4ca Bug 1692668 - Update bookmarks context menu for clarity. r=Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D106046
2021-02-26 18:38:07 +00:00
Tom Schuster
d0d823f729 Bug 1689827 - Remove length parameter from JS callers of setTransferData. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D103555
2021-02-01 12:05:12 +00:00
Jared Wein
7465d643ed Bug 1003364 - Add Bookmarks Toolbar view options to the context menu of the Bookmarks Toolbar. r=mak,Gijs
This patch doesn't show the view options when right-clicking on folders or bookmarks within the toolbar, and also doesn't include an item to enter Customize mode to keep the menu from growing too large.

Differential Revision: https://phabricator.services.mozilla.com/D95798
2020-11-05 23:00:47 +00:00
Narcis Beleuzu
61b409c94c Backed out 2 changesets (bug 1674160, bug 1003364) for bc failures on browser_bookmarks_toolbar_context_menu_view_options.js
Backed out changeset b4ffebacc1b8 (bug 1674160)
Backed out changeset bfe8bc960f45 (bug 1003364)
2020-11-05 22:55:59 +02:00
Jared Wein
d3a8c969bc Bug 1003364 - Add Bookmarks Toolbar view options to the context menu of the Bookmarks Toolbar. r=mak,Gijs
This patch doesn't show the view options when right-clicking on folders or bookmarks within the toolbar, and also doesn't include an item to enter Customize mode to keep the menu from growing too large.

Differential Revision: https://phabricator.services.mozilla.com/D95798
2020-11-05 19:09:18 +00:00
Sonia Singla
66fbd11f99 Bug 1655400 - Enable ESLint rule no-setter-return for all of places. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D85021
2020-07-29 11:19:09 +00:00
Kris Maglione
9d78661f88 Bug 1649221: Update ChromeUtils.generateQI callers to pass strings. r=mccr8,remote-protocol-reviewers,marionette-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,preferences-reviewers,agi,whimboo,Bebe,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D81594
2020-07-10 23:58:28 +00:00
Marco Bonardo
66e30e7da6 Bug 1627361 - Stop examining the clipboard data when updating Places commands. r=Standard8
We used to read the contents of the clipboard to tell if paste was enabled,
that unfortunately means updating commands was extremely slow for large
clipboard data.
After this change we only check the data flavors. This means paste will be
enabled more often, even for unsupported strings, but commands updating will
be much faster. Places updates commands often, so this is quite useful.

Differential Revision: https://phabricator.services.mozilla.com/D75202
2020-05-15 14:20:58 +00:00
Ian Moody
011b59d595 Bug 1536556 - Replace raw thrown Cr.ERRORs with Components.Exception. r=mossop,remote-protocol-reviewers,marionette-reviewers,whimboo,necko-reviewers,geckoview-reviewers,valentin,agi
Raw Cr.ERROR don't get stack information, same as throwing JS literals instead
of `new Error()`s.

This was done automatically with a new eslint rule that will be introduced in
the next commit.  One instance of a raw Cr.ERROR was not replaced since it is
used in a test that specifically checks the preservation of raw Cr values in
XPCJS.  The rule will be disabled for that instance.

Differential Revision: https://phabricator.services.mozilla.com/D28073
2020-05-05 17:41:36 +00:00
Mark Banner
88fb3a72de Bug 1622243 - Implement the bookmark pages option in the library window. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D68776

--HG--
extra : moz-landing-system : lando
2020-04-07 12:56:19 +00:00
Ed Lee
acb960676c Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-reviewers,webcompat-reviewers,perftest-reviewers,sparky,whimboo,denschub
Differential Revision: https://phabricator.services.mozilla.com/D66128

--HG--
extra : moz-landing-system : lando
2020-03-13 23:38:52 +00:00
monikamaheshwari
9d60e0d578 Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629

--HG--
extra : moz-landing-system : lando
2019-09-14 09:39:26 +00:00
Gijs Kruitbosch
dca75bf8ea Bug 1567414 - ensure we display the 'Open' context menu entry on bookmarks when they load in new tabs by default, r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D39025

--HG--
extra : moz-landing-system : lando
2019-07-23 15:24:38 +00:00
Hamzah
7d7ca018fd Bug 1559956 - UX: Bookmark bar context menu item "Open in New Tab" is not consistent with anchor link context menu. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D37197

--HG--
extra : moz-landing-system : lando
2019-07-15 18:38:01 +00:00
Victor Porof
1f830c96da Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042

--HG--
extra : source : d3afcafdce650a6f36cebbc126ee93b17f13cf52
2019-07-05 09:53:32 +02:00
Mihir
f52d50a249 Bug 543314 - Allow bookmarks to be moved (as well as copied) from a bookmarks search. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D32629

--HG--
extra : moz-landing-system : lando
2019-06-11 20:33:51 +00:00
Boris Zbarsky
5eb248348f Bug 1557847. Stop using [array] in nsIClipboard. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D34243

--HG--
extra : moz-landing-system : lando
2019-06-09 01:06:39 +00:00
Kris Maglione
e930b89c34 Bug 1514594: Part 3 - Change ChromeUtils.import API.
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8

This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:

  ChromeUtils.import("resource://gre/modules/Services.jsm");

is approximately the same as the following, in the new model:

  var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");

Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs

This was done using the followng script:

https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8

Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D16750

--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
2019-01-17 10:18:31 -08:00
Toby Ward
b7922e7f75 Bug 1435562 - browser.tabs.warnOnOpen is now respected when opening multiple items from the library. r=Standard8
- Unified openContainerNodeInTabs and openURINodesInTabs in PlacesUIUtils into openMultipleLinksInTabs
- Users are now warned when the amount of links to be opened is equal to or exceeds browser.tabs.maxOpenBeforeWarn

Differential Revision: https://phabricator.services.mozilla.com/D12983

--HG--
extra : moz-landing-system : lando
2018-12-10 17:04:18 +00:00
Csoregi Natalia
322dfaf9c2 Backed out changeset 81a6b32f2a8b (bug 1435562) for causing Bug 1512180. a=backout 2018-12-06 14:20:20 +02:00
Toby Ward
16581f028e Bug 1435562 - browser.tabs.warnOnOpen is now respected when opening multiple items from the library. r=Standard8
- Unified openContainerNodeInTabs and openURINodesInTabs in PlacesUIUtils into openMultipleLinksInTabs
- Users are now warned when the amount of links to be opened is equal to or exceeds browser.tabs.maxOpenBeforeWarn

Differential Revision: https://phabricator.services.mozilla.com/D12983

--HG--
extra : moz-landing-system : lando
2018-12-04 19:20:59 +00:00
Tom Schuster
5a9d2a428c Bug 1493292 - Remove aDataLen parameters from nsITransferable.getTransferData. r=smaug
Depends on D11200

Differential Revision: https://phabricator.services.mozilla.com/D11201

--HG--
extra : moz-landing-system : lando
2018-11-20 16:59:56 +00:00
Csoregi Natalia
df7483024d Backed out 6 changesets (bug 1493292) for bustage on /nsTransferable.cpp. CLOSED TREE
Backed out changeset f198bf91320b (bug 1493292)
Backed out changeset 6487aa307123 (bug 1493292)
Backed out changeset f2cabd69c568 (bug 1493292)
Backed out changeset 71430fceb4a3 (bug 1493292)
Backed out changeset 3a9b6d65d8c7 (bug 1493292)
Backed out changeset 55769869037c (bug 1493292)
2018-11-20 17:13:18 +02:00
Tom Schuster
b292ec7c2c Bug 1493292 - Remove aDataLen parameters from nsITransferable.getTransferData. r=smaug
Depends on D11200

Differential Revision: https://phabricator.services.mozilla.com/D11201

--HG--
extra : moz-landing-system : lando
2018-11-20 14:47:02 +00:00
Mark Banner
4eabeccb20 Bug 1502954 - Remove livemarks code from toolkit. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D12118

--HG--
extra : moz-landing-system : lando
2018-11-20 13:29:54 +00:00
Tom Schuster
8c1f89b6e5 Bug 1503588 - Remove aDataLen parameter from nsITransferable.getAnyTransferData. r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D10441

--HG--
extra : moz-landing-system : lando
2018-11-02 11:02:25 +00:00
Marco Bonardo
d77d9c899f Bug 1502655 - Remove remaining frontend livemarks code. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D9992

--HG--
extra : moz-landing-system : lando
2018-10-29 13:18:17 +00:00
Mark Banner
8b5c6973b6 Bug 1501811 - Remove livemarks support from browserPlacesViews/treeView. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D9701

--HG--
extra : moz-landing-system : lando
2018-10-26 07:40:15 +00:00
Marco Bonardo
59f27ba50d Bug 1477671 - Stop allowing creation of new live bookmarks from the backend. r=standard8
Differential Revision: https://phabricator.services.mozilla.com/D7083

--HG--
extra : rebase_source : 89475d197e412ad5756eb1e9f4b9a4ea06dbf2a2
2018-10-06 10:32:13 +01:00
Mark Banner
bf2dba5c9f Bug 1476228 - Enable comma-dangle ESLint rule for Places directories. r=mikedeboer
MozReview-Commit-ID: K8HcZfyF4Sz

Differential Revision: https://phabricator.services.mozilla.com/D3796

--HG--
extra : moz-landing-system : lando
2018-08-22 15:44:43 +00:00
Brian Grinstead
abf1620630 Bug 1479125 - Migrate calls that expect an element to be returned to use element variation firstChild etc to firstElementChild etc;r=Paolo
This allows the JS to work in HTML documents, where whitespace is preserved. In XUL
documents, whitespace is ignored when parsing so text nodes are generally not returned.

The following changes were made, with manual cleanups as necessary (i.e. when firstChild actually
refers to a text node, or when firstChild is used in a loop to empty out an element):

  firstChild->firstElementChild
  lastChild->lastElementChild
  nextSibling->nextElementSibling
  previousSibling->previousElementSibling
  childNodes->children

MozReview-Commit-ID: 95NQ8syBhYw

--HG--
extra : rebase_source : 186d805f7a2a56694dda9032aceac2dfe5424753
2018-08-08 15:22:53 -07:00
Marco Bonardo
23cf556fe1 Bug 1477996 - Move getURIsForTag to the bookmarking API. r=Standard8,lina
The tagging API is being merged into the bookmarking API. This is part of it.

Differential Revision: https://phabricator.services.mozilla.com/D2450

--HG--
extra : moz-landing-system : lando
2018-07-27 15:16:57 +00:00
Brian Grinstead
4121127ab8 Bug 1445764 - Move Places imports from XUL to JS for the Places documents;r=standard8
MozReview-Commit-ID: 1LKRgTlaupu

--HG--
extra : rebase_source : ac36bf61df6d77f495e018ac6a972d78e3cbc173
2018-07-03 14:26:49 -07:00
Mark Banner
5b8ba7f27e Bug 1452645 - Remove load in sidebar functionality. r=lina,mak
Based on patch by mixedpuppy.

MozReview-Commit-ID: BZwOtr4VbCH

--HG--
extra : rebase_source : 2e3ad3fedaf82d0e5d3db9bcebf1c2faa46447e7
2018-06-06 21:00:45 +01:00