Commit graph

1025 commits

Author SHA1 Message Date
sunil mayya
1599e97480 Bug 1874132 - remove auth headers from preflight request for cross origin requests. r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D204608
2024-03-18 08:48:10 +00:00
Valentin Gosu
589e6de8c6 Bug 1884645 - Add NS_HTTP_ON_BEFORE_STOP_REQUEST_TOPIC r=necko-reviewers,kershaw
This notification would be sent by HttpChannelChild before
calling onStopRequest for a channel.

This patch also updates some comments regarding the on stop topic
which referenced the non-existent http-on-stop-connect

Differential Revision: https://phabricator.services.mozilla.com/D204482
2024-03-13 11:50:06 +00:00
Peter Van der Beken
62bdf442eb Bug 1640839 - Stop generating a sentinel value at the end of WebIDL enums. r=mccr8,jgilbert,media-playback-reviewers,padenot
Differential Revision: https://phabricator.services.mozilla.com/D201344
2024-03-02 07:50:25 +00:00
Natalia Csoregi
8c2521e9d5 Backed out 13 changesets (bug 1640839) for causing bustage on Element.cpp CLOSED TREE
Backed out changeset 179ceb82c9e5 (bug 1640839)
Backed out changeset 73f498a821f0 (bug 1640839)
Backed out changeset dc2d3d0e0365 (bug 1640839)
Backed out changeset ddc989ac0509 (bug 1640839)
Backed out changeset e595bb3feea8 (bug 1640839)
Backed out changeset c85aca04e27f (bug 1640839)
Backed out changeset 98e8e3a4047a (bug 1640839)
Backed out changeset 59ef180517db (bug 1640839)
Backed out changeset af2f5e293662 (bug 1640839)
Backed out changeset 89aa6d9dc598 (bug 1640839)
Backed out changeset 67b722a722f9 (bug 1640839)
Backed out changeset 24a9665c6ced (bug 1640839)
Backed out changeset d93f199385e9 (bug 1640839)
2024-03-01 18:23:08 +02:00
Peter Van der Beken
763356e4fb Bug 1640839 - Stop generating a sentinel value at the end of WebIDL enums. r=mccr8,jgilbert,media-playback-reviewers,padenot
Differential Revision: https://phabricator.services.mozilla.com/D201344
2024-03-01 14:31:15 +00:00
Tim Huang
925645c429 Bug 1849864 - Don't recalculate the userAgent header if it has been modified. r=tjr,jesup,necko-reviewers,devtools-reviewers
The userAgent header can be modified in several ways, such as using the
header field to set a custom userAgent header for a fetch request. We
want to preserve the custom header, so we shouldn't recalculate the
userAgent header if it's been overridden after the channel was created.
Otherwise, the custom header won't work.

Differential Revision: https://phabricator.services.mozilla.com/D197655
2024-01-17 13:18:21 +00:00
Malte Juergens
7c11f39184 Bug 1857894 - Recalculate referrer based on original referrer after non-HSTS HTTPS upgrade r=necko-reviewers,freddyb,kershaw
Per fetch spec [1], we should perform CSP upgrade-insecure-requests and mixed
content upgrades before determining the referrer, while HSTS upgrades happen
after the referrer is determined. In our implementation, we determine the
referrer before all the upgrades, so we need to recalculate the referrer
after we upgrade through anything but HSTS.

[1] https://fetch.spec.whatwg.org/#main-fetch

Differential Revision: https://phabricator.services.mozilla.com/D193417
2024-01-17 09:36:53 +00:00
Iulian Moraru
8ecc4d2b75 Backed out 2 changesets (bug 1849864) for causing multiple failures. CLOSED TREE
Backed out changeset c57d859580d0 (bug 1849864)
Backed out changeset 8a5a6b997e2a (bug 1849864)
2024-01-16 19:39:56 +02:00
Tim Huang
18a9840783 Bug 1849864 - Don't recalculate the userAgent header if it has been modified. r=tjr,jesup,necko-reviewers,devtools-reviewers
The userAgent header can be modified in several ways, such as using the
header field to set a custom userAgent header for a fetch request. We
want to preserve the custom header, so we shouldn't recalculate the
userAgent header if it's been overridden after the channel was created.
Otherwise, the custom header won't work.

Differential Revision: https://phabricator.services.mozilla.com/D197655
2024-01-16 16:06:34 +00:00
Tom Schuster
b158ada37d Bug 1871581 - Add missing (but implicitly used) ExtContentPolicy::TYPE_WEB_IDENTITY. r=necko-reviewers,jesup
Differential Revision: https://phabricator.services.mozilla.com/D197190
2024-01-03 10:54:12 +00:00
Sean Feng
ba1dd25a05 Bug 1722322 - Fix two bugs in nsContentSecurityManager::GetSerializedOrigin r=necko-reviewers,dragana
The first bug is according to https://fetch.spec.whatwg.org/#serializing-a-request-origin,
the algorithm should return "null" if the request has a redirected-tainted origin.

The second bug is the comparison of whether this is a cross origin redirect missed
the `not operator`.

Differential Revision: https://phabricator.services.mozilla.com/D151078
2023-11-02 20:53:35 +00:00
Sandor Molnar
a4163792c6 Backed out 7 changesets (bug 1722322) for causing bp-nu bustages
Backed out changeset 0ebd32e273b8 (bug 1722322)
Backed out changeset 7a75717f127c (bug 1722322)
Backed out changeset c2a6440a83d7 (bug 1722322)
Backed out changeset 9955756855bd (bug 1722322)
Backed out changeset 37fccb407777 (bug 1722322)
Backed out changeset f52b1f28f753 (bug 1722322)
Backed out changeset 0121c8cf5d2f (bug 1722322)
2023-11-02 21:27:24 +02:00
Sean Feng
5a55dc91cf Bug 1722322 - Fix two bugs in nsContentSecurityManager::GetSerializedOrigin r=necko-reviewers,dragana
The first bug is according to https://fetch.spec.whatwg.org/#serializing-a-request-origin,
the algorithm should return "null" if the request has a redirected-tainted origin.

The second bug is the comparison of whether this is a cross origin redirect missed
the `not operator`.

Differential Revision: https://phabricator.services.mozilla.com/D151078
2023-11-02 17:04:46 +00:00
sunil mayya
ec558bbf4d Bug 1851992 - move assignment of mTransferSize,mEncodedBodySize from HttpChannelChild::OnStopRequest to HttpChannelChild::OnStopRequest::ProcessOnStopRequest. r=necko-reviewers,jesup
Differential Revision: https://phabricator.services.mozilla.com/D191291
2023-10-27 13:30:13 +00:00
Narcis Beleuzu
722f6a1679 Backed out 6 changesets (bug 1851992) for DT failure on browser_net_image_cache.js . CLOSED TREE
Backed out changeset 3ceaf46f8f55 (bug 1851992)
Backed out changeset c9d322362e22 (bug 1851992)
Backed out changeset 673df3f83249 (bug 1851992)
Backed out changeset 46e18c56dd39 (bug 1851992)
Backed out changeset f9f9143ac713 (bug 1851992)
Backed out changeset 38c40d735ab7 (bug 1851992)
2023-10-24 13:16:40 +03:00
sunil mayya
2d118bf578 Bug 1851992 - move assignment of mTransferSize,mEncodedBodySize from HttpChannelChild::OnStopRequest to HttpChannelChild::OnStopRequest::ProcessOnStopRequest. r=necko-reviewers,jesup
Differential Revision: https://phabricator.services.mozilla.com/D191291
2023-10-24 01:48:11 +00:00
Sean Feng
2714359424 Bug 1852870 - Make devtools stop decompress decompressed content r=farre,ochameau,necko-reviewers,devtools-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D188499
2023-10-05 18:51:26 +00:00
Randell Jesup
7488358a82 Bug 1848833: Clean up mRedirectedCacheKeys r=valentin,necko-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D188744
2023-09-27 02:50:33 +00:00
sunil mayya
4c719e836d Bug 1820807 - redirect channel for auth retries. r=necko-reviewers,kershaw,valentin
Differential Revision: https://phabricator.services.mozilla.com/D182698
2023-09-25 21:14:17 +00:00
Cristian Tuns
66ae587f22 Backed out 2 changesets (bug 1820807) for causing leak failures CLOSED TREE
Backed out changeset 4e90d1ca661c (bug 1820807)
Backed out changeset 115ae91a6425 (bug 1820807)
2023-09-25 11:35:40 -04:00
sunil mayya
135b6867f0 Bug 1820807 - redirect channel for auth retries. r=necko-reviewers,kershaw,valentin
Differential Revision: https://phabricator.services.mozilla.com/D182698
2023-09-25 09:32:17 +00:00
Cosmin Sabou
253125d194 Backed out 3 changesets (bug 1820807, bug 1853025, bug 1848763) for causing frequent network-related startup crashes (bug 1853231). a=backout
Backed out changeset 92d80b858050 (bug 1848763)
Backed out changeset c08cba545d2c (bug 1853025)
Backed out changeset 2fae28575ca8 (bug 1820807)
2023-09-15 12:33:19 +03:00
sunil mayya
45ae220912 Bug 1820807 - redirect channel for auth retries. r=necko-reviewers,kershaw,valentin
Differential Revision: https://phabricator.services.mozilla.com/D182698
2023-09-13 20:11:00 +00:00
Cosmin Sabou
de07b3c524 Backed out changeset 11fddb3ea9c0 (bug 1820807) for causing xpcshell failures on test_proxy-failover_canceled.js. CLOSED TREE 2023-09-11 18:10:57 +03:00
sunil mayya
7fe95fadf7 Bug 1820807: redirect channel for auth retries. r=necko-reviewers,kershaw,valentin
Differential Revision: https://phabricator.services.mozilla.com/D182698
2023-09-11 13:59:51 +00:00
serge-sans-paille
e56675ede1 Bug 1845449 - get rid of global constructor in netwerk/protocol/http/nsHttp.h r=necko-reviewers,kershaw,valentin
Create a new type of nsHttpAtom, namely nsHttpAtomLiteral. This type is
constexpr-constructible and holds a non-owning reference to its name,
which must have global lifetime.

As a side effect, slightly rework nsHttpAtom interface to replace the
dangerous implicit conversion to const char* by a bool operator and test it.

Differential Revision: https://phabricator.services.mozilla.com/D184557
2023-09-04 14:17:42 +00:00
Narcis Beleuzu
93e972c03d Backed out changeset 81f023cd4619 (bug 1845449) for bustages on HttpWinUtils.cpp . CLOSED TREE 2023-09-04 10:48:57 +03:00
serge-sans-paille
9cad2b0e62 Bug 1845449 - get rid of global constructor in netwerk/protocol/http/nsHttp.h r=necko-reviewers,kershaw,valentin
Create a new type of nsHttpAtom, namely nsHttpAtomLiteral. This type is
constexpr-constructible and holds a non-owning reference to its name,
which must have global lifetime.

As a side effect, slightly rework nsHttpAtom interface to replace the
dangerous implicit conversion to const char* by a bool operator and test it.

Differential Revision: https://phabricator.services.mozilla.com/D184557
2023-09-04 07:10:15 +00:00
Manuel Bucher
43f8338f9c Bug 1842754 - Make LoadInfoArgs non-optional over IPC r=necko-reviewers,jesup
This makes all occurences of LoadInfoArgs non-optional also when
converting between nsILoadInfo in BackgroundUtils.h.

Differential Revision: https://phabricator.services.mozilla.com/D185299
2023-08-11 13:45:25 +00:00
Natalia Csoregi
d2ed1b1ca2 Backed out changeset 3c585e66b44b (bug 1842754) for causing Bug 1847904. CLOSED TREE 2023-08-09 19:35:08 +03:00
Thomas Wisniewski
c2ef40afe0 Bug 1397646 - return empty statusText for HTTP2 fetches and XMLHttpRequests; r=kershaw,necko-reviewers,sunil
Differential Revision: https://phabricator.services.mozilla.com/D184527
2023-08-08 19:47:39 +00:00
Manuel Bucher
f37405ff24 Bug 1842754 - Make LoadInfoArgs non-optional over IPC r=necko-reviewers,jesup
This makes all occurences of LoadInfoArgs non-optional also when
converting between nsILoadInfo in BackgroundUtils.h.

Differential Revision: https://phabricator.services.mozilla.com/D185299
2023-08-08 14:37:19 +00:00
Iulian Moraru
98f7137dd1 Backed out changeset 05857d2111ba (bug 1842754) for causing build bustages on BackgroundUtils.cpp. CLOSED TREE 2023-08-08 13:51:28 +03:00
Manuel Bucher
25a2f89619 Bug 1842754 - Make LoadInfoArgs non-optional over IPC r=necko-reviewers,jesup
This makes all occurences of LoadInfoArgs non-optional also when
converting between nsILoadInfo in BackgroundUtils.h.

Differential Revision: https://phabricator.services.mozilla.com/D185299
2023-08-08 10:25:04 +00:00
Iulian Moraru
3b2efb9273 Backed out changeset 675cf3cb3d33 (bug 1397646) for causing mochitest failures on test_fetch_basic_http.html. CLOSED TREE 2023-08-07 07:46:50 +03:00
Thomas Wisniewski
ae64997bee Bug 1397646 - return empty statusText for HTTP2 fetches and XMLHttpRequests; r=kershaw,necko-reviewers,sunil
Differential Revision: https://phabricator.services.mozilla.com/D184527
2023-08-07 04:00:31 +00:00
Peter Van der Beken
3f4ffadbe1 Bug 1846277 - Untangle nsGlobalWindow*.h includes. r=dom-core,media-playback-reviewers,sessionstore-reviewers,padenot,farre
Differential Revision: https://phabricator.services.mozilla.com/D184978
2023-08-02 20:41:49 +00:00
Kershaw Chang
8c9cb764ad Bug 1791027 - Support transaction pending time for socket process, r=necko-reviewers,jesup
Differential Revision: https://phabricator.services.mozilla.com/D185056
2023-08-02 09:03:57 +00:00
Iulian Moraru
df3805ec86 Backed out changeset 07b44dd04f0d (bug 1397646) for causing XHR related mochitest failures. 2023-08-01 01:56:42 +03:00
Thomas Wisniewski
e8e43661cf Bug 1397646 - return empty statusText for HTTP2 fetches and XMLHttpRequests; r=kershaw,necko-reviewers,sunil
Differential Revision: https://phabricator.services.mozilla.com/D184527
2023-07-31 19:30:16 +00:00
Tim Huang
ebf7945587 Bug 1842030 - Part 2: Check the global private browsing state for HttpBaseChannel::IsBrowsingContextDiscarded() if the loadGroup is not avaiable. r=necko-reviewers,jesup
The HttpBaseChannel::IsBrowsingContextDiscarded() did always return
false if the loadGroup is not avaiable. But, this may not be correct for
the private channels if the private session has been ended. To fix this,
we make the function to check the global private browsing state
if the loadGroup is not available for private channels.

Depends on D184010

Differential Revision: https://phabricator.services.mozilla.com/D184479
2023-07-26 10:14:38 +00:00
Andreas Farre
bc13cd7b8b Bug 1839881 - Don't log when we block ExtContentPolicy::TYPE_BEACON. r=sefeng,necko-reviewers,valentin
This doesn't mean that blocked beacons stops showing up in devtools.

Differential Revision: https://phabricator.services.mozilla.com/D181778
2023-07-07 05:33:58 +00:00
Kershaw Chang
fc2898f123 Bug 1816677 - Allow to retry diffrent IP family for Http/3, r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D180679
2023-06-28 17:20:41 +00:00
Narcis Beleuzu
7ae0c765b0 Backed out changeset dfe0fed4de68 (bug 1816677) for xpcshell failure on test_http3_dns_retry.js . CLOSED TREE 2023-06-24 00:42:37 +03:00
Kershaw Chang
818d909b26 Bug 1816677 - Allow to retry diffrent IP family for Http/3, r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D180679
2023-06-23 15:00:48 +00:00
Sean Feng
dba509892e Bug 1837585 - Make the COEP:Credentialless check ignores the subdocument request if it's a redirect r=valentin,necko-reviewers
We shouldn't block the iframe if the initial request doesn't have valid
headers, we should only check the final request.

Differential Revision: https://phabricator.services.mozilla.com/D180485
2023-06-15 13:07:43 +00:00
Sean Feng
81ade4f308 Bug 1835925 - Expand ORB_BLOCK_INITIATOR telemetry probe to demystify OTHER r=smaug,necko-reviewers,valentin,jesup
Differential Revision: https://phabricator.services.mozilla.com/D179579
2023-06-14 15:25:40 +00:00
Tom Schuster
c6275439e2 Bug 1837153 - Make RFPTarget parameter of ShouldResistFingerprinting with nsIChannel non-optional. r=tjr,cookie-reviewers,timhuang,geckoview-reviewers,owlish
Differential Revision: https://phabricator.services.mozilla.com/D180199
2023-06-13 19:32:17 +00:00
Cristian Tuns
91c8c583d9 Backed out changeset ba4fa2a4dc58 (bug 1835925) for causing build bustages in nsContentSecurityManager.cpp 2023-06-12 11:11:26 -04:00
Sean Feng
688592df12 Bug 1835925 - Expand ORB_BLOCK_INITIATOR telemetry probe to demystify OTHER r=smaug,necko-reviewers,valentin,jesup
Differential Revision: https://phabricator.services.mozilla.com/D179579
2023-06-12 14:39:04 +00:00