Commit graph

138 commits

Author SHA1 Message Date
Emma Malysz
4ddaa9986e Bug 1634042, Part 2: lazify page action panel r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D91187
2020-10-06 00:40:51 +00:00
Dorel Luca
f348e0a63d Backed out changeset d4c1abcfbba0 (bug 1634042) for Browser-chrome failures in browser/base/content/test/touch/browser_menu_touch.js. CLOSED TREE 2020-10-02 02:50:31 +03:00
Emma Malysz
7fb79b4804 Bug 1634042, Part 2: lazify page action panel r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D91187
2020-10-01 15:00:55 +00:00
Csoregi Natalia
f21850ca45 Backed out changeset 0798aa08c2cb (bug 1634042) for failures on browser_menu_touch.js. CLOSED TREE 2020-09-30 09:47:33 +03:00
Emma Malysz
254dec264a Bug 1634042, Part 2: lazify page action panel r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D91187
2020-09-29 22:09:09 +00:00
Emma Malysz
f73e3431ed Bug 1634042, Part 1: migrate page action titles to fluent. r=Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D87822
2020-09-24 17:29:16 +00:00
Mark Banner
02ae3b9de6 Bug 863474 - Centralise OpenSearch install failure prompts into SearchUIUtils. r=daleharvey,flod,geckoview-reviewers,esawin
Differential Revision: https://phabricator.services.mozilla.com/D89879
2020-09-14 11:08:43 +00:00
Razvan Maries
e3020a8f57 Backed out 2 changesets (bug 863474) for build bustages on search.properties. CLOSED TREE
Backed out changeset 5f00eaaa4e2d (bug 863474)
Backed out changeset 42d66b1f9b82 (bug 863474)
2020-09-12 19:41:12 +03:00
Mark Banner
d1abbfeaf8 Bug 863474 - Centralise OpenSearch install failure prompts into SearchUIUtils. r=daleharvey,flod
Differential Revision: https://phabricator.services.mozilla.com/D89879
2020-09-12 14:57:34 +00:00
Mark Banner
e70637b6d9 Bug 1632448 - Remove now unused confirm and extensionID parameters for nsISearchService.addEngine, and rename it. r=daleharvey
Renaming to addOpenSearchEngine to make it more explicit about what it is actually doing.

Depends on D82524

Differential Revision: https://phabricator.services.mozilla.com/D82525
2020-07-09 09:56:25 +00:00
Dave Townsend
e07f989e6c Bug 1620358: Gather telemetry on toolbar state. r=Gijs,zombie
Differential Revision: https://phabricator.services.mozilla.com/D78393
2020-06-16 21:06:15 +00:00
pbz
cd0b28883f Bug 1615588 - pageActions: Use prompt service instead of nsIPrompt. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D66448
2020-04-16 14:44:33 +00:00
Csoregi Natalia
954b969608 Backed out 5 changesets (bug 1615588) for browser-chrome failures e.g. browser_beforeunload_duplicate_dialogs.js. CLOSED TREE
Backed out changeset 751cca7566a8 (bug 1615588)
Backed out changeset 474aca043834 (bug 1615588)
Backed out changeset 7839b95ef76c (bug 1615588)
Backed out changeset 32bb87f48b13 (bug 1615588)
Backed out changeset 264e642042b1 (bug 1615588)

--HG--
extra : rebase_source : 41ed149c97382bc1cf823abc56811b382cae0207
2020-04-10 21:19:15 +03:00
pbz
ff02656f6f Bug 1615588 - pageActions: Use prompt service instead of nsIPrompt. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D66448

--HG--
extra : moz-landing-system : lando
2020-04-10 16:45:12 +00:00
William Durand
b90b5b3778 Bug 1489430 - Add "Remove Extension" context menu item for pageAction. r=robwu,mstriemer,fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D69831

--HG--
extra : moz-landing-system : lando
2020-04-08 14:18:53 +00:00
Edgar Chen
e2aca2c26d Bug 1615732 - Don't handle click event on Mac when ctrl key is pressed; r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D68775

--HG--
extra : moz-landing-system : lando
2020-04-06 20:56:14 +00:00
Edgar Chen
a32ab22c8c Bug 1615732 - Don't show page action panel on Mac when ctrl key is pressed; r=Gijs
On Mac, ctrl-click will send a context menu event from the widget, so we don't
want to bring up the panel when ctrl key is pressed.

Differential Revision: https://phabricator.services.mozilla.com/D66384

--HG--
extra : moz-landing-system : lando
2020-04-06 20:56:26 +00:00
Cosmin Sabou
3b3f1af25e Backed out 7 changesets (bug 1615732) for bc failures on browser_ext_pageAction_click_types.js. CLOSED TREE
Backed out changeset 031b8abf43a8 (bug 1615732)
Backed out changeset 297d82b338dc (bug 1615732)
Backed out changeset bbcb173e6c44 (bug 1615732)
Backed out changeset d7c5824d4579 (bug 1615732)
Backed out changeset f648cf0653a7 (bug 1615732)
Backed out changeset fcd441a2a860 (bug 1615732)
Backed out changeset fa861e50f198 (bug 1615732)

--HG--
extra : histedit_source : 16a05a43f3a9666c4fcf244062c28a5dc81061fd
2020-04-06 23:49:58 +03:00
Edgar Chen
0de61803a3 Bug 1615732 - Don't handle click event on Mac when ctrl key is pressed; r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D68775

--HG--
extra : moz-landing-system : lando
2020-03-30 12:53:42 +00:00
Edgar Chen
feb7fe3776 Bug 1615732 - Don't show page action panel on Mac when ctrl key is pressed; r=Gijs
On Mac, ctrl-click will send a context menu event from the widget, so we don't
want to bring up the panel when ctrl key is pressed.

Differential Revision: https://phabricator.services.mozilla.com/D66384

--HG--
extra : moz-landing-system : lando
2020-03-13 17:42:04 +00:00
Drew Willcoxon
ae8bef8c20 Bug 1619228 - Prevent the context menu from opening on separators in the page action panel. r=Gijs
Separators are technically actions, so we should ignore them when deciding whether to open the context menu.

Differential Revision: https://phabricator.services.mozilla.com/D65050

--HG--
extra : moz-landing-system : lando
2020-03-03 13:39:35 +00:00
Marco Bonardo
8e3ea27643 Bug 1612653 - Update 'Bookmark This Page' menuitems when the star state changes. r=Standard8
Instead of updating the Bookmark This Page / Edit Bookmark menuteitems on popupshowing,
update them when the star button is suppposed to change. This better supports MacOS behavior
where the native menubar can't be updated after being shown, and avoids many callpoints in
favor of just a few.

Differential Revision: https://phabricator.services.mozilla.com/D64399

--HG--
extra : moz-landing-system : lando
2020-02-27 12:04:15 +00:00
Dave Townsend
29625e4aba Bug 1602186: Allow installing SSBs and launching them from the command line. r=Gijs
Allows for persisting SSBs to storage for realoading in a later app instance.
Also adds a command line argument to load and open an SSB based on its ID.

Differential Revision: https://phabricator.services.mozilla.com/D56289

--HG--
extra : moz-landing-system : lando
2019-12-16 19:49:12 +00:00
Dave Townsend
5d6cb8398a Bug 1603787: Remove the long-expired telemetry logging for page action items. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D57138

--HG--
extra : moz-landing-system : lando
2019-12-13 17:26:58 +00:00
Dave Townsend
35f21af04d Bug 1602176: When available use a site's app manifest to determine what is inside and outside of an SSB. r=Gijs
When launched from a browser we can retrieve a site manifest to provide more
information about the site.

Differential Revision: https://phabricator.services.mozilla.com/D56287

--HG--
extra : moz-landing-system : lando
2019-12-13 15:49:26 +00:00
Arthur Iakab
923816f740 Backed out 3 changesets (bug 1602176, bug 1602173) for causing browser-chrome failures on browser_ssb_direct.js CLOSED TREE
Backed out changeset c7c2e74ae25c (bug 1602176)
Backed out changeset 8243a0bcfcb1 (bug 1602173)
Backed out changeset 01189bae5706 (bug 1602173)
2019-12-13 02:46:37 +02:00
Dave Townsend
356455443d Bug 1602176: When available use a site's app manifest to determine what is inside and outside of an SSB. r=Gijs
When launched from a browser we can retrieve a site manifest to provide more
information about the site.

Differential Revision: https://phabricator.services.mozilla.com/D56287

--HG--
extra : moz-landing-system : lando
2019-12-12 20:23:10 +00:00
Dave Townsend
b6cef263d5 Bug 1602168: Add a command line argument to launch an ssb. r=Gijs
Allows launching a site browser from the command line (see https://bugzilla.mozilla.org/show_bug.cgi?id=1283670).
Moves the code for launching an SSB into a shared module.

Differential Revision: https://phabricator.services.mozilla.com/D56284

--HG--
extra : moz-landing-system : lando
2019-12-12 20:23:00 +00:00
Dave Townsend
c696551b78 Bug 1602123: Add a page action to open the current tab into a standalone window. r=Gijs
The action should open the SSB UI to show the page. No other custom behaviour
is expecgterd at this point.

Differential Revision: https://phabricator.services.mozilla.com/D56283

--HG--
extra : moz-landing-system : lando
2019-12-12 20:22:50 +00:00
Brindusan Cristian
d784ce8921 Backed out 2 changesets (bug 1602168, bug 1602123) for turning bug 1336075 into perma. CLOSED TREE
Backed out changeset b892c240d938 (bug 1602168)
Backed out changeset f47c59a4e3d3 (bug 1602123)

--HG--
extra : histedit_source : c3cddd5170a0d0e98753cd01f901964a92ad48bc
2019-12-11 04:44:43 +02:00
Dave Townsend
e891cab2a3 Bug 1602168: Add a command line argument to launch an ssb. r=Gijs
Allows launching a site browser from the command line (see https://bugzilla.mozilla.org/show_bug.cgi?id=1283670).
Moves the code for launching an SSB into a shared module.

Differential Revision: https://phabricator.services.mozilla.com/D56284

--HG--
extra : moz-landing-system : lando
2019-12-10 22:33:06 +00:00
Dave Townsend
597e62a81e Bug 1602123: Add a page action to open the current tab into a standalone window. r=Gijs
The action should open the SSB UI to show the page. No other custom behaviour
is expecgterd at this point.

Differential Revision: https://phabricator.services.mozilla.com/D56283

--HG--
extra : moz-landing-system : lando
2019-12-10 22:33:10 +00:00
Harry Twyford
4f99373ef5 Bug 1599123 - Rename instances of "search icon" to "search button". r=mak
Differential Revision: https://phabricator.services.mozilla.com/D54539

--HG--
extra : moz-landing-system : lando
2019-11-26 09:38:02 +00:00
Harry Twyford
baac927898 Bug 1592268 - Make the permanent search icon a bookmarks doorhanger anchor. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D51814

--HG--
extra : moz-landing-system : lando
2019-11-05 16:28:13 +00:00
monikamaheshwari
9d60e0d578 Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629

--HG--
extra : moz-landing-system : lando
2019-09-14 09:39:26 +00:00
Edouard Oger
f4b32d8096 Bug 1579445 - Refresh the FxA device list on Send Tab menu open. r=markh
Differential Revision: https://phabricator.services.mozilla.com/D45189

--HG--
extra : moz-landing-system : lando
2019-09-12 22:42:31 +00:00
James Teh
ee21b9ffb2 Bug 1571389: For page actions which show an iframe, focus the iframe when the action is activated. r=jaws
This includes the Save to Pocket action.
Previously, keyboard users had to press f6 twice to focus the iframe.
Worse, screen reader users weren't aware anything popped up at all.

Differential Revision: https://phabricator.services.mozilla.com/D40913

--HG--
extra : moz-landing-system : lando
2019-08-07 21:03:42 +00:00
Tim Nguyen
b6d8cc41ad Bug 1569375 - Refactor browser panel CSS to reduce shadow DOM traversal after CE conversion. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D39594

--HG--
extra : moz-landing-system : lando
2019-07-31 15:22:08 +00:00
Victor Porof
f9f5914039 Bug 1561435 - Format browser/base/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36041

--HG--
extra : source : 96b3895a3b2aa2fcb064c85ec5857b7216884556
2019-07-05 09:48:57 +02:00
Andrew Swan
293531d7dd Bug 1557871 Fix badged-button leftovers r=dao
In bug 1519577, the badged-button class for toolbarbuttons was replaced
with a "badged" attribute but a few old uses of the class were overlooked.
This patch fixes them.

Differential Revision: https://phabricator.services.mozilla.com/D34438

--HG--
extra : moz-landing-system : lando
2019-06-11 14:36:18 +00:00
Boris Zbarsky
9de72a3ac6 Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D34196

--HG--
extra : moz-landing-system : lando
2019-06-11 15:51:51 +00:00
Andrew Swan
a745ec6099 Bug 1519577 Convert toolbarbutton to a custom element r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D31941

--HG--
extra : rebase_source : 3709ef713f1a7dc9fbc2d0ac97f16bea757fcd2b
2019-05-20 10:01:02 -07:00
Andrew Swan
b14c25d6ab Bug 1519577 Mark badged page action toolbarbuttons before inserting r=Gijs
The "add search engine" page action wants to use badged toolbarbuttons,
but it does this by adding the "badged-button" class (which changes the
XBL binding) after the button has already been created and added to
the DOM.  To avoid having to switch between non-badged and badged buttons
when toolbarbutton is converted to custom elements, add a property to
page actions so that the badged status can be determined when the element
is created.

Differential Revision: https://phabricator.services.mozilla.com/D31940

--HG--
extra : rebase_source : 335ba3c9ff73f3fa2f17ac113623e5572f7389c5
2019-05-14 20:39:38 -07:00
Vijay Budhram
b326d15f68 Bug 1524665 - Add send tab to device button, r=gijs
Differential Revision: https://phabricator.services.mozilla.com//D23387

--HG--
extra : rebase_source : 2f41fc8a0f78149105b32b87017e1d9035cc5d3e
2019-03-13 20:31:59 +00:00
Ricky Rosario
4c98b7c5c0 Bug 1528952 - Add Pin tab action to the Page Actions Menu r=andreio,dao
MozReview-Commit-ID: 4MMiF2u61uV

Differential Revision: https://phabricator.services.mozilla.com/D20422

--HG--
extra : moz-landing-system : lando
2019-02-22 08:04:12 +00:00
Mark Striemer
911fb7280f Bug 1500147 - Part 3: Record add-on manager telemetry for page/browser actions r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D18003

--HG--
extra : moz-landing-system : lando
2019-02-07 16:43:02 +00:00
Mike de Boer
4e948732c1 Bug 1525833 - nsISearchService::addEngine does not support using a callback anymore, instead it returns a Promise. Update the searchbar's usage to reflect this. r=florian
This also officially gets rid of the nsIBrowserSearchInitObserver and nsISearchInstallCallback
from nsISearchService.idl, even though they're not used for anything anymore.

Differential Revision: https://phabricator.services.mozilla.com/D18993

--HG--
extra : moz-landing-system : lando
2019-02-07 16:17:54 +00:00
Mike de Boer
481ae95c00 Bug 1524593 - nsISearchService (aka nsIBrowserSearchService, previously) refactor to be mostly an asynchronous, in preparation of WebExtension engines. r=daleharvey
This is a rollup of all the patches that have landed on the cedar project branch:

891252fdd0
Bug 1492475 - Part 1: Migrate most, if not all nsSearchService consumers to use async APIs. r=florian

79b2eb2367
Bug 1492475 - Part 2: Move nsIBrowserSearchService.idl to toolkit/components/search/nsISearchService.idl and update references. r=florian

a947d3cdf0
Bug 1492475 - Part 3: The search service init() method should simply return a Promise. r=florian

c1e172dfac
Bug 1492475 - Part 4: Remove the synchronous initialization flow. r=florian

cd41189eac
Bug 1492475 - Part 5: Since async initialization of the search service now is implicit behavior, remove the distinctive verbiage used internally. r=florian

2ae7189dfa
Bug 1492475 - Part 6: Update the cache build task to work with an actual Promise and re-initialize only once at the same time - all to fix race conditions here. r=florian

c8ee92973f
Bug 1492475 - Part 7: Make the region fetch not block the init flow, to ensure it's as fast as possible. r=florian

c44e674e16
Bug 1492475 - Part 8: Introduce an init flag, which can only be used privately, that allows to explicitly skip waiting for the region check process to complete. r=florian

6c79eaf1d3
Bug 1492475 - Part 9: Update unit tests to stop using 'currentEngine', in favor of 'defaultEngine'. r=Standard8

21b3aa17ee
Bug 1492475 - Part 10: Update unit tests to be fully aware of the new, async signatures of the search service API and remove sync init flow tests. r=mkaply,florian

ce5ba69019
Bug 1492475 - Part 11: Repair incorrect usage of the `identifier` property of nsISearchEngine instances. r=florian

fd177a7994
Bug 1518543 - Fix up the Android (Fennec) nsISearchService shim to work with the new asynchronous API. r=florian

3653d8ee22
Bug 1523708 - Change the search service interaction in the show-heartbeat action to use the new async API. r=florian

Differential Revision: https://phabricator.services.mozilla.com/D18355

--HG--
rename : netwerk/base/nsIBrowserSearchService.idl => toolkit/components/search/nsISearchService.idl
extra : moz-landing-system : lando
2019-02-02 11:27:21 +00:00
Edouard Oger
40fc208fc3 Bug 1516997 p2 - Use hasSyncedThisSession to determine if Send Tab is configured and loading. r=markh
Depends on D15657

Differential Revision: https://phabricator.services.mozilla.com/D15658

--HG--
extra : moz-landing-system : lando
2019-01-03 22:29:03 +00:00
James Teh
3efa5efdbd Bug 1506504: Add/fix keyboard behaviour for browser toolbar buttons which open popups. r=Gijs
1. Fix the Firefox menu button so that it only handles space and enter, rather than incorrectly activating for *all* key presses.
2. Add keyboard support (space and enter) for the Library and page Actions buttons.
3. Add keyboard support (space and enter) for customizable widgets of type "view"; e.g. the Developer button.
4. Add keyboard support (space and enter) for page action buttons pinned to the URL bar; e.g. the Send Tab to Device button.

Differential Revision: https://phabricator.services.mozilla.com/D11608

--HG--
extra : moz-landing-system : lando
2018-12-20 11:33:32 +00:00