On Mac, ctrl-click will send a context menu event from the widget, so we don't
want to bring up the panel when ctrl key is pressed.
Differential Revision: https://phabricator.services.mozilla.com/D66384
--HG--
extra : moz-landing-system : lando
On Mac, ctrl-click will send a context menu event from the widget, so we don't
want to bring up the panel when ctrl key is pressed.
Differential Revision: https://phabricator.services.mozilla.com/D66384
--HG--
extra : moz-landing-system : lando
Separators are technically actions, so we should ignore them when deciding whether to open the context menu.
Differential Revision: https://phabricator.services.mozilla.com/D65050
--HG--
extra : moz-landing-system : lando
Instead of updating the Bookmark This Page / Edit Bookmark menuteitems on popupshowing,
update them when the star button is suppposed to change. This better supports MacOS behavior
where the native menubar can't be updated after being shown, and avoids many callpoints in
favor of just a few.
Differential Revision: https://phabricator.services.mozilla.com/D64399
--HG--
extra : moz-landing-system : lando
Allows for persisting SSBs to storage for realoading in a later app instance.
Also adds a command line argument to load and open an SSB based on its ID.
Differential Revision: https://phabricator.services.mozilla.com/D56289
--HG--
extra : moz-landing-system : lando
When launched from a browser we can retrieve a site manifest to provide more
information about the site.
Differential Revision: https://phabricator.services.mozilla.com/D56287
--HG--
extra : moz-landing-system : lando
When launched from a browser we can retrieve a site manifest to provide more
information about the site.
Differential Revision: https://phabricator.services.mozilla.com/D56287
--HG--
extra : moz-landing-system : lando
The action should open the SSB UI to show the page. No other custom behaviour
is expecgterd at this point.
Differential Revision: https://phabricator.services.mozilla.com/D56283
--HG--
extra : moz-landing-system : lando
The action should open the SSB UI to show the page. No other custom behaviour
is expecgterd at this point.
Differential Revision: https://phabricator.services.mozilla.com/D56283
--HG--
extra : moz-landing-system : lando
This includes the Save to Pocket action.
Previously, keyboard users had to press f6 twice to focus the iframe.
Worse, screen reader users weren't aware anything popped up at all.
Differential Revision: https://phabricator.services.mozilla.com/D40913
--HG--
extra : moz-landing-system : lando
In bug 1519577, the badged-button class for toolbarbuttons was replaced
with a "badged" attribute but a few old uses of the class were overlooked.
This patch fixes them.
Differential Revision: https://phabricator.services.mozilla.com/D34438
--HG--
extra : moz-landing-system : lando
The "add search engine" page action wants to use badged toolbarbuttons,
but it does this by adding the "badged-button" class (which changes the
XBL binding) after the button has already been created and added to
the DOM. To avoid having to switch between non-badged and badged buttons
when toolbarbutton is converted to custom elements, add a property to
page actions so that the badged status can be determined when the element
is created.
Differential Revision: https://phabricator.services.mozilla.com/D31940
--HG--
extra : rebase_source : 335ba3c9ff73f3fa2f17ac113623e5572f7389c5
This also officially gets rid of the nsIBrowserSearchInitObserver and nsISearchInstallCallback
from nsISearchService.idl, even though they're not used for anything anymore.
Differential Revision: https://phabricator.services.mozilla.com/D18993
--HG--
extra : moz-landing-system : lando
This is a rollup of all the patches that have landed on the cedar project branch:
891252fdd0
Bug 1492475 - Part 1: Migrate most, if not all nsSearchService consumers to use async APIs. r=florian
79b2eb2367
Bug 1492475 - Part 2: Move nsIBrowserSearchService.idl to toolkit/components/search/nsISearchService.idl and update references. r=florian
a947d3cdf0
Bug 1492475 - Part 3: The search service init() method should simply return a Promise. r=florian
c1e172dfac
Bug 1492475 - Part 4: Remove the synchronous initialization flow. r=florian
cd41189eac
Bug 1492475 - Part 5: Since async initialization of the search service now is implicit behavior, remove the distinctive verbiage used internally. r=florian
2ae7189dfa
Bug 1492475 - Part 6: Update the cache build task to work with an actual Promise and re-initialize only once at the same time - all to fix race conditions here. r=florian
c8ee92973f
Bug 1492475 - Part 7: Make the region fetch not block the init flow, to ensure it's as fast as possible. r=florian
c44e674e16
Bug 1492475 - Part 8: Introduce an init flag, which can only be used privately, that allows to explicitly skip waiting for the region check process to complete. r=florian
6c79eaf1d3
Bug 1492475 - Part 9: Update unit tests to stop using 'currentEngine', in favor of 'defaultEngine'. r=Standard8
21b3aa17ee
Bug 1492475 - Part 10: Update unit tests to be fully aware of the new, async signatures of the search service API and remove sync init flow tests. r=mkaply,florian
ce5ba69019
Bug 1492475 - Part 11: Repair incorrect usage of the `identifier` property of nsISearchEngine instances. r=florian
fd177a7994
Bug 1518543 - Fix up the Android (Fennec) nsISearchService shim to work with the new asynchronous API. r=florian
3653d8ee22
Bug 1523708 - Change the search service interaction in the show-heartbeat action to use the new async API. r=florian
Differential Revision: https://phabricator.services.mozilla.com/D18355
--HG--
rename : netwerk/base/nsIBrowserSearchService.idl => toolkit/components/search/nsISearchService.idl
extra : moz-landing-system : lando
1. Fix the Firefox menu button so that it only handles space and enter, rather than incorrectly activating for *all* key presses.
2. Add keyboard support (space and enter) for the Library and page Actions buttons.
3. Add keyboard support (space and enter) for customizable widgets of type "view"; e.g. the Developer button.
4. Add keyboard support (space and enter) for page action buttons pinned to the URL bar; e.g. the Send Tab to Device button.
Differential Revision: https://phabricator.services.mozilla.com/D11608
--HG--
extra : moz-landing-system : lando