Commit graph

5108 commits

Author SHA1 Message Date
Tim Huang
efbd2d64af Bug 1675420 - Cache the content principal before change the remoteness in BrowserReloadWithFlags() r=johannh
This patch makes the BrowserReloadWithFlags() to cache the content
principal before the remoteness changes. And use this cached principal
as the triggering principal for reloading.

We need to do this because the content principal in a browser will be
cleared during changing the remoteness. The browser will be destoried
and then constructed, and the content principal will be cleared. So, we
need to cache the content principal before in order to use the correct
principal.

Differential Revision: https://phabricator.services.mozilla.com/D96408
2020-11-10 11:50:40 +00:00
Jared Wein
5ff732cdc1 Bug 1674199 - Remove the special case of showing the bookmarks toolbar on about:blank if NTP is disabled. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D95196
2020-11-10 04:18:47 +00:00
Micah Tigley
ee30ccbff9 Bug 1675549 - Stop using the 2h2020 pref to block new shortcut for the bookmarks toolbar. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D96471
2020-11-09 21:43:17 +00:00
Tim Nguyen
353f334d13 Bug 1583696 - Remove XUL grid from toolkit/components/prompts/content/tabprompts.jsm. r=MattN,marionette-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D61442
2020-11-08 03:52:32 +00:00
Bogdan Tara
92c3461ba3 Backed out changeset 5ed5e8a6bbfb (bug 1583696) for modal prompt related failures CLOSED TREE 2020-11-08 02:14:49 +02:00
Tim Nguyen
50565cbf0e Bug 1583696 - Remove XUL grid from toolkit/components/prompts/content/tabprompts.jsm. r=MattN,marionette-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D61442
2020-11-07 21:53:58 +00:00
Razvan Maries
10425eddfc Backed out 7 changesets (bug 1658084, bug 1671983) for perma failures on browser_async_remove_tab.js and browser_e10s_chrome_process.js. CLOSED TREE
Backed out changeset 2e6309c1cdbd (bug 1658084)
Backed out changeset 99aafd9304ef (bug 1671983)
Backed out changeset 80280b85280a (bug 1671983)
Backed out changeset 008db2659002 (bug 1671983)
Backed out changeset 32bd45c7fe3a (bug 1671983)
Backed out changeset 56e227e6580c (bug 1671983)
Backed out changeset a404f809f79d (bug 1671983)
2020-11-04 04:23:47 +02:00
Nika Layzell
a30f10ec01 Bug 1671983 - Part 2: Remove SessionStore.navigateAndRestore, r=annyG,kashav
This formed the backbone of the previous process switching codepath, and
shouldn't be necessary anymore thanks to DocumentChannel's new codepath.

This also removes the eager process switching logic from frontend's _loadURI, as
it would rarely be taken, unless an invalid URI was entered, already.

Differential Revision: https://phabricator.services.mozilla.com/D94639
2020-11-04 00:55:23 +00:00
Nika Layzell
b20d2f0f1b Bug 1671983 - Part 1: Remove now-unused process switching shouldLoadURI methods, r=annyG,geckoview-reviewers,snorp
These methods are no longer necessary, as all loads which can trigger process
switches now go through DocumentChannel.

The shouldLoadURI methods on nsIWebBrowserChrome3 are unfortunately still
necessary as they're used by the disabled-by-default "Single-Site Browser"
feature. In the future this may be possible to clean-up.

Differential Revision: https://phabricator.services.mozilla.com/D94638
2020-11-04 00:55:23 +00:00
Jared Wein
bab6d447fc Bug 1673363 - Check the URIs to load in new windows when determining to show the bookmarks toolbar. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D95111
2020-11-02 21:55:12 +00:00
Gijs Kruitbosch
fe2014a3ab Bug 1673490 - do not update bookmarks toolbar visibility for same-document navigations, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D95426
2020-11-02 15:45:19 +00:00
pbz
4bb1d2403f Bug 1565574 - Update frontend callers of external protocol service to pass principal. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D93645
2020-10-29 13:05:27 +00:00
Jared Wein
ed77853fbe Bug 1673402 - Don't show the bookmarks toolbar on the new tab page if there are no contents. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D94775
2020-10-27 18:23:31 +00:00
Gijs Kruitbosch
89428b7ffb Bug 1673341 - fix menu bar toggling to persist the correct state, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D94729
2020-10-26 14:52:56 +00:00
Jared Wein
3d2a8005c8 Bug 727668 - Show bookmarks toolbar on the new tab page. r=Gijs,fluent-reviewers,marionette-reviewers,whimboo
This adds the ability to force the bookmarks toolbar to appear on all pages. The checkbox in the toolbar context menu will reflect if the toolbar will appear outside of the newtab page. The toolbar will always appear on the newtab page. Profiles that already had the toolbar showing will have a migration to keep their experience unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D89222
2020-10-26 02:32:07 +00:00
Mihai Alexandru Michis
f11e661f24 Backed out changeset ba261cf25651 (bug 727668) for causing marionette failures in test_screenshot.py
CLOSED TREE
2020-10-22 06:13:54 +03:00
Jared Wein
e0e5f6bba3 Bug 727668 - Show bookmarks toolbar on the new tab page. r=Gijs,fluent-reviewers
This adds the ability to force the bookmarks toolbar to appear on all pages. The checkbox in the toolbar context menu will reflect if the toolbar will appear outside of the newtab page. The toolbar will always appear on the newtab page. Profiles that already had the toolbar showing will have a migration to keep their experience unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D89222
2020-10-21 19:20:20 +00:00
Narcis Beleuzu
8945877156 Backed out 1 changesets (bug 727668) for bc failures on browser_aboutNewTab_bookmarksToolbar.js . CLOSED TREE
Backed out changeset 5b6a14b4e16e (bug 727668)
2020-10-19 21:19:17 +03:00
Jared Wein
0e83701c0c Bug 727668 - Show bookmarks toolbar on the new tab page. r=Gijs,fluent-reviewers
This adds the ability to force the bookmarks toolbar to appear on all pages. The checkbox in the toolbar context menu will reflect if the toolbar will appear outside of the newtab page. The toolbar will always appear on the newtab page. Profiles that already had the toolbar showing will have a migration to keep their experience unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D89222
2020-10-19 16:38:17 +00:00
Henrik Skupin
40f4853ce1 Bug 1669698 - [marionette] Use dedicated "marionette-listening" notification to inform the browser when marionette is active. r=marionette-reviewers,jdescottes,Gijs
By not re-using the "remote-listening" observer topic in Marionette
allows us to send different data through the observer notification.

This also prevents a crash in the Remote Agent component, which
expects a string, and not a boolean value to receive in data.

Differential Revision: https://phabricator.services.mozilla.com/D93513
2020-10-15 16:04:44 +00:00
Anny Gakhokidze
5190a944e2 Bug 1670966 - Add a separate pref to enable Non-Fission window option, r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D93413
2020-10-13 20:42:10 +00:00
Emilio Cobos Álvarez
ff1f98dfc8 Bug 1602915 - Remove nsIBrowserDOMWindow.isTabContentWindow. r=mossop,marionette-reviewers,whimboo
This only works for non-e10s and it also seems superseded by the
mPendingClose as per the comment.

Differential Revision: https://phabricator.services.mozilla.com/D92003
2020-10-13 16:58:37 +00:00
Drew Willcoxon
7fcd89e4bb Bug 1655486 - Support search mode across sessions. r=mak
* Always update the `_searchModesByBrowser` map when entering/exiting search
  mode, not only for non-selected browsers, so that search mode can be saved and
  restored properly per tab.
* Rename `setSearchMode` to `_updateSearchModeUI` and make it only update the UI.
* Add a new `setSearchMode` method that takes a browser and updates the map.
* Add `getSearchMode` so that SessionStore can get the search mode for a given
  browser.
* Add a `searchMode` getter and setter for convenience. They call
  `getSearchMode` and `setSearchMode` with the selected browser.

Differential Revision: https://phabricator.services.mozilla.com/D91910
2020-10-12 03:34:59 +00:00
Emilio Cobos Álvarez
4e68e78542 Bug 1669925 - Add a printing.trigger keyed scalar to record what triggers a particular print dialog. r=jwatt,marionette-reviewers,maja_zf
In order to avoid over/under-counting, we need to treat window.print()
specially. The new UI was using aOpenWindowInfo.isForPrintPreview for
that, but that doesn't quite work for the old UI (because it will
trigger a regular print, not a preview).

But since isForPrintPreview was only really needed to distinguish
window.print(), just rename it and set it to true when the old UI is
triggered by window.print() as well.

Differential Revision: https://phabricator.services.mozilla.com/D92925
2020-10-09 14:59:46 +00:00
Emilio Cobos Álvarez
4b4935794b Bug 140718 - Add a "Print selection only" entry to the context menu. r=Gijs,jwatt,fluent-reviewers
This allows to use the feature from the context menu and is very
straight-forward.

This has the benefit of working with fission (as print from the focused
frame) and so on.

Making a checkbox on the UI on top of this is doable, but it is a lot
more complex (requires a bunch of both front-end and platform work)
because undoing this implies restoring the DOM which "print selection"
removes.

I think the context menu entry is very useful regardless of whether we
add a checkbox to undo it, and other browsers (with smaller context
menus) seem to agree.

Differential Revision: https://phabricator.services.mozilla.com/D92205
2020-10-07 20:45:08 +00:00
Michael Kaply
f82d5c549f Bug 1665237 - Make managed bookmarks item dynamic. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D90628
2020-10-06 20:13:00 +00:00
J.C. Jones
1bd162dde3 Bug 1540309 - Track browsing context for the WebAuthn UX prompts r=nhnt11
The WebAuthn popup just used the current selected browser for its context,
while we actually want to stick with the window that brought us to the party.

This adds tests to ensure that the doorhanger stays on the tab it was originally
attached to, avoiding the 'wandering doorhanger' problem from the bug.

Differential Revision: https://phabricator.services.mozilla.com/D72255
2020-10-05 22:20:41 +00:00
Kris Maglione
6911cfe5e9 Bug 1666670: Fix beforeunload timeout handling to ignore prompt. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D91351
2020-10-01 02:46:45 +00:00
Daisuke Akatsuka
37cb66004f Bug 1638633: Introduce loadSearchFromExtension to use same mechanism as loadSearchFrom*. r=mak,robwu
Differential Revision: https://phabricator.services.mozilla.com/D91560
2020-10-01 00:12:15 +00:00
Narcis Beleuzu
4fa3a7f995 Backed out changeset 6cf959e2de7b (bug 1666670) for wpt failures on scroll-behavior-smooth.html . CLOSED TREE 2020-10-01 05:20:54 +03:00
Kris Maglione
49bc543261 Bug 1666670: Fix beforeunload timeout handling to ignore prompt. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D91351
2020-09-30 19:39:56 +00:00
Gijs Kruitbosch
694bed5ea1 Bug 1657263 - use pdf.js to determine whether we can find in the pdf, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D91718
2020-09-29 20:00:50 +00:00
Micah Tigley
3524fbc87d Bug 1328637 - Add a keyboard shortcut for showing/hiding the bookmarks toolbar. r=jaws,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D90132
2020-09-29 15:04:54 +00:00
Razvan Maries
7979196254 Backed out changeset 2b2e72856dc1 (bug 1665237) for perma failures on browser_popupNode.js. CLOSED TREE 2020-09-25 06:03:12 +03:00
Kris Maglione
bbfbd2f113 Bug 1660057: Add preferences for Fission rollout Normandy experiment. r=nika,marionette-reviewers,perftest-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D91066
2020-09-25 02:01:15 +00:00
Michael Kaply
baf3127120 Bug 1665237 - Make managed bookmarks item dynamic. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D90628
2020-09-22 20:08:17 +00:00
Razvan Maries
8de1e9f262 Backed out changeset 737f0e3e2f94 (bug 1660057) for xpcshell perma failures. CLOSED TREE 2020-09-24 23:25:54 +03:00
Kris Maglione
04dc79653a Bug 1660057: Add preferences for Fission rollout Normandy experiment. r=nika,marionette-reviewers,perftest-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D91066
2020-09-24 18:35:58 +00:00
Csoregi Natalia
9d16fe7e4d Backed out changeset 034825cf1c71 (bug 1665237) for multiple failures e.g. browser_1007336_lwthemes_in_customize_mode.js. CLOSED TREE 2020-09-22 21:48:53 +03:00
Michael Kaply
63434c4e40 Bug 1665237 - Make managed bookmarks item dynamic. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D90628
2020-09-22 15:51:42 +00:00
Kris Maglione
d3498e1041 Bug 1655866: Part 5 - Use native PermitUnload implementation from front-end code. r=nika,mconley
Differential Revision: https://phabricator.services.mozilla.com/D88318
2020-09-21 22:41:04 +00:00
Mihai Alexandru Michis
903eef7389 Backed out changeset bd318d959528 (bug 727668) for causing multiple failures
CLOSED TREE
2020-09-22 03:02:17 +03:00
Jared Wein
3a697d4e80 Bug 727668 - Show bookmarks toolbar on the new tab page. r=Gijs
This adds the ability to force the bookmarks toolbar to appear on all pages. The checkbox in the toolbar context menu will reflect if the toolbar will appear outside of the newtab page. The toolbar will always appear on the newtab page. Profiles that already had the toolbar showing will have a migration to keep their experience unchanged.

Differential Revision: https://phabricator.services.mozilla.com/D89222
2020-09-21 17:01:41 +00:00
Harry Twyford
b2cc3e61c2 Bug 1657676 - Add search mode preview. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D89964
2020-09-17 03:31:04 +00:00
Emma Malysz
b94b50a7ae Bug 1660665, hide subdialog if user chooses to print using system dialog. r=jwatt,Gijs,mstriemer
When the user chooses to print using the system dialog, we should hide the print
UI. We are choosing to hide the dialog stack instead of closing the dialog because
the print preview browser still needs to be available if the user tries to print.
We close the window if the user cancels the system dialog or once we receive the
promise from PrintUtils.printWindow.

Differential Revision: https://phabricator.services.mozilla.com/D88096
2020-09-17 02:18:50 +00:00
Dorel Luca
ac0e714d57 Backed out changeset b445d02b1367 (bug 1657676) for Browser-chrome failures in newtab/test/browser/browser_topsites_section.js. CLOSED TREE 2020-09-17 04:46:23 +03:00
Harry Twyford
8f95a2e763 Bug 1657676 - Add search mode preview. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D89964
2020-09-16 23:18:59 +00:00
Brindusan Cristian
09fafce1c6 Backed out changeset 6e3078121a13 (bug 1657676) for bc failures at browser_oneOffs_keyModifiers.js. CLOSED TREE 2020-09-16 03:18:05 +03:00
Harry Twyford
b769c92faf Bug 1657676 - Add search mode preview. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D89964
2020-09-15 22:55:12 +00:00
Jared Wein
573c5943de Bug 1662098 - Move default browser notification to JS Window Actor and use pageshow to trigger if the notification will appear. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D88909
2020-09-14 18:26:23 +00:00