nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
793514 commits 1 branch 98 tags 6.4 GiB
Commit graph

96 commits

Author SHA1 Message Date
Edgar Chen
177354af27 Bug 1756388; r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D144193
 2022-05-03 19:11:30 +00:00
Mark Banner
2d563feacc Bug 1758476 - Remove some unnecessary uses of the target object argument to ChromeUtils.import. r=mossop,webdriver-reviewers,perftest-reviewers,robwu,whimboo,AlexandruIonescu 
Differential Revision: https://phabricator.services.mozilla.com/D140518
 2022-03-17 22:13:08 +00:00
Cristian Tuns
e8374bd569 Backed out changeset 528295e7cb0c (bug 1758476) for causing tabswitch failures CLOSED TREE 2022-03-14 12:27:48 -04:00
Mark Banner
0ce30e3008 Bug 1758476 - Remove some unnecessary uses of the target object argument to ChromeUtils.import. r=mossop,webdriver-reviewers,perftest-reviewers,robwu,whimboo,AlexandruIonescu 
Differential Revision: https://phabricator.services.mozilla.com/D140518
 2022-03-14 10:19:40 +00:00
Mark Banner
8bb4667fae Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D140517
 2022-03-11 16:41:29 +00:00
smolnar
e89faa903f Backed out changeset 5018856d8fee (bug 1758474) for causing node eslint failure. CLOSED TREE 2022-03-10 11:58:45 +02:00
Mark Banner
fe937b78bd Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D140517
 2022-03-10 09:25:28 +00:00
aminomancer
c95531067d Bug 1591040 - show both fullscreen and normal toolbar/tabstrip context menus in full screen, r=jaws,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D131493
 2022-01-21 22:52:24 +00:00
Norisz Fay
d4c6499662 Backed out changeset e23259733a51 (bug 1591040) for causing bc failures on browser_fullscreen_context_menu.js CLOSED TREE 2022-01-19 13:32:54 +02:00
aminomancer
d6cedea199 Bug 1591040 - show both fullscreen and normal toolbar/tabstrip context menus in full screen, r=jaws,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D131493
 2022-01-19 10:14:34 +00:00
Edgar Chen
f9a4a6bd64 Bug 1739220 - Handle fullscreen state in a more reliable way; r=smaug,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D131185
 2021-12-17 09:15:10 +00:00
Csoregi Natalia
3bea0a777e Backed out 2 changesets (bug 1739220) for causing multiple failures e.g.browser_media_control_non_eligible_media.js. CLOSED TREE 
Backed out changeset 20bce7cd571c (bug 1739220)
Backed out changeset f69aa1b07b51 (bug 1739220)
 2021-12-14 20:32:26 +02:00
Edgar Chen
0b9cb3fd37 Bug 1739220 - Handle fullscreen state in a more reliable way; r=smaug,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D131185
 2021-12-14 15:23:54 +00:00
Paul Zuehlcke
3ddba51ab7 Bug 1739091, r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D131268
 2021-11-22 16:11:45 +00:00
Harry Twyford
972c0c1053 Bug 1701929 - Define positioning required for Mac fullscreen slide in CSS to avoid frame reconstruction. r=mstange,Gijs 
Baseline profile: https://share.firefox.dev/3p5PgDn (jank)
Profile with just setting pinned tab position to absolute: https://share.firefox.dev/30jKR5p (jank)
Profile with just moving relative positioning to CSS: https://share.firefox.dev/3p6c5a7 (jank)
Profile with this patch: https://share.firefox.dev/3FRLmnK (no jank)

Markus said setting abspos pinned tabs would be safe as long as there were no relative-positioned ancestors in the tab overflow scrollbox. The only notable ancestor of a pinned tab is the tab arrowscrollbox itself, so there aren't any surprise ancestors here. Manual testing indicates things work fine.

I also confirmed that this patch fixes bug 1725151.

Differential Revision: https://phabricator.services.mozilla.com/D121403
 2021-10-20 13:59:23 +00:00
Emilio Cobos Alvarez
756c14b26a Bug 1735318 - Unify "native" vs. "fullscreen" window controls. r=desktop-theme-reviewers,dao 
I've tested this (both with and without titlebar) in Linux, Win10,
Win11, Win7 and macOS.

 * On macOS behavior doesn't change at all (since on fullscreen we didn't
show the buttons to begin with).

 * Linux now shows "native" buttons on fullscreen (which is also an
improvement).

 * On Windows 10/11 the sizing of the buttons is now the same when
fullscreen vs. not (which is an improvement).

 * On Windows 7 we now use regular native-looking buttons (like on
   windows 10) instead of the custom windowControls.png. That could be
   considered a slight regression I guess, but is consistent with win10.

Differential Revision: https://phabricator.services.mozilla.com/D128196
 2021-10-12 13:20:13 +00:00
Harry Twyford
1a72ada683 Bug 1706901 - Allow the toolbar to shift with position: relative. r=mstange,desktop-theme-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D113612
 2021-04-28 20:15:38 +00:00
Harry Twyford
ee556a8d23 Bug 740148 - Allow toolbar autohide in fullscreen on macOS, but disable it by default. r=mac-reviewers,mstange,bradwerth 
Differential Revision: https://phabricator.services.mozilla.com/D110573
 2021-04-01 18:16:25 +00:00
Harry Twyford
1aa4fbec7b Bug 1695921 - Rename OSXLionFullscreen to macOSNativeFullscreen. r=mac-reviewers,mstange 
Differential Revision: https://phabricator.services.mozilla.com/D109931
 2021-03-26 16:34:54 +00:00
Harry Twyford
c816de536a Bug 1699506 - Part 2 - Add CSS rules to shift the toolbar over the content when the macOS menubar is shown. r=mstange 
Differential Revision: https://phabricator.services.mozilla.com/D106847
 2021-03-18 20:20:40 +00:00
james
16060f0cc4 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D104552
 2021-02-13 23:33:51 +00:00
Narcis Beleuzu
ed6880e281 Backed out changeset b3fcb4fcea64 (bug 1691274) for bc failures on browser_pointerlock_warning.js . CLOSED TREE 2021-02-13 21:46:51 +02:00
james
8069ab6165 Bug 1691274 - Use DOM hidden property methods instead of attribute methods in browser/ directory. r=ntim,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D104552
 2021-02-13 18:11:18 +00:00
Emma Malysz
a71f7f0454 Bug 1678211, remove unused fullscreen.used telemetry probe r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D98124
 2020-12-01 16:59:30 +00:00
Xidorn Quan
e4463bf519 Bug 729011 - Make fullscr-toggler not affect viewport size. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D97736
 2020-11-20 11:21:03 +00:00
Steven MacLeod
8a2f140b36 Bug 1656741, r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D91760
 2020-10-05 22:38:03 +00:00
Gijs Kruitbosch
62c443a7c8 Bug 1663879 - do not show 'pdf.js' as the origin of the full screen request, r=jaws 
Depends on D89675

Differential Revision: https://phabricator.services.mozilla.com/D89676
 2020-09-11 15:05:50 +00:00
Gijs Kruitbosch
b2dee52fd3 Bug 1663879 - migrate fullscreen and pointer lock warnings to fluent, r=jaws,fluent-reviewers,flod 
Differential Revision: https://phabricator.services.mozilla.com/D89675
 2020-09-12 20:09:26 +00:00
Alphan Chen
4b0d7eb9e6 Bug 1644484 - Handle the TypeError and InvalidStateError when calling FullScreen.cleanupDomFullscreen() from DOMFullscreenParent.didDestroy() r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D81716
 2020-07-03 03:00:53 +00:00
Jan Horak
1b2ff0b054 Bug 1594738 Remove top black line from kiosk mode; r=mkaply 
There is a fullscr-toggler still shown in kiosk mode. This patch
disables it showing when in kiosk mode.

Differential Revision: https://phabricator.services.mozilla.com/D81828
 2020-07-01 13:31:14 +00:00
Emma Malysz
ea1d95a265 Bug 1645460, switch from the expired FX_BROWSER_FULLSCREEN_USED to a scalar that we actually collect until Fx86 r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D79519
 2020-06-17 18:07:40 +00:00
Xidorn Quan
94c939416d Bug 1276537 part 3 - Remove OS X detection code from full screen handling. r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D74556
 2020-05-13 12:43:09 +00:00
Gijs Kruitbosch
e583ec83e1 Bug 1631229 - make popup hiding exiting fullscreen work correctly for tooltips, r=dao 
Differential Revision: https://phabricator.services.mozilla.com/D72461
 2020-04-27 09:30:40 +00:00
Dão Gottwald
03c47b1185 Bug 1632166 - Obey prefers-reduced-motion when animating toolbars for fullscreen mode. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D71959
 2020-04-23 22:15:53 +00:00
Drew Willcoxon
83760cc442 Bug 1610200 - In full screen, properly hide the toolbars after the user picks a result in the urlbar. r=dao 
Two fixes:

* The urlbar view isn't a popup anymore, so `FullScreen` should listen for `onViewOpen` and `onViewClose` on the urlbar controller instead of popup events.
* Change the keypress listeners to keydown to listen for enter events in the urlbar and hide the toolbars.

Differential Revision: https://phabricator.services.mozilla.com/D62123

--HG--
extra : moz-landing-system : lando
 2020-02-13 21:39:08 +00:00
Abdoulaye Oumar Ly
7742d38850 Bug 1590138 - Handle the case where the actor is already destroyed during fullscreen exit so that chrome UI is fully restored. r=smaug,NeilDeakin 
Differential Revision: https://phabricator.services.mozilla.com/D51339

--HG--
extra : moz-landing-system : lando
 2019-11-05 23:29:26 +00:00
Dão Gottwald
c6e65d0008 Bug 1589018 - Remove global-scope pollution from browser-fullScreenAndPointerLock.js. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D49393

--HG--
extra : moz-landing-system : lando
 2019-10-16 12:34:22 +00:00
Dão Gottwald
79806540d1 Bug 1588813 - Remove redundant imports and service getters from browser-fullScreenAndPointerLock.js and nsContextMenu.js. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D49298

--HG--
extra : moz-landing-system : lando
 2019-10-15 15:06:22 +00:00
Abdoulaye Oumar Ly
c558bed276 Bug 1505916 - [Fission] Part 2: Make the fullscreen code work with oop iframes. r=NeilDeakin,smaug 
e10s scenario:
1. An DOM element request fulscreen mode.
2. The request is redirected to the parent.
3. Parent enters fullscreen.
4. Parent notifies child that it has finished entering fullscreen.
5. Child goes fullscreen.
6. Then, child notifies parent that it has finished transitioning to fullscreen.
4. Finally, parent notify observers that fullscreen paint has finished.

Let's go into the details of how step 5 works in the above scenario.
5.a The element that made the request is set to fullscreen.
5.b Then, the document where that element lives is set to fullscreen as well as all of its ancestors until we reach the top level document. (see Document::ApplyFulscreen method)

Now in Fission world, we may have a request comming from an oop iframe. And it that case since we won't have  to ancestor documents living in different content process(es), we will first notiy those content processes (one after another from bottom to top) to go fullscreen. Once they all do, the content process where the request originated will be told to enter fullscreen.

Differential Revision: https://phabricator.services.mozilla.com/D45972

--HG--
extra : moz-landing-system : lando
 2019-10-11 14:30:28 +00:00
Abdoulaye Oumar Ly
a0898dc653 Bug 1505916 - [Fission] Part 1: Make the fullscreen code work with JSWindowActors. r=NeilDeakin,dao,smaug 
At this point, fullscreen is not regressed but it doesn't work with oop iframes yet.

Differential Revision: https://phabricator.services.mozilla.com/D35026

--HG--
extra : moz-landing-system : lando
 2019-10-11 14:30:28 +00:00
Paul Zuehlcke
53a3c77cec Bug 1583665 - Fixed AddonManager.jsm fullscreen check to only cancel installation for DOM fullscreen. r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D47933

--HG--
extra : moz-landing-system : lando
 2019-10-09 09:28:19 +00:00
Michael Kaply
d3547ee818 Bug 158968 - Implement kiosk mode. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D41848

--HG--
extra : moz-landing-system : lando
 2019-10-04 19:47:56 +00:00
monikamaheshwari
9d60e0d578 Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D45629

--HG--
extra : moz-landing-system : lando
 2019-09-14 09:39:26 +00:00
Paul Zuehlcke
9ae51149b7 Bug 1577478 - Log warning to website console when permission prompt / fullscreen is canceled. r=johannh,flod 
Differential Revision: https://phabricator.services.mozilla.com/D44166

--HG--
extra : moz-landing-system : lando
 2019-09-04 17:37:59 +00:00
Paul Zuehlcke
c4e3669f0f Bug 1558439 - Log warning to web console when add-on installation was blocked due to fullscreen. r=johannh,mixedpuppy 
Differential Revision: https://phabricator.services.mozilla.com/D44161

--HG--
extra : moz-landing-system : lando
 2019-08-30 16:34:08 +00:00
Paul Zuehlcke
39687fe7bb Bug 1522120 - Remove permission prompts when entering full-screen and leave full-screen when a permission prompt is shown. r=johannh 
Differential Revision: https://phabricator.services.mozilla.com/D36932

--HG--
extra : moz-landing-system : lando
 2019-07-24 16:17:54 +00:00
Xidorn Quan
6aee66b8fb Bug 1403085 - Add a pref to use native full screen for Fullscreen API on macOS. r=spohl,dao 
Differential Revision: https://phabricator.services.mozilla.com/D37151

--HG--
extra : moz-landing-system : lando
 2019-07-17 13:31:41 +00:00
Victor Porof
f9f5914039 Bug 1561435 - Format browser/base/, a=automatic-formatting 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36041

--HG--
extra : source : 96b3895a3b2aa2fcb064c85ec5857b7216884556
 2019-07-05 09:48:57 +02:00
Neil Deakin
e5fb1d5934 Bug 1533948, change BrowserTabChild to inherit from JSWindowActor, r=mconley 
--HG--
extra : rebase_source : 5e88e30ac09c15e6747f6ef1019e9b27a793a898
 2019-06-11 09:05:33 -04:00
Paul Zuehlcke
15881e3dff Bug 1412561 - Block addon installation prompts in fullscreen mode. r=johannh,aswan 
Differential Revision: https://phabricator.services.mozilla.com/D27734

--HG--
extra : moz-landing-system : lando
 2019-05-03 21:44:24 +00:00