Commit graph

57 commits

Author SHA1 Message Date
Gijs Kruitbosch
af731a1375 Bug 1348623 - revert changes from bug 1044586 and fix preferences reload bug by changing the event listener, r=smaug
In bug 1044586 we changed nsDocument::GetEventTargetParent such that events for
a document were not sent to its parent window if the inner window for the
document wasn't the current inner window. Unfortunately it seems this means
event listeners on the window sometimes miss user input events (mousedown etc.)
when user input takes place before the first paint of a new document that's
loading. In order to fix this, this patch backs out the changes from bug 1044586.

This reintroduces the issue we had before with the preference window, where
reloading the preferences quickly meant that its listeners (attached to the
window) got confused by DOMContentLoaded events from a previously loaded
document. Instead of the broad fix to nsDocument::GetEventTargetParent, this
patch simply changes the event listeners from the preferences code to be
attached to the document instead of the window, thus ensuring they only get
notified for events relating to their own document.

MozReview-Commit-ID: 9DImyNst9fS

--HG--
extra : rebase_source : 94936a0ec7e60d61b25ea2e2f3236884b3cf4293
2017-03-20 17:16:34 +00:00
Mark Banner
800c6a4602 Bug 1344027 - Change the import-global-from option for eslint to allow circular references and resolve most of the no-undef issues in browser/components/preferences. r=mossop
MozReview-Commit-ID: BERAbtYkxsF

--HG--
extra : rebase_source : e319699651a8d33db026d7697ccaddd2d1e4e2d3
2017-02-22 10:19:11 +00:00
Jared Wein
43bac26d30 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a

--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
Steffen Wilberg
fda333b194 Bug 1326821: about:preferences - Ctrl+K shortcut doesn't focus searchbar. r=Gijs
MozReview-Commit-ID: 3zNwW2b4K17

--HG--
extra : rebase_source : 667479b4a01ff33a75297513e1cb475b133538e3
2017-01-15 22:00:58 +01:00
Jared Wein
69215fad47 Bug 1325464 - Use ES6 method syntax for preferences. r=MattN
MozReview-Commit-ID: k3Bkm39TtT

--HG--
extra : rebase_source : a3e78734613429ec157e56cf9ef5a087f3f4da61
2016-12-22 15:57:40 -05:00
Wes Kocher
0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
ac17ce81ae Bug 1325464 - Use ES6 method syntax for preferences. r=MattN
MozReview-Commit-ID: k3Bkm39TtT

--HG--
extra : rebase_source : a3e78734613429ec157e56cf9ef5a087f3f4da61
2016-12-22 15:57:40 -05:00
Jared Wein
5bd1728363 Bug 1324167 - Create telemetry probes to track which preference categories are opened. r=Gijs privacy-review=bsmedberg
MozReview-Commit-ID: 39UhphnkKkC

--HG--
extra : rebase_source : 8e711aa36ef8af3b64bd275c996a07921c122433
2016-12-20 16:37:04 -05:00
Jonathan Kingston
9919073d9f Bug 1267916 - part 2 - Add in UX for about:preferences#containers page, r=jaws 2016-11-03 19:31:35 +01:00
Mark Banner
b2464f8fa0 Bug 1311315 - General small fixes for no-undef eslint issues in browser/. r=jaws
Drop linting of the .eslintrc.js config files.
Fix some minor errors in the code (missing let/const, undefined vars).
Let eslint know that some files get their globals from other places (typically via xul script tags).

MozReview-Commit-ID: CwxuwPtRUr6

--HG--
rename : browser/components/contextualidentity/test/browser/.eslintrc.js => browser/components/syncedtabs/test/browser/.eslintrc.js
rename : browser/components/contextualidentity/test/browser/.eslintrc.js => browser/extensions/webcompat/test/browser/.eslintrc.js
extra : rebase_source : 9026aac49953d941853022cbab3e33d7d2f2fa21
2016-10-18 12:34:35 +01:00
Milan Sreckovic
df434f7afc Bug 1299931: Move the follow up cancel into the function that preceeds it. r=jaws
MozReview-Commit-ID: 71HTqbiNV0a

--HG--
extra : rebase_source : d729ba615736a6af60e518f4143cedd0f587a37f
2016-09-01 16:52:24 -04:00
Fischer.json
7190eefb7f Bug 1120967 - Broken middle/right click on links via about:preferences pages. r=jaws
MozReview-Commit-ID: FejMTP3invj

--HG--
extra : transplant_source : xN3%8A%28%5D%B4%82U%FC%DF%CE%CD%22%D0%236%1A%83o
2016-08-19 17:32:31 +08:00
Jared Wein
e6276ea7f5 Bug 1294547 - Enable the comma-spacing rule for eslint. r=felipe
MozReview-Commit-ID: RCSDEvvk2I
2016-08-16 15:44:15 -04:00
Jared Wein
8d45b8762e Bug 1294989 - Enable eslint for browser/components/preferences. r=Gijs
MozReview-Commit-ID: 62ymdZhluHx

--HG--
extra : rebase_source : 330d512f91d840a47e48f39c21d70d13b2953d2d
2016-08-13 21:58:42 -04:00
Milan Sreckovic
6931480ab1 Bug 1285328: Part 2. Add an ability to change the revert/cancel label and/or show the restart later button to the confirmRestartPrompt dialog. r=jaws
MozReview-Commit-ID: D7SDsHqghAS

--HG--
extra : rebase_source : fedeab9570c20aadb4910acd34ea26ed1474c95c
2016-07-14 14:14:28 -04:00
Milan Sreckovic
6b06d7aedd Bug 1285328: Part 1. Make sure the first button/escape is a no-op in these dialogs, and in the potential data loss case, make the default also a no-op. Refactor some common code into preferences.js. r=jaws
MozReview-Commit-ID: 576kGMX08vz

--HG--
extra : rebase_source : d7459ddff9655005eee46ced6cd8ca3d01158038
2016-07-14 13:55:07 -04:00
Gijs Kruitbosch
36e99ddea3 Bug 1239748 - add a user-facing preference to turn off the on-screen keyboard functionality completely, r=jaws
--HG--
extra : commitid : 2k70EZR9a3L
extra : rebase_source : e2970230dae4f0eb01d7b96f7e5fa2dda7ab5564
2016-01-20 15:44:03 +00:00
Andreas Wagner
9b54d50fea Bug 1195256 - preferences: Align question mark to the header of the pane, r=gijs
--HG--
extra : commitid : BqAw6PW94ip
2015-11-24 09:14:46 +00:00
Carsten "Tomcat" Book
08997000eb Backed out 2 changesets (bug 1202902) to recking bug 1202902 to be able to reopen inbound on a CLOSED TREE
Backed out changeset 647025383676 (bug 1202902)
Backed out changeset d70c7fe532c6 (bug 1202902)
2015-10-07 14:03:21 +02:00
Carsten "Tomcat" Book
e7ef778c9d Backed out 1 changesets (bug 1202902) for causing merge conflicts to mozilla-central
Backed out changeset cfc1820361f5 (bug 1202902)

--HG--
extra : rebase_source : 5d3db72337754bc7ab0ed0c30b2896100411ff92
2015-10-07 12:13:45 +02:00
Shu-yu Guo
d06b6030f6 Bug 1202902 - Scripted fix the world. 2015-10-06 14:00:31 -07:00
Shu-yu Guo
64db2267cf Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Jared Wein
0714ebbd67 Bug 1044600 - Close subdialogs when the back button is used in the in-content preferences. r=Gijs 2015-02-02 16:00:00 +00:00
Ian Moody
4f06461dbd Bug 1129930 - JavaScript error: chrome://browser/content/preferences/in-content/preferences.js, line 82: TypeError: getComputedStyle(...) is null. r=Gijs 2015-02-05 16:48:46 +00:00
Ian Moody
f7b7d9853f Bug 1126278 - In-content preferences category list should lose the padding-top on low window heights r=gijs
--HG--
extra : amend_source : b29dede06ee0e0d97a2140bda06a5ede1033c0b9
2015-02-02 17:09:37 +00:00
Gijs Kruitbosch
ad8a8ac5d9 Bug 1012223 - make opening about:preferences faster, r=jaws
--HG--
extra : rebase_source : 23ef8bb84ae55f81bef21b822febf3482f827a92
2015-01-19 17:40:12 +00:00
Florian Quèze
94833decfe Bug 1088660 - Improve the search bar UI to support one-off searches, r=felipe. 2014-11-18 00:59:11 +01:00
Jared Wein
0b3e054e55 Bug 1018066 - Reset in-content preference scroll position when switching panes. r=Unfocused 2014-10-24 02:23:27 -04:00
Sebastian Hengst
800723ca6a Bug 1016300 - Move inline scripts and styles into separate files for in-content preferences. r=Gijs 2014-08-27 00:08:49 +02:00
Matthew Noorenberghe
1afd30fc5a Bug 1021618 - Create the foundation for converting preference dialogs to be in-content. r=jaws a11y=MarcoZ f=Paenglab,davidb 2014-06-26 13:17:17 -04:00
Vikneshwar
085d53d4c1 Bug 1027819 - Replace the deprecated initEvent code with the CustomEvent constructor. r=jaws 2014-06-20 11:28:00 +02:00
Jared Wein
9954500055 Bug 754304 - make in-content preferences linkable via URL. r=mattn 2014-06-19 16:12:52 -04:00
Hernan Rodriguez Colmeiro
2f2ff056e0 Bug 1020245 - Call openPreferences from utilityOverlay.js. r=jaws 2014-06-11 07:39:00 -04:00
Hernan Rodriguez Colmeiro
bc2f010f44 Bug 1014698 - Unable to see the keyboard focus indicator on the category list of in-content preferences, r=jaws 2014-06-03 12:06:00 +01:00
Richard Marti
f3bedef631 Bug 1017874 - Switch to "General" page on load to initialize the help link. r=jaws 2014-05-30 08:32:45 +02:00
Richard Marti
92e5a99a40 Bug 1013523 - Remove history check in in-content preferences.js. r=jaws 2014-05-20 21:11:13 +02:00
Jared Wein
f2734dc7d4 Bug 741047 - Implement opening in-content preferences to a given view. r=Gijs
--HG--
extra : rebase_source : 9b9c58a967bb52b596457f41b697085c46fb0ba6
2014-05-11 15:52:33 -04:00
Carsten "Tomcat" Book
b81afe3348 Backed out changeset 49859608dbb8 (bug 741047) for bc1 memory leaks 2014-05-15 10:31:36 +02:00
Jared Wein
9956304a3f Bug 741047 - Implement opening in-content preferences to a given view. r=Gijs
--HG--
extra : rebase_source : cf486a6e5c8673d66a57e3b726b58073c694a338
2014-05-11 15:52:33 -04:00
Jared Wein
f41c47ecca Backed out changeset 0e11a16741bf (bug 741047) 2014-05-11 17:37:57 -04:00
Jared Wein
7a8afd9c0f Bug 741047 - Implement opening in-content preferences to a given view. r=Gijs 2014-05-11 15:52:33 -04:00
Richard Marti
b599f8c57a Bug 989890 - Port the help button to in-content prefs. r=jaws 2014-05-05 22:54:57 +02:00
Carsten "Tomcat" Book
3b7d34e657 Backed out changeset 22347f9e52cd (bug 989890) for bc1 testfailures 2014-05-07 10:38:27 +02:00
Richard Marti
c4190148f0 Bug 989890 - Port the help button to in-content prefs. r=jaws 2014-05-05 22:54:57 +02:00
Tim Taubert
5e06f9cfca Bug 738796 - Update category navigation. r=jaws 2013-12-05 11:07:16 +01:00
Tim Taubert
43df2515e7 Bug 754344 - Make in-content prefs navigation look like about:addons r=jaws
From 8e5ce19d039052d06c099a87c2c315353bc589cf Mon Sep 17 00:00:00 2001
2013-11-05 13:21:28 +01:00
Manish Goregaokar
92356a4c5c Bug 767313 - Merge the Tabs category into the General category in in-content preferences. r=Unfocused 2013-09-11 13:22:44 +12:00
Jon Rietveld
51f4957e15 Bug 737177 - Port the security pane to the in-content preferences implementation. r=bmcbride 2012-05-08 19:28:24 -07:00
Devan Sayles
fccd56e50a Bug 735091 - Sync pane for in-content prefrences. r=jaws,bmcbride 2012-05-08 19:23:19 -07:00
Devan Sayles
144123e231 Bug 732125 - Content pane for in-content preferences. r=jaws,bmcbride 2012-05-08 19:21:03 -07:00